kernel_samsung_a53x/fs/ext4
Artem Sadovnikov fe7c357e85 ext4: fix i_data_sem unlock order in ext4_ind_migrate()
[ Upstream commit cc749e61c011c255d81b192a822db650c68b313f ]

Fuzzing reports a possible deadlock in jbd2_log_wait_commit.

This issue is triggered when an EXT4_IOC_MIGRATE ioctl is set to require
synchronous updates because the file descriptor is opened with O_SYNC.
This can lead to the jbd2_journal_stop() function calling
jbd2_might_wait_for_commit(), potentially causing a deadlock if the
EXT4_IOC_MIGRATE call races with a write(2) system call.

This problem only arises when CONFIG_PROVE_LOCKING is enabled. In this
case, the jbd2_might_wait_for_commit macro locks jbd2_handle in the
jbd2_journal_stop function while i_data_sem is locked. This triggers
lockdep because the jbd2_journal_start function might also lock the same
jbd2_handle simultaneously.

Found by Linux Verification Center (linuxtesting.org) with syzkaller.

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Co-developed-by: Mikhail Ukhin <mish.uxin2012@yandex.ru>
Signed-off-by: Mikhail Ukhin <mish.uxin2012@yandex.ru>
Signed-off-by: Artem Sadovnikov <ancowi69@gmail.com>
Rule: add
Link: https://lore.kernel.org/stable/20240404095000.5872-1-mish.uxin2012%40yandex.ru
Link: https://patch.msgid.link/20240829152210.2754-1-ancowi69@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-23 23:21:42 +01:00
..
acl.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
acl.h ext4: apply umask if ACL support is disabled 2024-11-18 11:43:31 +01:00
balloc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
bitmap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
block_validity.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dir.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ext4.h ext4: Add no_sehash_xattr mount option 2024-11-17 17:43:35 +01:00
ext4_extents.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ext4_jbd2.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ext4_jbd2.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
extents.c ext4: avoid use-after-free in ext4_ext_show_leaf() 2024-11-23 23:21:42 +01:00
extents_status.c ext4: fix infinite loop when replaying fast_commit 2024-11-23 23:20:09 +01:00
extents_status.h ext4: make ext4_es_insert_extent() return void 2024-11-18 23:19:51 +01:00
fast_commit.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
fast_commit.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
file.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
fsmap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
fsmap.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
fsync.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hash.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ialloc.c ext4: avoid negative min_clusters in find_group_orlov() 2024-11-23 23:21:23 +01:00
indirect.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
inline.c ext4: return error on ext4_find_inline_entry 2024-11-23 23:21:23 +01:00
inode-test.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
inode.c ext4: check the extent status again before inserting delalloc block 2024-11-23 23:20:19 +01:00
ioctl.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Kconfig Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mballoc.c ext4: clear EXT4_GROUP_INFO_WAS_TRIMMED_BIT even mount with discard 2024-11-23 23:21:23 +01:00
mballoc.h ext4: add two helper functions extent_logical_end() and pa_logical_end() 2024-11-18 10:58:45 +01:00
migrate.c ext4: fix i_data_sem unlock order in ext4_ind_migrate() 2024-11-23 23:21:42 +01:00
mmp.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
move_extent.c ext4: fix double-free of blocks due to wrong extents moved_len 2024-11-18 12:13:30 +01:00
namei.c ext4: make sure the first directory block is not a hole 2024-11-23 23:20:13 +01:00
page-io.c ext4: handle redirtying in ext4_bio_write_page() 2024-11-23 23:20:59 +01:00
readpage.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
resize.c ext4: fix corruption during on-line resize 2024-11-19 09:22:34 +01:00
super.c ext4: fix error code saved on super block during file system abort 2024-11-19 14:19:51 +01:00
symlink.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sysfs.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
truncate.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
verity.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
xattr.c ext4: avoid writing unitialized memory to disk in EA inodes 2024-11-23 23:20:10 +01:00
xattr.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
xattr_hurd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
xattr_security.c ext4: Add no_sehash_xattr mount option 2024-11-17 17:43:35 +01:00
xattr_trusted.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
xattr_user.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00