Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kernel_samsung_a53x/drivers/net/wireguard
History
Nikita Zhandarovich 85f4665d3d wireguard: receive: annotate data-race around receiving_counter.counter 
[ Upstream commit bba045dc4d996d03dce6fe45726e78a1a1f6d4c3 ]

Syzkaller with KCSAN identified a data-race issue when accessing
keypair->receiving_counter.counter. Use READ_ONCE() and WRITE_ONCE()
annotations to mark the data race as intentional.

    BUG: KCSAN: data-race in wg_packet_decrypt_worker / wg_packet_rx_poll

    write to 0xffff888107765888 of 8 bytes by interrupt on cpu 0:
     counter_validate drivers/net/wireguard/receive.c:321 [inline]
     wg_packet_rx_poll+0x3ac/0xf00 drivers/net/wireguard/receive.c:461
     __napi_poll+0x60/0x3b0 net/core/dev.c:6536
     napi_poll net/core/dev.c:6605 [inline]
     net_rx_action+0x32b/0x750 net/core/dev.c:6738
     __do_softirq+0xc4/0x279 kernel/softirq.c:553
     do_softirq+0x5e/0x90 kernel/softirq.c:454
     __local_bh_enable_ip+0x64/0x70 kernel/softirq.c:381
     __raw_spin_unlock_bh include/linux/spinlock_api_smp.h:167 [inline]
     _raw_spin_unlock_bh+0x36/0x40 kernel/locking/spinlock.c:210
     spin_unlock_bh include/linux/spinlock.h:396 [inline]
     ptr_ring_consume_bh include/linux/ptr_ring.h:367 [inline]
     wg_packet_decrypt_worker+0x6c5/0x700 drivers/net/wireguard/receive.c:499
     process_one_work kernel/workqueue.c:2633 [inline]
     ...

    read to 0xffff888107765888 of 8 bytes by task 3196 on cpu 1:
     decrypt_packet drivers/net/wireguard/receive.c:252 [inline]
     wg_packet_decrypt_worker+0x220/0x700 drivers/net/wireguard/receive.c:501
     process_one_work kernel/workqueue.c:2633 [inline]
     process_scheduled_works+0x5b8/0xa30 kernel/workqueue.c:2706
     worker_thread+0x525/0x730 kernel/workqueue.c:2787
     ...

Fixes: a9e90d9931f3 ("wireguard: noise: separate receive counter from send counter")
Reported-by: syzbot+d1de830e4ecdaac83d89@syzkaller.appspotmail.com
Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-19 08:44:59 +01:00
..
selftest Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
allowedips.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
allowedips.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cookie.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cookie.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
device.c Revert "wireguard: use DEV_STATS_INC()" 2024-11-18 20:09:56 +01:00
device.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
main.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
messages.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
netlink.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
netlink.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
noise.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
noise.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
peer.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
peer.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
peerlookup.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
peerlookup.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
queueing.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
queueing.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ratelimiter.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ratelimiter.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
receive.c wireguard: receive: annotate data-race around receiving_counter.counter 2024-11-19 08:44:59 +01:00
send.c Revert "wireguard: use DEV_STATS_INC()" 2024-11-18 20:09:56 +01:00
socket.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
socket.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
timers.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
timers.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
version.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00