kernel_samsung_a53x/drivers/crypto
Pavan Kumar Paluri c63bbe9ccb crypto: ccp - Properly unregister /dev/sev on sev PLATFORM_STATUS failure
commit ce3d2d6b150ba8528f3218ebf0cee2c2c572662d upstream.

In case of sev PLATFORM_STATUS failure, sev_get_api_version() fails
resulting in sev_data field of psp_master nulled out. This later becomes
a problem when unloading the ccp module because the device has not been
unregistered (via misc_deregister()) before clearing the sev_data field
of psp_master. As a result, on reloading the ccp module, a duplicate
device issue is encountered as can be seen from the dmesg log below.

on reloading ccp module via modprobe ccp

Call Trace:
  <TASK>
  dump_stack_lvl+0xd7/0xf0
  dump_stack+0x10/0x20
  sysfs_warn_dup+0x5c/0x70
  sysfs_create_dir_ns+0xbc/0xd
  kobject_add_internal+0xb1/0x2f0
  kobject_add+0x7a/0xe0
  ? srso_alias_return_thunk+0x5/0xfbef5
  ? get_device_parent+0xd4/0x1e0
  ? __pfx_klist_children_get+0x10/0x10
  device_add+0x121/0x870
  ? srso_alias_return_thunk+0x5/0xfbef5
  device_create_groups_vargs+0xdc/0x100
  device_create_with_groups+0x3f/0x60
  misc_register+0x13b/0x1c0
  sev_dev_init+0x1d4/0x290 [ccp]
  psp_dev_init+0x136/0x300 [ccp]
  sp_init+0x6f/0x80 [ccp]
  sp_pci_probe+0x2a6/0x310 [ccp]
  ? srso_alias_return_thunk+0x5/0xfbef5
  local_pci_probe+0x4b/0xb0
  work_for_cpu_fn+0x1a/0x30
  process_one_work+0x203/0x600
  worker_thread+0x19e/0x350
  ? __pfx_worker_thread+0x10/0x10
  kthread+0xeb/0x120
  ? __pfx_kthread+0x10/0x10
  ret_from_fork+0x3c/0x60
  ? __pfx_kthread+0x10/0x10
  ret_from_fork_asm+0x1a/0x30
  </TASK>
  kobject: kobject_add_internal failed for sev with -EEXIST, don't try to register things with the same name in the same directory.
  ccp 0000:22:00.1: sev initialization failed
  ccp 0000:22:00.1: psp initialization failed
  ccp 0000:a2:00.1: no command queues available
  ccp 0000:a2:00.1: psp enabled

Address this issue by unregistering the /dev/sev before clearing out
sev_data in case of PLATFORM_STATUS failure.

Fixes: 200664d5237f ("crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support")
Cc: stable@vger.kernel.org
Signed-off-by: Pavan Kumar Paluri <papaluri@amd.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-23 23:21:31 +01:00
..
allwinner Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
amcc Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
amlogic Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
axis Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
bcm crypto: bcm - Fix pointer arithmetic 2024-11-19 12:26:52 +01:00
caam crypto: caam/jr - fix Chacha20 + Poly1305 self test failure 2024-11-18 11:43:03 +01:00
cavium Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ccp crypto: ccp - Properly unregister /dev/sev on sev PLATFORM_STATUS failure 2024-11-23 23:21:31 +01:00
ccree Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
chelsio Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
fmp drivers: fmp: remove failing command 2024-06-15 16:28:48 -03:00
fmp_simulator Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hisilicon crypto: hisilicon/hpre - Fix a erroneous check after snprintf() 2024-11-18 11:43:02 +01:00
inside-secure Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
marvell Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mediatek Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
nx Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
qat crypto: qat - Fix ADF_DEV_RESET_SYNC memory leak 2024-11-19 12:27:18 +01:00
qce Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
rockchip Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
stm32 crypto: stm32/crc32 - fix parsing list of devices 2024-11-18 12:13:10 +01:00
ux500 Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
virtio crypto: virtio/akcipher - Fix stack overflow on memcpy 2024-11-18 23:18:28 +01:00
vmx Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
xilinx crypto: xilinx - call finalize with bh disabled 2024-11-19 08:44:52 +01:00
atmel-aes-regs.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-aes.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-authenc.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-ecc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-i2c.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-i2c.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-sha-regs.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-sha.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-sha204a.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-tdes-regs.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atmel-tdes.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
exynos-rng.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
geode-aes.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
geode-aes.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hifn_795x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
img-hash.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ixp4xx_crypto.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Kconfig Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mxs-dcp.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
n2_asm.S Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
n2_core.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
n2_core.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
omap-aes-gcm.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
omap-aes.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
omap-aes.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
omap-crypto.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
omap-crypto.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
omap-des.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
omap-sham.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
padlock-aes.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
padlock-sha.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
picoxcell_crypto.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
picoxcell_crypto_regs.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
qcom-rng.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
s5p-sss.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sa2ul.c crypto: sa2ul - Return crypto_aead_setkey to transfer the error 2024-11-18 12:12:26 +01:00
sa2ul.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sahara.c crypto: sahara - do not resize req->src when doing hash operations 2024-11-18 12:12:27 +01:00
talitos.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
talitos.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00