199db9fa4a
[ Upstream commit b04dcbb7f7b1908806b7dc22671cdbe78ff2b82c ]
The USB disconnect callback is supposed to be short and not too-long
waiting. OTOH, the current code uses snd_card_free() at
disconnection, but this waits for the close of all used fds, hence it
can take long. It eventually blocks the upper layer USB ioctls, which
may trigger a soft lockup.
An easy workaround is to replace snd_card_free() with
snd_card_free_when_closed(). This variant returns immediately while
the release of resources is done asynchronously by the card device
release at the last close.
This patch also splits the code to the disconnect and the free phases;
the former is called immediately at the USB disconnect callback while
the latter is called from the card destructor.
Fixes: 523f1dce3743 ("[ALSA] Add Native Instrument usb audio device support")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20241113111042.15058-5-tiwai@suse.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
9 lines
303 B
C
Executable file
9 lines
303 B
C
Executable file
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef CAIAQ_AUDIO_H
|
|
#define CAIAQ_AUDIO_H
|
|
|
|
int snd_usb_caiaq_audio_init(struct snd_usb_caiaqdev *cdev);
|
|
void snd_usb_caiaq_audio_disconnect(struct snd_usb_caiaqdev *cdev);
|
|
void snd_usb_caiaq_audio_free(struct snd_usb_caiaqdev *cdev);
|
|
|
|
#endif /* CAIAQ_AUDIO_H */
|