9698ed3d34
commit 683cd8259a9b883a51973511f860976db2550a6e upstream. After commit 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode") the keyboard on Dell XPS 13 9350 / 9360 / 9370 models has stopped working after a suspend/resume. The problem appears to be that atkbd_probe() fails when called from atkbd_reconnect() on resume, which on systems where ATKBD_CMD_GETID is skipped can only happen by ATKBD_CMD_SETLEDS failing. ATKBD_CMD_SETLEDS failing because ATKBD_CMD_GETID was skipped is weird, but apparently that is what is happening. Fix this by also skipping ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID. Fixes: 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode") Reported-by: Paul Menzel <pmenzel@molgen.mpg.de> Closes: https://lore.kernel.org/linux-input/0aa4a61f-c939-46fe-a572-08022e8931c7@molgen.mpg.de/ Closes: https://bbs.archlinux.org/viewtopic.php?pid=2146300 Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218424 Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2260517 Tested-by: Paul Menzel <pmenzel@molgen.mpg.de> Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20240126160724.13278-2-hdegoede@redhat.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
---|---|---|
.. | ||
adc-keys.c | ||
adp5520-keys.c | ||
adp5588-keys.c | ||
adp5589-keys.c | ||
amikbd.c | ||
applespi.c | ||
applespi.h | ||
applespi_trace.h | ||
atakbd.c | ||
atkbd.c | ||
bcm-keypad.c | ||
cap11xx.c | ||
clps711x-keypad.c | ||
cros_ec_keyb.c | ||
davinci_keyscan.c | ||
dlink-dir685-touchkeys.c | ||
ep93xx_keypad.c | ||
goldfish_events.c | ||
gpio_keys.c | ||
gpio_keys_polled.c | ||
hil_kbd.c | ||
hilkbd.c | ||
hpps2atkbd.h | ||
imx_keypad.c | ||
imx_sc_key.c | ||
ipaq-micro-keys.c | ||
iqs62x-keys.c | ||
jornada680_kbd.c | ||
jornada720_kbd.c | ||
Kconfig | ||
lkkbd.c | ||
lm8323.c | ||
lm8333.c | ||
locomokbd.c | ||
lpc32xx-keys.c | ||
Makefile | ||
maple_keyb.c | ||
matrix_keypad.c | ||
max7359_keypad.c | ||
mcs_touchkey.c | ||
mpr121_touchkey.c | ||
mtk-pmic-keys.c | ||
newtonkbd.c | ||
nomadik-ske-keypad.c | ||
nspire-keypad.c | ||
omap-keypad.c | ||
omap4-keypad.c | ||
opencores-kbd.c | ||
pmic8xxx-keypad.c | ||
pxa27x_keypad.c | ||
pxa930_rotary.c | ||
qt1050.c | ||
qt1070.c | ||
qt2160.c | ||
s2mps23-key.c | ||
s2mps25-key.c | ||
s2mpu13-key.c | ||
samsung-keypad.c | ||
sh_keysc.c | ||
snvs_pwrkey.c | ||
spear-keyboard.c | ||
st-keyscan.c | ||
stmpe-keypad.c | ||
stowaway.c | ||
sun4i-lradc-keys.c | ||
sunkbd.c | ||
tc3589x-keypad.c | ||
tca6416-keypad.c | ||
tca8418_keypad.c | ||
tegra-kbc.c | ||
tm2-touchkey.c | ||
twl4030_keypad.c | ||
xtkbd.c |