Eric Dumazet b7a2902e57 packet: annotate data-races around ignore_outgoing ... [ Upstream commit 6ebfad33161afacb3e1e59ed1c2feefef70f9f97 ] ignore_outgoing is read locklessly from dev_queue_xmit_nit() and packet_getsockopt() Add appropriate READ_ONCE()/WRITE_ONCE() annotations. syzbot reported: BUG: KCSAN: data-race in dev_queue_xmit_nit / packet_setsockopt write to 0xffff888107804542 of 1 bytes by task 22618 on cpu 0: packet_setsockopt+0xd83/0xfd0 net/packet/af_packet.c:4003 do_sock_setsockopt net/socket.c:2311 [inline] __sys_setsockopt+0x1d8/0x250 net/socket.c:2334 __do_sys_setsockopt net/socket.c:2343 [inline] __se_sys_setsockopt net/socket.c:2340 [inline] __x64_sys_setsockopt+0x66/0x80 net/socket.c:2340 do_syscall_64+0xd3/0x1d0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 read to 0xffff888107804542 of 1 bytes by task 27 on cpu 1: dev_queue_xmit_nit+0x82/0x620 net/core/dev.c:2248 xmit_one net/core/dev.c:3527 [inline] dev_hard_start_xmit+0xcc/0x3f0 net/core/dev.c:3547 __dev_queue_xmit+0xf24/0x1dd0 net/core/dev.c:4335 dev_queue_xmit include/linux/netdevice.h:3091 [inline] batadv_send_skb_packet+0x264/0x300 net/batman-adv/send.c:108 batadv_send_broadcast_skb+0x24/0x30 net/batman-adv/send.c:127 batadv_iv_ogm_send_to_if net/batman-adv/bat_iv_ogm.c:392 [inline] batadv_iv_ogm_emit net/batman-adv/bat_iv_ogm.c:420 [inline] batadv_iv_send_outstanding_bat_ogm_packet+0x3f0/0x4b0 net/batman-adv/bat_iv_ogm.c:1700 process_one_work kernel/workqueue.c:3254 [inline] process_scheduled_works+0x465/0x990 kernel/workqueue.c:3335 worker_thread+0x526/0x730 kernel/workqueue.c:3416 kthread+0x1d1/0x210 kernel/kthread.c:388 ret_from_fork+0x4b/0x60 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:243 value changed: 0x00 -> 0x01 Reported by Kernel Concurrency Sanitizer on: CPU: 1 PID: 27 Comm: kworker/u8:1 Tainted: G W 6.8.0-syzkaller-08073-g480e035fc4c7 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024 Workqueue: bat_events batadv_iv_send_outstanding_bat_ogm_packet Fixes: fa788d986a3a ("packet: add sockopt to ignore outgoing packets") Reported-by: syzbot+c669c1136495a2e7c31f@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/CANn89i+Z7MfbkBLOv=p7KZ7=K1rKHO4P1OL5LYDCtBiyqsa9oQ@mail.gmail.com/T/#t Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com> Reviewed-by: Willem de Bruijn <willemb@google.com> Reviewed-by: Jason Xing <kerneljasonxing@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-11-19 08:44:59 +01:00
..
6lowpan
9p
802
8021q	vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING	2024-11-18 12:13:00 +01:00
appletalk
atm
ax25
batman-adv
bluetooth	Bluetooth: hci_core: Fix possible buffer overflow	2024-11-19 08:44:48 +01:00
bpf
bpfilter
bridge
caif
can	can: j1939: Fix UAF in j1939_sk_match_filter during setsockopt(SO_J1939_FILTER)	2024-11-18 12:13:33 +01:00
ceph
core	packet: annotate data-races around ignore_outgoing	2024-11-19 08:44:59 +01:00
dcb
dccp
decnet
dns_resolver	keys, dns: Fix size check of V1 server-list header	2024-11-18 12:12:43 +01:00
dsa
ethernet
ethtool	ethtool: netlink: Add missing ethnl_ops_begin/complete	2024-11-18 12:12:51 +01:00
hsr	hsr: Fix uninit-value access in hsr_get_node()	2024-11-19 08:44:59 +01:00
ieee802154
ife
ipv4	udp: fix incorrect parameter validation in the udp_lib_getsockopt() function	2024-11-19 08:44:50 +01:00
ipv6	net/ipv4/ipv6: Replace one-element arraya with flexible-array members	2024-11-19 08:44:49 +01:00
iucv	net/iucv: fix the allocation size of iucv_path_table array	2024-11-19 08:44:36 +01:00
kcm	net: kcm: fix incorrect parameter validation in the kcm_getsockopt) function	2024-11-19 08:44:50 +01:00
key
l2tp	l2tp: fix incorrect parameter validation in the pppol2tp_getsockopt() function	2024-11-19 08:44:50 +01:00
l3mdev
lapb
llc	llc: call sock_orphan() at release time	2024-11-18 12:13:22 +01:00
mac80211	wifi: mac80211: fix race condition on enabling fast-xmit	2024-11-18 22:25:32 +01:00
mac802154
mpls
mptcp	mptcp: fix double-free on socket dismantle	2024-11-18 23:18:30 +01:00
ncm
ncsi	net/ncsi: Fix netlink major/minor version numbers	2024-11-18 12:12:28 +01:00
netfilter	netfilter: nf_conntrack_h323: Add protection for bmp length out of range	2024-11-18 23:19:35 +01:00
netlabel	calipso: fix memory leak in netlbl_calipso_add_pass()	2024-11-18 12:12:25 +01:00
netlink	netlink: Fix kernel-infoleak-after-free in __skb_datagram_iter	2024-11-18 23:18:28 +01:00
netrom	netrom: Fix data-races around sysctl_net_busy_read	2024-11-18 23:19:35 +01:00
nfc	nfc: nci: free rx_data_reassembly skb on NCI device cleanup	2024-11-18 12:13:30 +01:00
nsh
openvswitch	net: openvswitch: limit the number of recursions from action sets	2024-11-18 12:13:28 +01:00
packet	packet: annotate data-races around ignore_outgoing	2024-11-19 08:44:59 +01:00
phonet
psample
qrtr
rds	net/rds: fix WARNING in rds_conn_connect_if_down	2024-11-18 23:19:34 +01:00
rfkill
rose
rxrpc	rxrpc: Fix response to PING RESPONSE ACKs to a dead call	2024-11-18 12:13:25 +01:00
sched
sctp
skb_tracer
smc	net/smc: fix illegal rmb_desc access in SMC-D connection dump	2024-11-18 12:12:59 +01:00
strparser
sunrpc	net: sunrpc: Fix an off by one in rpc_sockaddr2uaddr()	2024-11-19 08:44:57 +01:00
switchdev
tipc	tipc: Check the bearer type before calling tipc_udp_nl_bearer_add()	2024-11-18 12:13:25 +01:00
tls	tls: stop recv() if initial process_rx_list gave us non-DATA	2024-11-18 22:25:42 +01:00
unix	af_unix: Annotate data-race of gc_in_progress in wait_for_unix_gc().	2024-11-19 08:44:39 +01:00
vmw_vsock	virtio/vsock: fix logic which reduces credit update messages	2024-11-18 12:12:37 +01:00
wimax
wireless	wifi: nl80211: reject iftype change with mesh ID change	2024-11-18 23:18:29 +01:00
x25	net/x25: fix incorrect parameter validation in the x25_getsockopt() function	2024-11-19 08:44:50 +01:00
xdp
xfrm
compat.c
devres.c
Kconfig
Makefile
socket.c	net: Save and restore msg_namelen in sock_sendmsg	2024-11-18 12:12:07 +01:00
sysctl_net.c
TEST_MAPPING