Hans de Goede 46f6568c7f leds: trigger: Unregister sysfs attributes before calling deactivate() ... [ Upstream commit c0dc9adf9474ecb7106e60e5472577375aedaed3 ] Triggers which have trigger specific sysfs attributes typically store related data in trigger-data allocated by the activate() callback and freed by the deactivate() callback. Calling device_remove_groups() after calling deactivate() leaves a window where the sysfs attributes show/store functions could be called after deactivation and then operate on the just freed trigger-data. Move the device_remove_groups() call to before deactivate() to close this race window. This also makes the deactivation path properly do things in reverse order of the activation path which calls the activate() callback before calling device_add_groups(). Fixes: a7e7a3156300 ("leds: triggers: add device attribute support") Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20240504162533.76780-1-hdegoede@redhat.com Signed-off-by: Lee Jones <lee@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-11-23 23:20:09 +01:00
..
accessibility	speakup: Fix sizeof() vs ARRAY_SIZE() bug	2024-11-19 12:26:51 +01:00
acpi	ACPI: processor_idle: Fix invalid comparison with insertion sort for latency	2024-11-19 14:19:50 +01:00
amba
android	binder: check offset alignment in binder_get_object()	2024-11-19 11:32:22 +01:00
ata	ata: libata-core: Fix double free on error	2024-11-19 14:19:34 +01:00
atm	atm: idt77252: fix a memleak in open_card_ubr0	2024-11-18 12:13:24 +01:00
auxdisplay
base	drivers: core: synchronize really_probe() and dev_uevent()	2024-11-19 14:19:04 +01:00
battery
bcma
block	block: zram_drv: Allow creation of only one ZRAM device	2024-11-19 18:06:30 +01:00
bluetooth	Bluetooth: qca: Fix BT enable failure again for QCA6390 after warm reboot	2024-11-19 14:19:42 +01:00
bts
bus	bus: tegra-aconnect: Update dependency to ARCH_TEGRA	2024-11-19 08:44:45 +01:00
cdrom
char	hpet: Support 32-bit userspace	2024-11-19 14:19:45 +01:00
clk	clk: qcom: mmcc-msm8998: fix venus clock issue	2024-11-19 12:26:59 +01:00
clocksource
connector
counter	counter: ti-eqep: enable clock at probe	2024-11-19 14:19:33 +01:00
cpufreq	cpufreq: exit() callback is optional	2024-11-19 12:26:54 +01:00
cpuidle	cpuidle: menu: Take negative "sleep length" values into account	2024-11-19 18:01:28 +01:00
crypto	crypto: qat - Fix ADF_DEV_RESET_SYNC memory leak	2024-11-19 12:27:18 +01:00
dax
dca
devfreq	PM / devfreq: Fix buffer overflow in trans_stat_show	2024-11-19 11:32:38 +01:00
dio
dma	dmaengine: ioatdma: Fix missing kmem_cache_destroy()	2024-11-19 14:19:09 +01:00
dma-buf	dma-buf/sync_file: Speed up ioctl by omitting debug names	2024-11-19 17:53:23 +01:00
edac	EDAC, i10nm: make skx_common.o a separate module	2024-11-23 23:19:56 +01:00
eisa
extcon	extcon: max8997: select IRQ_DOMAIN instead of depending on it	2024-11-19 12:27:04 +01:00
fingerprint
firewire	firewire: nosy: ensure user_length is taken into account when fetching packet contents	2024-11-19 11:32:46 +01:00
firmware	firmware: turris-mox-rwtm: Initialize completion before mailbox	2024-11-23 23:20:06 +01:00
fpga	fpga: region: add owner module and take its refcount	2024-11-19 12:27:04 +01:00
fsi
gnss
gpio	gpiolib: cdev: Disallow reconfiguration without direction (uAPI v1)	2024-11-19 14:19:33 +01:00
gpu	drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare()	2024-11-23 23:20:08 +01:00
greybus	greybus: Fix use-after-free bug in gb_interface_release due to race condition.	2024-11-19 14:19:05 +01:00
gud
hid	HID: Add quirk for Logitech Casa touchpad	2024-11-19 14:19:06 +01:00
hsi
hv	Drivers: hv: vmbus: Drop error message when 'No request id available'	2024-11-18 23:19:53 +01:00
hwmon	hwmon: (max6697) Fix swapped temp{1,8} critical alarms	2024-11-23 23:19:57 +01:00
hwspinlock
hwtracing	intel_th: pci: Add Lunar Lake support	2024-11-19 14:19:05 +01:00
i2c	i2c: rcar: fix error code in probe()	2024-11-19 14:19:46 +01:00
i3c	i3c: master: cdns: Update maximum prescaler value for i2c clock	2024-11-18 12:13:19 +01:00
ide
idle
ifconn
iio	iio: chemical: bme680: Fix sensor data read operation	2024-11-19 14:19:33 +01:00
infiniband	IB/core: Implement a limit on UMAD receive List	2024-11-19 14:19:40 +01:00
input	Input: i8042 - add Ayaneo Kun to i8042 quirk table	2024-11-19 14:19:48 +01:00
interconnect	interconnect: Treat xlate() returning NULL node as an error	2024-11-18 12:12:00 +01:00
iommu	iommu: pcie: Fix incorrect kmemleak_ignore() usage	2024-11-19 17:53:28 +01:00
ipack
irqchip	arm64: Disable GENERIC_IRQ_EFFECTIVE_AFF_MASK	2024-11-19 17:54:22 +01:00
isdn
kperfmon
kq/mesh
leds	leds: trigger: Unregister sysfs attributes before calling deactivate()	2024-11-23 23:20:09 +01:00
lightnvm
macintosh	macintosh/via-macii: Fix "BUG: sleeping function called from invalid context"	2024-11-19 12:26:55 +01:00
mailbox	mailbox: imx: fix suspend failue	2024-11-19 11:32:20 +01:00
mcb
md	bcache: fix variable length array abuse in btree_iter	2024-11-19 14:19:29 +01:00
media	media: renesas: vsp1: Store RPF partition configuration per RPF instance	2024-11-23 23:20:09 +01:00
memory
memstick
message
mfd	mfd: altera-sysmgr: Call of_node_put() only when of_parse_phandle() takes a ref	2024-11-19 08:44:54 +01:00
misc	uid_sys_stats: Remove dependency on the profiling subsystem	2024-11-19 17:53:52 +01:00
mmc	mmc: Disable crc check	2024-11-19 17:47:04 +01:00
most
mtd	mtd: rawnand: Bypass a couple of sanity checks during NAND identification	2024-11-19 14:19:42 +01:00
muic
mux
net	bna: adjust 'name' buf size of bna_tcb and bna_ccb structures	2024-11-23 23:20:08 +01:00
nfc	NFC: trf7970a: disable all regulators on removal	2024-11-19 11:32:37 +01:00
ntb
nubus
nvdimm
nvme	nvmet: fix a possible leak when destroy a ctrl during qp establishment	2024-11-19 14:19:43 +01:00
nvmem	nvmem: meson-efuse: Fix return value of nvmem callbacks	2024-11-19 14:19:45 +01:00
of	of: dynamic: Synchronize of_changeset_destroy() with the devlink removals	2024-11-19 09:23:10 +01:00
opp	OPP: debugfs: Fix warning around icc_get_name()	2024-11-19 08:44:49 +01:00
oprofile
parisc
parport	parport: parport_serial: Add Brainboxes device IDs and geometry	2024-11-18 12:12:19 +01:00
pci	PCI/PM: Avoid D3cold for HP Pavilion 17 PC/1972 PCIe Ports	2024-11-19 14:19:07 +01:00
pcmcia
perf
phy	phy: tegra: xusb: Add API to retrieve the port number of phy	2024-11-19 09:22:34 +01:00
pinctrl	pinctrl: rockchip: fix pinmux reset in rockchip_pmx_set	2024-11-19 14:19:31 +01:00
platform	platform/chrome: cros_ec_debugfs: fix wrong EC message version	2024-11-23 23:19:56 +01:00
pnp	PNP: ACPI: fix fortify warning	2024-11-18 12:13:09 +01:00
power	power: supply: cros_usbpd: provide ID table for avoiding fallback match	2024-11-19 14:19:07 +01:00
powercap
pps
ps3
ptp	ptp: Fix error message on failed pin verification	2024-11-19 14:19:01 +01:00
pwm	pwm: stm32: Always do lazy disabling	2024-11-23 23:19:56 +01:00
rapidio
ras
regulator	regulator: core: Fix modpost error "regulator_get_regmap" undefined	2024-11-19 14:19:09 +01:00
remoteproc	remoteproc: k3-r5: Jump to error handling labels in start/stop errors	2024-11-19 14:19:05 +01:00
reset	reset: hisilicon: hi6220: fix Wvoid-pointer-to-enum-cast warning	2024-11-18 12:12:16 +01:00
rpmsg	rpmsg: virtio: Free driver_override when rpmsg_remove()	2024-11-18 12:12:56 +01:00
rtc	rtc: mt6397: select IRQ_DOMAIN instead of depending on it	2024-11-19 08:44:58 +01:00
s390	s390/sclp: Fix sclp_init() cleanup on failure	2024-11-19 14:19:48 +01:00
samsung
sbus
scsi	drivers: scsi: Reduce logspam	2024-11-19 17:47:00 +01:00
sensorhub
sensors
sfi
sh
siox
slimbus	slimbus: core: Remove usage of the deprecated ida_simple_xx() API	2024-11-19 09:22:34 +01:00
soc	soc: qcom: pdr: fix parsing of domains lists	2024-11-23 23:20:01 +01:00
soundwire	soundwire: cadence: fix invalid PDI offset	2024-11-19 12:27:00 +01:00
spi	spi: mux: set ctlr->bits_per_word_mask	2024-11-19 14:19:50 +01:00
spmi
spu_verify
ssb
staging	drivers: staging: Import Xiaomi's binder prio driver	2024-11-19 17:46:55 +01:00
sti
target	target/file: allocate the bvec array as part of struct target_core_file_cmd	2024-11-19 17:42:15 +01:00
tc
tee	tee: optee: Fix kernel panic caused by incorrect error handling	2024-11-19 09:22:39 +01:00
thermal
thunderbolt	thunderbolt: Fix wake configurations after device unplug	2024-11-19 11:32:22 +01:00
tty	serial: 8250_omap: Fix Errata i2310 with RX FIFO level check	2024-11-19 14:19:39 +01:00
uh
uio	uio: Fix use-after-free in uio_open	2024-11-18 12:12:19 +01:00
usb	USB: core: Fix duplicate endpoint bug by clearing reserved bits in the descriptor	2024-11-19 14:19:45 +01:00
vdpa
vfio	vfio/fsl-mc: Block calling interrupt handler without trigger	2024-11-19 09:22:45 +01:00
vhost	vhost: Add smp_rmb() in vhost_vq_avail_empty()	2024-11-19 11:32:20 +01:00
vibrator
video	Optimized Console FrameBuffer for upto 70% increase in Performance	2024-11-19 17:30:21 +01:00
virt
virtio	virtio: delete vq in vp_find_vqs_msix() when request_irq() fails	2024-11-19 12:27:09 +01:00
vision
vision3
visorbus
vlynq
vme
w1
watchdog	watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin	2024-11-19 12:27:18 +01:00
xen	xen/events: close evtchn after mapping cleanup	2024-11-19 09:22:39 +01:00
zorro
Kconfig	Added KernelSU	2024-11-19 22:44:48 +01:00
Kconfig.variant1
kernelsu	Added KernelSU	2024-11-19 22:44:48 +01:00
Makefile	Added KernelSU	2024-11-19 22:44:48 +01:00
Makefile.variant1