0e0829bf72
commit 31e97d7c9ae3de072d7b424b2cf706a03ec10720 upstream. This patch replaces max(a, min(b, c)) by clamp(b, a, c) in the solo6x10 driver. This improves the readability and more importantly, for the solo6x10-p2m.c file, this reduces on my system (x86-64, gcc 13): - the preprocessed size from 121 MiB to 4.5 MiB; - the build CPU time from 46.8 s to 1.6 s; - the build memory from 2786 MiB to 98MiB. In fine, this allows this relatively simple C file to be built on a 32-bit system. Reported-by: Jiri Slaby <jirislaby@gmail.com> Closes: https://lore.kernel.org/lkml/18c6df0d-45ed-450c-9eda-95160a2bbb8e@gmail.com/ Cc: <stable@vger.kernel.org> # v6.7+ Suggested-by: David Laight <David.Laight@ACULAB.COM> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> Reviewed-by: David Laight <David.Laight@ACULAB.COM> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
74 lines
2.5 KiB
C
Executable file
74 lines
2.5 KiB
C
Executable file
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2010-2013 Bluecherry, LLC <https://www.bluecherrydvr.com>
|
|
*
|
|
* Original author:
|
|
* Ben Collins <bcollins@ubuntu.com>
|
|
*
|
|
* Additional work by:
|
|
* John Brooks <john.brooks@bluecherry.net>
|
|
*/
|
|
|
|
#ifndef __SOLO6X10_OFFSETS_H
|
|
#define __SOLO6X10_OFFSETS_H
|
|
|
|
#define SOLO_DISP_EXT_ADDR 0x00000000
|
|
#define SOLO_DISP_EXT_SIZE 0x00480000
|
|
|
|
#define SOLO_EOSD_EXT_ADDR \
|
|
(SOLO_DISP_EXT_ADDR + SOLO_DISP_EXT_SIZE)
|
|
#define SOLO_EOSD_EXT_SIZE(__solo) \
|
|
(__solo->type == SOLO_DEV_6010 ? 0x10000 : 0x20000)
|
|
#define SOLO_EOSD_EXT_SIZE_MAX 0x20000
|
|
#define SOLO_EOSD_EXT_AREA(__solo) \
|
|
(SOLO_EOSD_EXT_SIZE(__solo) * 32)
|
|
#define SOLO_EOSD_EXT_ADDR_CHAN(__solo, ch) \
|
|
(SOLO_EOSD_EXT_ADDR + SOLO_EOSD_EXT_SIZE(__solo) * (ch))
|
|
|
|
#define SOLO_MOTION_EXT_ADDR(__solo) \
|
|
(SOLO_EOSD_EXT_ADDR + SOLO_EOSD_EXT_AREA(__solo))
|
|
#define SOLO_MOTION_EXT_SIZE 0x00080000
|
|
|
|
#define SOLO_G723_EXT_ADDR(__solo) \
|
|
(SOLO_MOTION_EXT_ADDR(__solo) + SOLO_MOTION_EXT_SIZE)
|
|
#define SOLO_G723_EXT_SIZE 0x00010000
|
|
|
|
#define SOLO_CAP_EXT_ADDR(__solo) \
|
|
(SOLO_G723_EXT_ADDR(__solo) + SOLO_G723_EXT_SIZE)
|
|
|
|
/* 18 is the maximum number of pages required for PAL@D1, the largest frame
|
|
* possible */
|
|
#define SOLO_CAP_PAGE_SIZE (18 << 16)
|
|
|
|
/* Always allow the encoder enough for 16 channels, even if we have less. The
|
|
* exception is if we have card with only 32Megs of memory. */
|
|
#define SOLO_CAP_EXT_SIZE(__solo) \
|
|
((((__solo->sdram_size <= (32 << 20)) ? 4 : 16) + 1) \
|
|
* SOLO_CAP_PAGE_SIZE)
|
|
|
|
#define SOLO_EREF_EXT_ADDR(__solo) \
|
|
(SOLO_CAP_EXT_ADDR(__solo) + SOLO_CAP_EXT_SIZE(__solo))
|
|
#define SOLO_EREF_EXT_SIZE 0x00140000
|
|
#define SOLO_EREF_EXT_AREA(__solo) \
|
|
(SOLO_EREF_EXT_SIZE * __solo->nr_chans * 2)
|
|
|
|
#define __SOLO_JPEG_MIN_SIZE(__solo) (__solo->nr_chans * 0x00080000)
|
|
|
|
#define SOLO_MP4E_EXT_ADDR(__solo) \
|
|
(SOLO_EREF_EXT_ADDR(__solo) + SOLO_EREF_EXT_AREA(__solo))
|
|
#define SOLO_MP4E_EXT_SIZE(__solo) \
|
|
clamp(__solo->sdram_size - SOLO_MP4E_EXT_ADDR(__solo) - \
|
|
__SOLO_JPEG_MIN_SIZE(__solo), \
|
|
__solo->nr_chans * 0x00080000, 0x00ff0000)
|
|
|
|
#define __SOLO_JPEG_MIN_SIZE(__solo) (__solo->nr_chans * 0x00080000)
|
|
#define SOLO_JPEG_EXT_ADDR(__solo) \
|
|
(SOLO_MP4E_EXT_ADDR(__solo) + SOLO_MP4E_EXT_SIZE(__solo))
|
|
#define SOLO_JPEG_EXT_SIZE(__solo) \
|
|
clamp(__solo->sdram_size - SOLO_JPEG_EXT_ADDR(__solo), \
|
|
__SOLO_JPEG_MIN_SIZE(__solo), 0x00ff0000)
|
|
|
|
#define SOLO_SDRAM_END(__solo) \
|
|
(SOLO_JPEG_EXT_ADDR(__solo) + SOLO_JPEG_EXT_SIZE(__solo))
|
|
|
|
#endif /* __SOLO6X10_OFFSETS_H */
|