Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kernel_samsung_a53x/kernel/trace
History
Steven Rostedt (Google) c0a936e55e tracing: Inform kmemleak of saved_cmdlines allocation 
commit 2394ac4145ea91b92271e675a09af2a9ea6840b7 upstream.

The allocation of the struct saved_cmdlines_buffer structure changed from:

        s = kmalloc(sizeof(*s), GFP_KERNEL);
	s->saved_cmdlines = kmalloc_array(TASK_COMM_LEN, val, GFP_KERNEL);

to:

	orig_size = sizeof(*s) + val * TASK_COMM_LEN;
	order = get_order(orig_size);
	size = 1 << (order + PAGE_SHIFT);
	page = alloc_pages(GFP_KERNEL, order);
	if (!page)
		return NULL;

	s = page_address(page);
	memset(s, 0, sizeof(*s));

	s->saved_cmdlines = kmalloc_array(TASK_COMM_LEN, val, GFP_KERNEL);

Where that s->saved_cmdlines allocation looks to be a dangling allocation
to kmemleak. That's because kmemleak only keeps track of kmalloc()
allocations. For allocations that use page_alloc() directly, the kmemleak
needs to be explicitly informed about it.

Add kmemleak_alloc() and kmemleak_free() around the page allocation so
that it doesn't give the following false positive:

unreferenced object 0xffff8881010c8000 (size 32760):
  comm "swapper", pid 0, jiffies 4294667296
  hex dump (first 32 bytes):
    ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
    ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff  ................
  backtrace (crc ae6ec1b9):
    [<ffffffff86722405>] kmemleak_alloc+0x45/0x80
    [<ffffffff8414028d>] __kmalloc_large_node+0x10d/0x190
    [<ffffffff84146ab1>] __kmalloc+0x3b1/0x4c0
    [<ffffffff83ed7103>] allocate_cmdlines_buffer+0x113/0x230
    [<ffffffff88649c34>] tracer_alloc_buffers.isra.0+0x124/0x460
    [<ffffffff8864a174>] early_trace_init+0x14/0xa0
    [<ffffffff885dd5ae>] start_kernel+0x12e/0x3c0
    [<ffffffff885f5758>] x86_64_start_reservations+0x18/0x30
    [<ffffffff885f582b>] x86_64_start_kernel+0x7b/0x80
    [<ffffffff83a001c3>] secondary_startup_64_no_verify+0x15e/0x16b

Link: https://lore.kernel.org/linux-trace-kernel/87r0hfnr9r.fsf@kernel.org/
Link: https://lore.kernel.org/linux-trace-kernel/20240214112046.09a322d6@gandalf.local.home

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Fixes: 44dc5c41b5b1 ("tracing: Fix wasted memory in saved_cmdlines logic")
Reported-by: Kalle Valo <kvalo@kernel.org>
Tested-by: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-18 12:13:33 +01:00
..
blktrace.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
bpf_trace.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
bpf_trace.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
error_report-traces.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
fgraph.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ftrace.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ftrace_internal.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ipc_logging.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ipc_logging_debug.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ipc_logging_private.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Kconfig Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
kprobe_event_gen_test.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
power-traces.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
preemptirq_delay_test.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ring_buffer.c ring-buffer: Clean ring_buffer_poll_wait() error return 2024-11-18 12:13:31 +01:00
ring_buffer_benchmark.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
rpm-traces.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
synth_event_gen_test.c tracing / synthetic: Disable events after testing in synth_event_gen_test_init() 2024-11-18 12:12:01 +01:00
trace.c tracing: Inform kmemleak of saved_cmdlines allocation 2024-11-18 12:13:33 +01:00
trace.h Revert "tracing: Have trace_event_file have ref counters" 2024-11-18 11:57:24 +01:00
trace_benchmark.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_benchmark.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_boot.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_branch.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_clock.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_dynevent.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_dynevent.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_entries.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_event_perf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_events.c Revert "tracing: Have trace_event_file have ref counters" 2024-11-18 11:57:24 +01:00
trace_events_filter.c Revert "tracing: Have trace_event_file have ref counters" 2024-11-18 11:57:24 +01:00
trace_events_filter_test.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_events_hist.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_events_inject.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_events_synth.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_events_trigger.c tracing/trigger: Fix to return error if failed to alloc snapshot 2024-11-18 12:13:28 +01:00
trace_export.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_functions.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_functions_graph.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_hwlat.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_irqsoff.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_kdb.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_kprobe.c tracing/kprobes: Fix the order of argument descriptions 2024-11-18 11:43:11 +01:00
trace_kprobe_selftest.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_kprobe_selftest.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_mmiotrace.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_nop.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_output.c tracing: Add size check when printing trace_marker output 2024-11-18 12:12:16 +01:00
trace_output.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_preemptirq.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_printk.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_probe.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_probe.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_probe_tmpl.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_readwrite.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_sched_switch.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_sched_wakeup.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_selftest.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_selftest_dynamic.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_seq.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_stack.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_stat.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_stat.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_synth.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_syscalls.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace_uprobe.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
tracing_map.c tracing: Ensure visibility when inserting an element into tracing_map 2024-11-18 12:13:00 +01:00
tracing_map.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00