![]() [ Upstream commit 688cf598665851b9e8cb5083ff1d208ce43d10ff ] Building with W=1 shows that a couple of variables in this driver are only used in certain configurations: drivers/video/fbdev/sis/init301.c:239:28: error: 'SiS_Part2CLVX_6' defined but not used [-Werror=unused-const-variable=] 239 | static const unsigned char SiS_Part2CLVX_6[] = { /* 1080i */ | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:230:28: error: 'SiS_Part2CLVX_5' defined but not used [-Werror=unused-const-variable=] 230 | static const unsigned char SiS_Part2CLVX_5[] = { /* 750p */ | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:211:28: error: 'SiS_Part2CLVX_4' defined but not used [-Werror=unused-const-variable=] 211 | static const unsigned char SiS_Part2CLVX_4[] = { /* PAL */ | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:192:28: error: 'SiS_Part2CLVX_3' defined but not used [-Werror=unused-const-variable=] 192 | static const unsigned char SiS_Part2CLVX_3[] = { /* NTSC, 525i, 525p */ | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:184:28: error: 'SiS_Part2CLVX_2' defined but not used [-Werror=unused-const-variable=] 184 | static const unsigned char SiS_Part2CLVX_2[] = { | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:176:28: error: 'SiS_Part2CLVX_1' defined but not used [-Werror=unused-const-variable=] 176 | static const unsigned char SiS_Part2CLVX_1[] = { | ^~~~~~~~~~~~~~~ This started showing up after the definitions were moved into the source file from the header, which was not flagged by the compiler. Move the definition into the appropriate #ifdef block that already exists next to them. Fixes: 5908986ef348 ("video: fbdev: sis: avoid mismatched prototypes") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Helge Deller <deller@gmx.de> Signed-off-by: Sasha Levin <sashal@kernel.org> |
||
---|---|---|
.. | ||
aty | ||
core | ||
geode | ||
i810 | ||
intelfb | ||
kyro | ||
matrox | ||
mb862xx | ||
mmp | ||
nvidia | ||
omap | ||
omap2 | ||
riva | ||
savage | ||
sis | ||
vermilion | ||
via | ||
68328fb.c | ||
acornfb.c | ||
acornfb.h | ||
amba-clcd.c | ||
amifb.c | ||
arcfb.c | ||
arkfb.c | ||
asiliantfb.c | ||
atafb.c | ||
atafb.h | ||
atafb_iplan2p2.c | ||
atafb_iplan2p4.c | ||
atafb_iplan2p8.c | ||
atafb_mfb.c | ||
atafb_utils.h | ||
atmel_lcdfb.c | ||
au1100fb.c | ||
au1100fb.h | ||
au1200fb.c | ||
au1200fb.h | ||
broadsheetfb.c | ||
bt431.h | ||
bt455.h | ||
bw2.c | ||
c2p.h | ||
c2p_core.h | ||
c2p_iplan2.c | ||
c2p_planar.c | ||
carminefb.c | ||
carminefb.h | ||
carminefb_regs.h | ||
cg3.c | ||
cg6.c | ||
cg14.c | ||
chipsfb.c | ||
cirrusfb.c | ||
clps711x-fb.c | ||
cobalt_lcdfb.c | ||
controlfb.c | ||
controlfb.h | ||
cyber2000fb.c | ||
cyber2000fb.h | ||
da8xx-fb.c | ||
dnfb.c | ||
edid.h | ||
efifb.c | ||
ep93xx-fb.c | ||
ffb.c | ||
fm2fb.c | ||
fsl-diu-fb.c | ||
g364fb.c | ||
gbefb.c | ||
goldfishfb.c | ||
grvga.c | ||
gxt4500.c | ||
hecubafb.c | ||
hgafb.c | ||
hitfb.c | ||
hpfb.c | ||
hyperv_fb.c | ||
i740_reg.h | ||
i740fb.c | ||
imsttfb.c | ||
imxfb.c | ||
Kconfig | ||
leo.c | ||
macfb.c | ||
macmodes.c | ||
macmodes.h | ||
Makefile | ||
maxinefb.c | ||
metronomefb.c | ||
mx3fb.c | ||
n411.c | ||
neofb.c | ||
ocfb.c | ||
offb.c | ||
p9100.c | ||
platinumfb.c | ||
platinumfb.h | ||
pm2fb.c | ||
pm3fb.c | ||
pmag-aa-fb.c | ||
pmag-ba-fb.c | ||
pmagb-b-fb.c | ||
ps3fb.c | ||
pvr2fb.c | ||
pxa3xx-gcu.c | ||
pxa3xx-gcu.h | ||
pxa168fb.c | ||
pxa168fb.h | ||
pxafb.c | ||
pxafb.h | ||
q40fb.c | ||
s1d13xxxfb.c | ||
s3c-fb.c | ||
s3c2410fb-regs-lcd.h | ||
s3c2410fb.c | ||
s3c2410fb.h | ||
s3fb.c | ||
sa1100fb.c | ||
sa1100fb.h | ||
sbuslib.c | ||
sbuslib.h | ||
sh7760fb.c | ||
sh_mobile_lcdcfb.c | ||
sh_mobile_lcdcfb.h | ||
simplefb.c | ||
skeletonfb.c | ||
sm501fb.c | ||
sm712.h | ||
sm712fb.c | ||
smscufx.c | ||
ssd1307fb.c | ||
sstfb.c | ||
sticore.h | ||
stifb.c | ||
sunxvr500.c | ||
sunxvr1000.c | ||
sunxvr2500.c | ||
tcx.c | ||
tdfxfb.c | ||
tgafb.c | ||
tmiofb.c | ||
tridentfb.c | ||
udlfb.c | ||
uvesafb.c | ||
valkyriefb.c | ||
valkyriefb.h | ||
vesafb.c | ||
vfb.c | ||
vga16fb.c | ||
vt8500lcdfb.c | ||
vt8500lcdfb.h | ||
vt8623fb.c | ||
w100fb.c | ||
w100fb.h | ||
wm8505fb.c | ||
wm8505fb_regs.h | ||
wmt_ge_rops.c | ||
wmt_ge_rops.h | ||
xen-fbfront.c | ||
xilinxfb.c |