kernel_samsung_a53x/drivers/input/keyboard
Hans de Goede 9698ed3d34 Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID
commit 683cd8259a9b883a51973511f860976db2550a6e upstream.

After commit 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in
translated mode") the keyboard on Dell XPS 13 9350 / 9360 / 9370 models
has stopped working after a suspend/resume.

The problem appears to be that atkbd_probe() fails when called
from atkbd_reconnect() on resume, which on systems where
ATKBD_CMD_GETID is skipped can only happen by ATKBD_CMD_SETLEDS
failing. ATKBD_CMD_SETLEDS failing because ATKBD_CMD_GETID was
skipped is weird, but apparently that is what is happening.

Fix this by also skipping ATKBD_CMD_SETLEDS when skipping
ATKBD_CMD_GETID.

Fixes: 936e4d49ecbc ("Input: atkbd - skip ATKBD_CMD_GETID in translated mode")
Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
Closes: https://lore.kernel.org/linux-input/0aa4a61f-c939-46fe-a572-08022e8931c7@molgen.mpg.de/
Closes: https://bbs.archlinux.org/viewtopic.php?pid=2146300
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218424
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2260517
Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240126160724.13278-2-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-18 12:13:27 +01:00
..
adc-keys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
adp5520-keys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
adp5588-keys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
adp5589-keys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
amikbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
applespi.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
applespi.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
applespi_trace.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atakbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
atkbd.c Input: atkbd - skip ATKBD_CMD_SETLEDS when skipping ATKBD_CMD_GETID 2024-11-18 12:13:27 +01:00
bcm-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cap11xx.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
clps711x-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cros_ec_keyb.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
davinci_keyscan.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dlink-dir685-touchkeys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ep93xx_keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
goldfish_events.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
gpio_keys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
gpio_keys_polled.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hil_kbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hilkbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hpps2atkbd.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
imx_keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
imx_sc_key.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ipaq-micro-keys.c Input: ipaq-micro-keys - add error handling for devm_kmemdup 2024-11-18 12:12:00 +01:00
iqs62x-keys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
jornada680_kbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
jornada720_kbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Kconfig Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
lkkbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
lm8323.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
lm8333.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
locomokbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
lpc32xx-keys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
maple_keyb.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
matrix_keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
max7359_keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mcs_touchkey.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mpr121_touchkey.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mtk-pmic-keys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
newtonkbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
nomadik-ske-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
nspire-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
omap-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
omap4-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
opencores-kbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pmic8xxx-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pxa27x_keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pxa930_rotary.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
qt1050.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
qt1070.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
qt2160.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
s2mps23-key.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
s2mps25-key.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
s2mpu13-key.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
samsung-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sh_keysc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
snvs_pwrkey.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
spear-keyboard.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
st-keyscan.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
stmpe-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
stowaway.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sun4i-lradc-keys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sunkbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
tc3589x-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
tca6416-keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
tca8418_keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
tegra-kbc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
tm2-touchkey.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
twl4030_keypad.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
xtkbd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00