Sindhu Devale 95d658d28b i40e: Do not use WQ_MEM_RECLAIM flag for workqueue ... [ Upstream commit 2cc7d150550cc981aceedf008f5459193282425c ] Issue reported by customer during SRIOV testing, call trace: When both i40e and the i40iw driver are loaded, a warning in check_flush_dependency is being triggered. This seems to be because of the i40e driver workqueue is allocated with the WQ_MEM_RECLAIM flag, and the i40iw one is not. Similar error was encountered on ice too and it was fixed by removing the flag. Do the same for i40e too. [Feb 9 09:08] ------------[ cut here ]------------ [ +0.000004] workqueue: WQ_MEM_RECLAIM i40e:i40e_service_task [i40e] is flushing !WQ_MEM_RECLAIM infiniband:0x0 [ +0.000060] WARNING: CPU: 0 PID: 937 at kernel/workqueue.c:2966 check_flush_dependency+0x10b/0x120 [ +0.000007] Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_timer snd_seq_device snd soundcore nls_utf8 cifs cifs_arc4 nls_ucs2_utils rdma_cm iw_cm ib_cm cifs_md4 dns_resolver netfs qrtr rfkill sunrpc vfat fat intel_rapl_msr intel_rapl_common irdma intel_uncore_frequency intel_uncore_frequency_common ice ipmi_ssif isst_if_common skx_edac nfit libnvdimm x86_pkg_temp_thermal intel_powerclamp gnss coretemp ib_uverbs rapl intel_cstate ib_core iTCO_wdt iTCO_vendor_support acpi_ipmi mei_me ipmi_si intel_uncore ioatdma i2c_i801 joydev pcspkr mei ipmi_devintf lpc_ich intel_pch_thermal i2c_smbus ipmi_msghandler acpi_power_meter acpi_pad xfs libcrc32c ast sd_mod drm_shmem_helper t10_pi drm_kms_helper sg ixgbe drm i40e ahci crct10dif_pclmul libahci crc32_pclmul igb crc32c_intel libata ghash_clmulni_intel i2c_algo_bit mdio dca wmi dm_mirror dm_region_hash dm_log dm_mod fuse [ +0.000050] CPU: 0 PID: 937 Comm: kworker/0:3 Kdump: loaded Not tainted 6.8.0-rc2-Feb-net_dev-Qiueue-00279-gbd43c5687e05 #1 [ +0.000003] Hardware name: Intel Corporation S2600BPB/S2600BPB, BIOS SE5C620.86B.02.01.0013.121520200651 12/15/2020 [ +0.000001] Workqueue: i40e i40e_service_task [i40e] [ +0.000024] RIP: 0010:check_flush_dependency+0x10b/0x120 [ +0.000003] Code: ff 49 8b 54 24 18 48 8d 8b b0 00 00 00 49 89 e8 48 81 c6 b0 00 00 00 48 c7 c7 b0 97 fa 9f c6 05 8a cc 1f 02 01 e8 35 b3 fd ff <0f> 0b e9 10 ff ff ff 80 3d 78 cc 1f 02 00 75 94 e9 46 ff ff ff 90 [ +0.000002] RSP: 0018:ffffbd294976bcf8 EFLAGS: 00010282 [ +0.000002] RAX: 0000000000000000 RBX: ffff94d4c483c000 RCX: 0000000000000027 [ +0.000001] RDX: ffff94d47f620bc8 RSI: 0000000000000001 RDI: ffff94d47f620bc0 [ +0.000001] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000ffff7fff [ +0.000001] R10: ffffbd294976bb98 R11: ffffffffa0be65e8 R12: ffff94c5451ea180 [ +0.000001] R13: ffff94c5ab5e8000 R14: ffff94c5c20b6e05 R15: ffff94c5f1330ab0 [ +0.000001] FS: 0000000000000000(0000) GS:ffff94d47f600000(0000) knlGS:0000000000000000 [ +0.000002] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ +0.000001] CR2: 00007f9e6f1fca70 CR3: 0000000038e20004 CR4: 00000000007706f0 [ +0.000000] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ +0.000001] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ +0.000001] PKRU: 55555554 [ +0.000001] Call Trace: [ +0.000001] <TASK> [ +0.000002] ? __warn+0x80/0x130 [ +0.000003] ? check_flush_dependency+0x10b/0x120 [ +0.000002] ? report_bug+0x195/0x1a0 [ +0.000005] ? handle_bug+0x3c/0x70 [ +0.000003] ? exc_invalid_op+0x14/0x70 [ +0.000002] ? asm_exc_invalid_op+0x16/0x20 [ +0.000006] ? check_flush_dependency+0x10b/0x120 [ +0.000002] ? check_flush_dependency+0x10b/0x120 [ +0.000002] __flush_workqueue+0x126/0x3f0 [ +0.000015] ib_cache_cleanup_one+0x1c/0xe0 [ib_core] [ +0.000056] __ib_unregister_device+0x6a/0xb0 [ib_core] [ +0.000023] ib_unregister_device_and_put+0x34/0x50 [ib_core] [ +0.000020] i40iw_close+0x4b/0x90 [irdma] [ +0.000022] i40e_notify_client_of_netdev_close+0x54/0xc0 [i40e] [ +0.000035] i40e_service_task+0x126/0x190 [i40e] [ +0.000024] process_one_work+0x174/0x340 [ +0.000003] worker_thread+0x27e/0x390 [ +0.000001] ? __pfx_worker_thread+0x10/0x10 [ +0.000002] kthread+0xdf/0x110 [ +0.000002] ? __pfx_kthread+0x10/0x10 [ +0.000002] ret_from_fork+0x2d/0x50 [ +0.000003] ? __pfx_kthread+0x10/0x10 [ +0.000001] ret_from_fork_asm+0x1b/0x30 [ +0.000004] </TASK> [ +0.000001] ---[ end trace 0000000000000000 ]--- Fixes: 4d5957cbdecd ("i40e: remove WQ_UNBOUND and the task limit of our workqueue") Signed-off-by: Sindhu Devale <sindhu.devale@intel.com> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com> Tested-by: Robert Ganzynkowicz <robert.ganzynkowicz@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Link: https://lore.kernel.org/r/20240423182723.740401-2-anthony.l.nguyen@intel.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-11-19 11:32:37 +01:00
..
accessibility	speakup: Avoid crash on very long word	2024-11-19 11:32:23 +01:00
acpi	Revert "ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default"	2024-11-19 09:23:14 +01:00
amba
android	binder: check offset alignment in binder_get_object()	2024-11-19 11:32:22 +01:00
ata	ata: sata_mv: Fix PCI device ID table declaration compilation warning	2024-11-19 09:23:10 +01:00
atm	atm: idt77252: fix a memleak in open_card_ubr0	2024-11-18 12:13:24 +01:00
auxdisplay
base	x86/rfds: Mitigate Register File Data Sampling (RFDS)	2024-11-19 09:22:40 +01:00
battery	drivers: battery_v2: sec_battery: export {CURRENT/VOLTAGE}_MAX to sysfs	2024-11-17 17:43:14 +01:00
bcma
block	aoe: fix the potential use-after-free problem in aoecmd_cfg_pkts	2024-11-19 08:44:37 +01:00
bluetooth	Bluetooth: btintel: Fixe build regression	2024-11-19 09:23:15 +01:00
bts
bus	bus: tegra-aconnect: Update dependency to ARCH_TEGRA	2024-11-19 08:44:45 +01:00
cdrom
char	hwrng: core - Fix page fault dead lock on mmap-ed hwrng	2024-11-18 12:12:55 +01:00
clk	clk: Get runtime PM before walking tree during disable_unused	2024-11-19 11:32:22 +01:00
clocksource	clocksource/drivers/timer-atmel-tcb: Fix initialization on SAM9 hardware	2024-11-18 11:43:12 +01:00
connector
counter	counter: microchip-tcb-capture: Fix the use of internal GCLK logic	2024-11-08 11:25:51 +01:00
cpufreq	cpufreq: brcmstb-avs-cpufreq: fix up "add check for cpufreq_cpu_get's return value"	2024-11-19 09:22:38 +01:00
cpuidle
crypto	crypto: qat - resolve race condition during AER recovery	2024-11-19 09:22:15 +01:00
dax
dca
devfreq	PM / devfreq: Synchronize devfreq_monitor_[start/stop]	2024-11-18 12:13:09 +01:00
dio
dma	dmaengine: tegra210-adma: Update dependency to ARCH_TEGRA	2024-11-19 08:44:51 +01:00
dma-buf
edac	EDAC/thunderx: Fix possible out-of-bounds string access	2024-11-18 12:12:19 +01:00
eisa
extcon
fingerprint
firewire	firewire: core: use long bus reset on gap count error	2024-11-19 08:44:36 +01:00
firmware	efivarfs: Request at most 512 bytes for variable names	2024-11-19 09:22:41 +01:00
fpga
fsi
gnss
gpio	gpio: fix resource unwinding order in error path	2024-11-18 23:18:30 +01:00
gpu	nouveau: fix instmem race condition around ptr stores	2024-11-19 11:32:23 +01:00
greybus
gud
hid	HID: lenovo: Add middleclick_workaround sysfs knob for cptkbd	2024-11-19 08:44:51 +01:00
hsi
hv	Drivers: hv: vmbus: Drop error message when 'No request id available'	2024-11-18 23:19:53 +01:00
hwmon	hwmon: (amc6821) add of_match table	2024-11-19 09:22:33 +01:00
hwspinlock
hwtracing	coresight: etm4x: Fix width of CCITMIN field	2024-11-18 12:12:19 +01:00
i2c	i2c: i801: Fix block process call transactions	2024-11-18 12:13:29 +01:00
i3c	i3c: master: cdns: Update maximum prescaler value for i2c clock	2024-11-18 12:13:19 +01:00
ide
idle
ifconn
iio	iio: accel: bma400: Fix a compilation problem	2024-11-18 12:13:31 +01:00
infiniband	RDMA/mlx5: Fix port number for counter query in multi-port configuration	2024-11-19 11:32:21 +01:00
input	Input: synaptics-rmi4 - fail probing if memory allocation for "phys" fails	2024-11-19 09:23:14 +01:00
interconnect	interconnect: Treat xlate() returning NULL node as an error	2024-11-18 12:12:00 +01:00
iommu	iommu/vt-d: Allocate local memory for page request queue	2024-11-19 11:32:20 +01:00
ipack
irqchip	irqchip/mips-gic: Don't touch vl_map if a local interrupt is not routable	2024-11-18 22:25:34 +01:00
isdn
kperfmon	Kperfmon: add xyunbound version	2024-06-15 16:28:49 -03:00
kq/mesh
leds	leds: sgm3140: Add missing timer cleanup and flash gpio control	2024-11-19 08:44:56 +01:00
lightnvm
macintosh
mailbox	mailbox: imx: fix suspend failue	2024-11-19 11:32:20 +01:00
mcb	mcb: fix error handling for different scenarios when parsing	2024-11-18 11:43:25 +01:00
md	dm integrity: fix out-of-range warning	2024-11-19 09:22:44 +01:00
media	media: cec: core: remove length check of Timer Status	2024-11-19 11:32:19 +01:00
memory
memstick
message
mfd	mfd: altera-sysmgr: Call of_node_put() only when of_parse_phandle() takes a ref	2024-11-19 08:44:54 +01:00
misc	mei: me: disable RPL-S on SPS and IGN firmwares	2024-11-19 11:32:23 +01:00
mmc	mmc: core: Avoid negative index with array access	2024-11-19 09:22:42 +01:00
most
mtd	mtd: rawnand: meson: fix scrambling mode value in command macro	2024-11-19 09:22:16 +01:00
muic
mux
net	i40e: Do not use WQ_MEM_RECLAIM flag for workqueue	2024-11-19 11:32:37 +01:00
nfc	NFC: trf7970a: disable all regulators on removal	2024-11-19 11:32:37 +01:00
ntb
nubus
nvdimm	nd_btt: Make BTT lanes preemptible	2024-11-18 11:43:03 +01:00
nvme	drivers/nvme: Add quirks for device 126f:2262	2024-11-19 09:23:15 +01:00
nvmem	nvmem: meson-efuse: fix function pointer type mismatch	2024-11-19 09:22:34 +01:00
of	of: dynamic: Synchronize of_changeset_destroy() with the devlink removals	2024-11-19 09:23:10 +01:00
opp	OPP: debugfs: Fix warning around icc_get_name()	2024-11-19 08:44:49 +01:00
oprofile
parisc
parport	parport: parport_serial: Add Brainboxes device IDs and geometry	2024-11-18 12:12:19 +01:00
pci	Manual Revert: PCI/ASPM: Make Intel DG2 L1 acceptable latency unlimited	2024-11-19 10:37:22 +01:00
pcmcia	pcmcia: ds: fix possible name leak in error path in pcmcia_device_add()	2024-11-18 11:43:06 +01:00
perf	perf/arm-cmn: Fix the unhandled overflow status of counter 4 to 7	2024-11-08 11:24:52 +01:00
phy	phy: tegra: xusb: Add API to retrieve the port number of phy	2024-11-19 09:22:34 +01:00
pinctrl	pinctrl: renesas: checker: Limit cfg reg enum checks to provided IDs	2024-11-19 09:23:14 +01:00
platform	platform/x86: touchscreen_dmi: Add an extra entry for a variant of the Chuwi Vi8 tablet	2024-11-19 09:23:14 +01:00
pnp	PNP: ACPI: fix fortify warning	2024-11-18 12:13:09 +01:00
power	power: supply: bq27xxx-i2c: Do not free non existing IRQ	2024-11-18 23:18:29 +01:00
powercap
pps
ps3
ptp	ptp: annotate data-race around q->head and q->tail	2024-11-18 11:43:19 +01:00
pwm	pwm: jz4740: Don't use dev_err_probe() in .request()	2024-11-18 12:12:47 +01:00
rapidio
ras
regulator	regulator: pwm-regulator: Add validity checks in continuous .get_voltage	2024-11-18 22:25:33 +01:00
remoteproc	remoteproc: stm32: fix phys_addr_t format string	2024-11-19 08:45:00 +01:00
reset	reset: hisilicon: hi6220: fix Wvoid-pointer-to-enum-cast warning	2024-11-18 12:12:16 +01:00
rpmsg	rpmsg: virtio: Free driver_override when rpmsg_remove()	2024-11-18 12:12:56 +01:00
rtc	rtc: mt6397: select IRQ_DOMAIN instead of depending on it	2024-11-19 08:44:58 +01:00
s390	s390/zcrypt: fix reference counting on zcrypt card objects	2024-11-19 09:22:35 +01:00
samsung	Fix clang 16 errors treewide	2024-06-15 16:28:48 -03:00
sbus
scsi	scsi: sd: Fix wrong zone_write_granularity value during revalidate	2024-11-19 09:23:16 +01:00
sensorhub	treewide: fix build errors	2024-06-15 16:21:17 -03:00
sensors
sfi
sh
siox
slimbus	slimbus: core: Remove usage of the deprecated ida_simple_xx() API	2024-11-19 09:22:34 +01:00
soc	soc: fsl: qbman: Use raw spinlock for cgr_lock	2024-11-19 09:22:35 +01:00
soundwire	soundwire: stream: fix NULL pointer dereference for multi_link	2024-11-18 12:11:57 +01:00
spi	spi: spi-mt65xx: Fix NULL pointer access in interrupt handler	2024-11-19 08:45:00 +01:00
spmi
spu_verify
ssb
staging	comedi: vmk80xx: fix incomplete endpoint checking	2024-11-19 11:32:22 +01:00
sti
target	scsi: target: core: Add TMF to tmr_list handling	2024-11-18 22:25:32 +01:00
tc
tee	tee: optee: Fix kernel panic caused by incorrect error handling	2024-11-19 09:22:39 +01:00
thermal	thermal: core: prevent potential string overflow	2024-11-18 11:42:50 +01:00
thunderbolt	thunderbolt: Fix wake configurations after device unplug	2024-11-19 11:32:22 +01:00
tty	serial/pmac_zilog: Remove flawed mitigation for rx irq flood	2024-11-19 11:32:22 +01:00
uh
uio	uio: Fix use-after-free in uio_open	2024-11-18 12:12:19 +01:00
usb	usb: Disable USB3 LPM at shutdown	2024-11-19 11:32:23 +01:00
vdpa
vfio	vfio/fsl-mc: Block calling interrupt handler without trigger	2024-11-19 09:22:45 +01:00
vhost	vhost: Add smp_rmb() in vhost_vq_avail_empty()	2024-11-19 11:32:20 +01:00
vibrator
video	fbmon: prevent division by zero in fb_videomode_from_videomode()	2024-11-19 09:23:15 +01:00
virt
virtio	virtio: reenable config if freezing device failed	2024-11-19 09:23:15 +01:00
vision
vision3
visorbus
vlynq
vme
w1
watchdog	watchdog: stm32_iwdg: initialize default timeout	2024-11-19 08:44:57 +01:00
xen	xen/events: close evtchn after mapping cleanup	2024-11-19 09:22:39 +01:00
zorro
Kconfig	drivers: add stub kperfmon	2024-06-15 16:28:49 -03:00
Kconfig.variant1
Makefile	drivers: add stub kperfmon	2024-06-15 16:28:49 -03:00
Makefile.variant1