kernel_samsung_a53x/fs/ocfs2
Dmitry Antipov 9e626575d1 ocfs2: fix uninitialized value in ocfs2_file_read_iter()
[ Upstream commit adc77b19f62d7e80f98400b2fca9d700d2afdd6f ]

Syzbot has reported the following KMSAN splat:

BUG: KMSAN: uninit-value in ocfs2_file_read_iter+0x9a4/0xf80
 ocfs2_file_read_iter+0x9a4/0xf80
 __io_read+0x8d4/0x20f0
 io_read+0x3e/0xf0
 io_issue_sqe+0x42b/0x22c0
 io_wq_submit_work+0xaf9/0xdc0
 io_worker_handle_work+0xd13/0x2110
 io_wq_worker+0x447/0x1410
 ret_from_fork+0x6f/0x90
 ret_from_fork_asm+0x1a/0x30

Uninit was created at:
 __alloc_pages_noprof+0x9a7/0xe00
 alloc_pages_mpol_noprof+0x299/0x990
 alloc_pages_noprof+0x1bf/0x1e0
 allocate_slab+0x33a/0x1250
 ___slab_alloc+0x12ef/0x35e0
 kmem_cache_alloc_bulk_noprof+0x486/0x1330
 __io_alloc_req_refill+0x84/0x560
 io_submit_sqes+0x172f/0x2f30
 __se_sys_io_uring_enter+0x406/0x41c0
 __x64_sys_io_uring_enter+0x11f/0x1a0
 x64_sys_call+0x2b54/0x3ba0
 do_syscall_64+0xcd/0x1e0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

Since an instance of 'struct kiocb' may be passed from the block layer
with 'private' field uninitialized, introduce 'ocfs2_iocb_init_rw_locked()'
and use it from where 'ocfs2_dio_end_io()' might take care, i.e. in
'ocfs2_file_read_iter()' and 'ocfs2_file_write_iter()'.

Link: https://lkml.kernel.org/r/20241029091736.1501946-1-dmantipov@yandex.ru
Fixes: 7cdfc3a1c397 ("ocfs2: Remember rw lock level during direct io")
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Reported-by: syzbot+a73e253cca4f0230a5a5@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=a73e253cca4f0230a5a5
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Joseph Qi <jiangqi903@gmail.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Jun Piao <piaojun@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-12-17 13:24:09 +01:00
..
cluster Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dlm Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dlmfs Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
acl.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
acl.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
alloc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
alloc.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
aops.c Revert "ocfs2: fix uninit-value in ocfs2_get_block()" 2024-11-24 00:23:03 +01:00
aops.h ocfs2: fix uninitialized value in ocfs2_file_read_iter() 2024-12-17 13:24:09 +01:00
blockcheck.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
blockcheck.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
buffer_head_io.c Revert "ocfs2: remove unreasonable unlock in ocfs2_read_blocks" 2024-11-24 00:23:02 +01:00
buffer_head_io.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dcache.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dcache.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dir.c ocfs2: add bounds checking to ocfs2_check_dir_entry() 2024-11-19 14:19:51 +01:00
dir.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dlmglue.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dlmglue.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
export.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
export.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
extent_map.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
extent_map.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
file.c ocfs2: fix uninitialized value in ocfs2_file_read_iter() 2024-12-17 13:24:09 +01:00
file.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
filecheck.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
filecheck.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
heartbeat.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
heartbeat.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
inode.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
inode.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ioctl.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ioctl.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
journal.c Revert "ocfs2: fix null-ptr-deref when journal load failed." 2024-11-24 00:23:02 +01:00
journal.h ocfs2: fix DIO failure due to insufficient transaction credits 2024-11-19 14:19:33 +01:00
Kconfig Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
localalloc.c Revert "ocfs2: fix the la space leak when unmounting an ocfs2 volume" 2024-11-24 00:23:03 +01:00
localalloc.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
locks.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
locks.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mmap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mmap.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
move_extents.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
move_extents.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
namei.c ocfs2: use coarse time for new created files 2024-11-19 14:19:04 +01:00
namei.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ocfs1_fs_compat.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ocfs2.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ocfs2_fs.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ocfs2_ioctl.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ocfs2_lockid.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ocfs2_lockingver.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ocfs2_trace.h ocfs2: fix DIO failure due to insufficient transaction credits 2024-11-19 14:19:33 +01:00
quota.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
quota_global.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
quota_local.c Revert "ocfs2: cancel dqi_sync_work before freeing oinfo" 2024-11-24 00:23:03 +01:00
refcounttree.c Revert "ocfs2: reserve space for inline xattr before attaching reflink tree" 2024-11-24 00:23:03 +01:00
refcounttree.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
reservations.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
reservations.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
resize.c ocfs2: uncache inode which has failed entering the group 2024-12-17 13:20:50 +01:00
resize.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
slot_map.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
slot_map.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
stack_o2cb.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
stack_user.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
stackglue.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
stackglue.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
suballoc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
suballoc.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
super.c ocfs2: fix UBSAN warning in ocfs2_verify_volume() 2024-12-17 13:20:51 +01:00
super.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
symlink.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
symlink.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sysfile.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sysfile.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
uptodate.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
uptodate.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
xattr.c ocfs2: remove entry once instead of null-ptr-dereference in ocfs2_xa_remove() 2024-11-30 02:33:26 +01:00
xattr.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00