Eric Dumazet ff731d9e93 gtp: pull network headers in gtp_dev_xmit() ... commit 3a3be7ff9224f424e485287b54be00d2c6bd9c40 upstream. syzbot/KMSAN reported use of uninit-value in get_dev_xmit() [1] We must make sure the IPv4 or Ipv6 header is pulled in skb->head before accessing fields in them. Use pskb_inet_may_pull() to fix this issue. [1] BUG: KMSAN: uninit-value in ipv6_pdp_find drivers/net/gtp.c:220 [inline] BUG: KMSAN: uninit-value in gtp_build_skb_ip6 drivers/net/gtp.c:1229 [inline] BUG: KMSAN: uninit-value in gtp_dev_xmit+0x1424/0x2540 drivers/net/gtp.c:1281 ipv6_pdp_find drivers/net/gtp.c:220 [inline] gtp_build_skb_ip6 drivers/net/gtp.c:1229 [inline] gtp_dev_xmit+0x1424/0x2540 drivers/net/gtp.c:1281 __netdev_start_xmit include/linux/netdevice.h:4913 [inline] netdev_start_xmit include/linux/netdevice.h:4922 [inline] xmit_one net/core/dev.c:3580 [inline] dev_hard_start_xmit+0x247/0xa20 net/core/dev.c:3596 __dev_queue_xmit+0x358c/0x5610 net/core/dev.c:4423 dev_queue_xmit include/linux/netdevice.h:3105 [inline] packet_xmit+0x9c/0x6c0 net/packet/af_packet.c:276 packet_snd net/packet/af_packet.c:3145 [inline] packet_sendmsg+0x90e3/0xa3a0 net/packet/af_packet.c:3177 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x30f/0x380 net/socket.c:745 __sys_sendto+0x685/0x830 net/socket.c:2204 __do_sys_sendto net/socket.c:2216 [inline] __se_sys_sendto net/socket.c:2212 [inline] __x64_sys_sendto+0x125/0x1d0 net/socket.c:2212 x64_sys_call+0x3799/0x3c10 arch/x86/include/generated/asm/syscalls_64.h:45 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Uninit was created at: slab_post_alloc_hook mm/slub.c:3994 [inline] slab_alloc_node mm/slub.c:4037 [inline] kmem_cache_alloc_node_noprof+0x6bf/0xb80 mm/slub.c:4080 kmalloc_reserve+0x13d/0x4a0 net/core/skbuff.c:583 __alloc_skb+0x363/0x7b0 net/core/skbuff.c:674 alloc_skb include/linux/skbuff.h:1320 [inline] alloc_skb_with_frags+0xc8/0xbf0 net/core/skbuff.c:6526 sock_alloc_send_pskb+0xa81/0xbf0 net/core/sock.c:2815 packet_alloc_skb net/packet/af_packet.c:2994 [inline] packet_snd net/packet/af_packet.c:3088 [inline] packet_sendmsg+0x749c/0xa3a0 net/packet/af_packet.c:3177 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0x30f/0x380 net/socket.c:745 __sys_sendto+0x685/0x830 net/socket.c:2204 __do_sys_sendto net/socket.c:2216 [inline] __se_sys_sendto net/socket.c:2212 [inline] __x64_sys_sendto+0x125/0x1d0 net/socket.c:2212 x64_sys_call+0x3799/0x3c10 arch/x86/include/generated/asm/syscalls_64.h:45 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f CPU: 0 UID: 0 PID: 7115 Comm: syz.1.515 Not tainted 6.11.0-rc1-syzkaller-00043-g94ede2a3e913 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024 Fixes: 999cb275c807 ("gtp: add IPv6 support") Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Harald Welte <laforge@gnumonks.org> Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org> Link: https://patch.msgid.link/20240808132455.3413916-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-11-23 23:20:47 +01:00
..
appletalk
arcnet
bonding	net: bonding: correctly annotate RCU in bond_should_notify_peers()	2024-11-23 23:20:17 +01:00
caif
can	can: kvaser_usb: fix return value for hif_usb_send_regout	2024-11-19 14:19:48 +01:00
dropdump
dsa	net: dsa: vsc73xx: check busy flag in MDIO operations	2024-11-23 23:20:43 +01:00
ethernet	net: hns3: add checking for vf id of mailbox	2024-11-23 23:20:46 +01:00
fddi
fjes
hamradio
hippi
hyperv	hv_netvsc: Register VF in netvsc_probe if NET_DEVICE_REGISTER missed	2024-11-18 23:19:52 +01:00
ieee802154
ipa
ipvlan	ipvlan: Dont Use skb->sk in ipvlan_process_v{4,6}_outbound	2024-11-19 12:27:11 +01:00
mdio
netdevsim
pcs
phy	net: phy: micrel: add Microchip KSZ 9477 to the device table	2024-11-19 14:19:31 +01:00
plip
ppp	ppp: reject claimed-as-LCP but actually malformed packets	2024-11-19 14:19:43 +01:00
slip
team
usb	net: usb: qmi_wwan: fix memory leak for not ip packets	2024-11-23 23:20:22 +01:00
vmxnet3
vxlan	vxlan: Fix regression when dropping packets due to invalid src addresses	2024-11-19 14:19:00 +01:00
wan
wimax
wireguard	wireguard: send: annotate intentional data race in checking empty queue	2024-11-19 14:19:45 +01:00
wireless	wifi: iwlwifi: abort scan when rfkill on but device enabled	2024-11-23 23:20:45 +01:00
xen-netback
bareudp.c
dummy.c
eql.c
geneve.c	geneve: fix header validation in geneve[6]_xmit_skb	2024-11-19 11:32:19 +01:00
gtp.c	gtp: pull network headers in gtp_dev_xmit()	2024-11-23 23:20:47 +01:00
ifb.c
Kconfig
LICENSE.SRC
loopback.c
macsec.c
macvlan.c
macvtap.c
Makefile
mdio.c
mii.c
net_failover.c
netconsole.c	net: netconsole: Disable target before netpoll cleanup	2024-11-23 23:20:12 +01:00
nlmon.c
ntb_netdev.c
rionet.c
sb1000.c
Space.c
sungem_phy.c
tap.c	tap: add missing verification for short frame	2024-11-19 14:19:53 +01:00
thunderbolt.c
tun.c	tun: add missing verification for short frame	2024-11-19 14:19:53 +01:00
veth.c
virtio_net.c	virtio_net: checksum offloading handling fix	2024-11-19 14:19:08 +01:00
vrf.c
vsockmon.c
xen-netfront.c