45db38edfb
commit 2f3389c73832ad90b63208c0fc281ad080114c7a upstream. Driver allocates the LL2 rx buffers from kmalloc() area to construct the skb using slab_build_skb() The required size allocation seems to have overlooked for accounting both skb_shared_info size and device placement padding bytes which results into the below panic when doing skb_put() for a standard MTU sized frame. skbuff: skb_over_panic: text:ffffffffc0b0225f len:1514 put:1514 head:ff3dabceaf39c000 data:ff3dabceaf39c042 tail:0x62c end:0x566 dev:<NULL> … skb_panic+0x48/0x4a skb_put.cold+0x10/0x10 qed_ll2b_complete_rx_packet+0x14f/0x260 [qed] qed_ll2_rxq_handle_completion.constprop.0+0x169/0x200 [qed] qed_ll2_rxq_completion+0xba/0x320 [qed] qed_int_sp_dpc+0x1a7/0x1e0 [qed] This patch fixes this by accouting skb_shared_info and device placement padding size bytes when allocating the buffers. Cc: David S. Miller <davem@davemloft.net> Fixes: 0a7fb11c23c0 ("qed: Add Light L2 support") Signed-off-by: Manish Chopra <manishc@marvell.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
---|---|---|
.. | ||
Makefile | ||
qed.h | ||
qed_chain.c | ||
qed_cxt.c | ||
qed_cxt.h | ||
qed_dcbx.c | ||
qed_dcbx.h | ||
qed_debug.c | ||
qed_debug.h | ||
qed_dev.c | ||
qed_dev_api.h | ||
qed_devlink.c | ||
qed_devlink.h | ||
qed_fcoe.c | ||
qed_fcoe.h | ||
qed_hsi.h | ||
qed_hw.c | ||
qed_hw.h | ||
qed_init_fw_funcs.c | ||
qed_init_ops.c | ||
qed_init_ops.h | ||
qed_int.c | ||
qed_int.h | ||
qed_iscsi.c | ||
qed_iscsi.h | ||
qed_iwarp.c | ||
qed_iwarp.h | ||
qed_l2.c | ||
qed_l2.h | ||
qed_ll2.c | ||
qed_ll2.h | ||
qed_main.c | ||
qed_mcp.c | ||
qed_mcp.h | ||
qed_mng_tlv.c | ||
qed_ooo.c | ||
qed_ooo.h | ||
qed_ptp.c | ||
qed_ptp.h | ||
qed_rdma.c | ||
qed_rdma.h | ||
qed_reg_addr.h | ||
qed_roce.c | ||
qed_roce.h | ||
qed_selftest.c | ||
qed_selftest.h | ||
qed_sp.h | ||
qed_sp_commands.c | ||
qed_spq.c | ||
qed_sriov.c | ||
qed_sriov.h | ||
qed_vf.c | ||
qed_vf.h |