Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kernel_samsung_a53x/drivers/net/wireguard
History
Jason A. Donenfeld 6d5a3d273d wireguard: queueing: annotate intentional data race in cpu round robin 
commit 2fe3d6d2053c57f2eae5e85ca1656d185ebbe4e8 upstream.

KCSAN reports a race in the CPU round robin function, which, as the
comment points out, is intentional:

    BUG: KCSAN: data-race in wg_packet_send_staged_packets / wg_packet_send_staged_packets

    read to 0xffff88811254eb28 of 4 bytes by task 3160 on cpu 1:
     wg_cpumask_next_online drivers/net/wireguard/queueing.h:127 [inline]
     wg_queue_enqueue_per_device_and_peer drivers/net/wireguard/queueing.h:173 [inline]
     wg_packet_create_data drivers/net/wireguard/send.c:320 [inline]
     wg_packet_send_staged_packets+0x60e/0xac0 drivers/net/wireguard/send.c:388
     wg_packet_send_keepalive+0xe2/0x100 drivers/net/wireguard/send.c:239
     wg_receive_handshake_packet drivers/net/wireguard/receive.c:186 [inline]
     wg_packet_handshake_receive_worker+0x449/0x5f0 drivers/net/wireguard/receive.c:213
     process_one_work kernel/workqueue.c:3248 [inline]
     process_scheduled_works+0x483/0x9a0 kernel/workqueue.c:3329
     worker_thread+0x526/0x720 kernel/workqueue.c:3409
     kthread+0x1d1/0x210 kernel/kthread.c:389
     ret_from_fork+0x4b/0x60 arch/x86/kernel/process.c:147
     ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

    write to 0xffff88811254eb28 of 4 bytes by task 3158 on cpu 0:
     wg_cpumask_next_online drivers/net/wireguard/queueing.h:130 [inline]
     wg_queue_enqueue_per_device_and_peer drivers/net/wireguard/queueing.h:173 [inline]
     wg_packet_create_data drivers/net/wireguard/send.c:320 [inline]
     wg_packet_send_staged_packets+0x6e5/0xac0 drivers/net/wireguard/send.c:388
     wg_packet_send_keepalive+0xe2/0x100 drivers/net/wireguard/send.c:239
     wg_receive_handshake_packet drivers/net/wireguard/receive.c:186 [inline]
     wg_packet_handshake_receive_worker+0x449/0x5f0 drivers/net/wireguard/receive.c:213
     process_one_work kernel/workqueue.c:3248 [inline]
     process_scheduled_works+0x483/0x9a0 kernel/workqueue.c:3329
     worker_thread+0x526/0x720 kernel/workqueue.c:3409
     kthread+0x1d1/0x210 kernel/kthread.c:389
     ret_from_fork+0x4b/0x60 arch/x86/kernel/process.c:147
     ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

    value changed: 0xffffffff -> 0x00000000

Mark this race as intentional by using READ/WRITE_ONCE().

Cc: stable@vger.kernel.org
Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Link: https://patch.msgid.link/20240704154517.1572127-4-Jason@zx2c4.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-19 14:19:45 +01:00
..
selftest Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
allowedips.c wireguard: allowedips: avoid unaligned 64-bit memory accesses 2024-11-19 14:19:45 +01:00
allowedips.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cookie.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cookie.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
device.c Revert "wireguard: use DEV_STATS_INC()" 2024-11-18 20:09:56 +01:00
device.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
main.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
messages.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
netlink.c wireguard: netlink: access device through ctx instead of peer 2024-11-19 09:22:37 +01:00
netlink.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
noise.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
noise.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
peer.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
peer.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
peerlookup.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
peerlookup.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
queueing.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
queueing.h wireguard: queueing: annotate intentional data race in cpu round robin 2024-11-19 14:19:45 +01:00
ratelimiter.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ratelimiter.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
receive.c wireguard: receive: annotate data-race around receiving_counter.counter 2024-11-19 08:44:59 +01:00
send.c Revert "wireguard: use DEV_STATS_INC()" 2024-11-18 20:09:56 +01:00
socket.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
socket.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
timers.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
timers.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
version.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00