Chengfeng Ye 9bf65b3f0d IB/hfi1: Fix potential deadlock on &irq_src_lock and &dd->uctxt_lock ... [ Upstream commit 2f19c4b8395ccb6eb25ccafee883c8cfbe3fc193 ] handle_receive_interrupt_napi_sp() running inside interrupt handler could introduce inverse lock ordering between &dd->irq_src_lock and &dd->uctxt_lock, if read_mod_write() is preempted by the isr. [CPU0] | [CPU1] hfi1_ipoib_dev_open() | --> hfi1_netdev_enable_queues() | --> enable_queues(rx) | --> hfi1_rcvctrl() | --> set_intr_bits() | --> read_mod_write() | --> spin_lock(&dd->irq_src_lock) | | hfi1_poll() | --> poll_next() | --> spin_lock_irq(&dd->uctxt_lock) | | --> hfi1_rcvctrl() | --> set_intr_bits() | --> read_mod_write() | --> spin_lock(&dd->irq_src_lock) <interrupt> | --> handle_receive_interrupt_napi_sp() | --> set_all_fastpath() | --> hfi1_rcd_get_by_index() | --> spin_lock_irqsave(&dd->uctxt_lock) | This flaw was found by an experimental static analysis tool I am developing for irq-related deadlock. To prevent the potential deadlock, the patch use spin_lock_irqsave() on &dd->irq_src_lock inside read_mod_write() to prevent the possible deadlock scenario. Signed-off-by: Chengfeng Ye <dg573847474@gmail.com> Link: https://lore.kernel.org/r/20230926101116.2797-1-dg573847474@gmail.com Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com> Signed-off-by: Leon Romanovsky <leon@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-11-23 23:20:45 +01:00
..
affinity.c
affinity.h
aspm.c
aspm.h
chip.c
chip.h
chip_registers.h
common.h
debugfs.c
debugfs.h
device.c
device.h
driver.c
efivar.c
efivar.h
eprom.c
eprom.h
exp_rcv.c
exp_rcv.h
fault.c
fault.h
file_ops.c
firmware.c
hfi.h
init.c
intr.c
iowait.c
iowait.h
ipoib.h
ipoib_main.c
ipoib_rx.c
ipoib_tx.c
Kconfig
mad.c
mad.h
Makefile
mmu_rb.c
mmu_rb.h
msix.c
msix.h
netdev.h
netdev_rx.c
opa_compat.h
opfn.c
opfn.h
pcie.c
pio.c
pio.h
pio_copy.c
platform.c
platform.h
qp.c
qp.h
qsfp.c
qsfp.h
rc.c
rc.h
ruc.c
sdma.c
sdma.h
sdma_txreq.h
sysfs.c
tid_rdma.c
tid_rdma.h
trace.c
trace.h
trace_ctxts.h
trace_dbg.h
trace_ibhdrs.h
trace_iowait.h
trace_misc.h
trace_mmu.h
trace_rc.h
trace_rx.h
trace_tid.h
trace_tx.h
uc.c
ud.c
user_exp_rcv.c
user_exp_rcv.h
user_pages.c
user_sdma.c
user_sdma.h
verbs.c
verbs.h
verbs_txreq.c
verbs_txreq.h
vnic.h
vnic_main.c
vnic_sdma.c