Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kernel_samsung_a53x/fs/f2fs
History
Chao Yu d001544c40 f2fs: fix to do sanity check on i_xattr_nid in sanity_check_inode() 
commit 20faaf30e55522bba2b56d9c46689233205d7717 upstream.

syzbot reports a kernel bug as below:

F2FS-fs (loop0): Mounted with checkpoint version = 48b305e4
==================================================================
BUG: KASAN: slab-out-of-bounds in f2fs_test_bit fs/f2fs/f2fs.h:2933 [inline]
BUG: KASAN: slab-out-of-bounds in current_nat_addr fs/f2fs/node.h:213 [inline]
BUG: KASAN: slab-out-of-bounds in f2fs_get_node_info+0xece/0x1200 fs/f2fs/node.c:600
Read of size 1 at addr ffff88807a58c76c by task syz-executor280/5076

CPU: 1 PID: 5076 Comm: syz-executor280 Not tainted 6.9.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
 print_address_description mm/kasan/report.c:377 [inline]
 print_report+0x169/0x550 mm/kasan/report.c:488
 kasan_report+0x143/0x180 mm/kasan/report.c:601
 f2fs_test_bit fs/f2fs/f2fs.h:2933 [inline]
 current_nat_addr fs/f2fs/node.h:213 [inline]
 f2fs_get_node_info+0xece/0x1200 fs/f2fs/node.c:600
 f2fs_xattr_fiemap fs/f2fs/data.c:1848 [inline]
 f2fs_fiemap+0x55d/0x1ee0 fs/f2fs/data.c:1925
 ioctl_fiemap fs/ioctl.c:220 [inline]
 do_vfs_ioctl+0x1c07/0x2e50 fs/ioctl.c:838
 __do_sys_ioctl fs/ioctl.c:902 [inline]
 __se_sys_ioctl+0x81/0x170 fs/ioctl.c:890
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

The root cause is we missed to do sanity check on i_xattr_nid during
f2fs_iget(), so that in fiemap() path, current_nat_addr() will access
nat_bitmap w/ offset from invalid i_xattr_nid, result in triggering
kasan bug report, fix it.

Reported-and-tested-by: syzbot+3694e283cf5c40df6d14@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/linux-f2fs-devel/00000000000094036c0616e72a1d@google.com
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-19 12:27:13 +01:00
..
acl.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
acl.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
checkpoint.c f2fs: use copy_page for full page copy 2024-11-17 17:41:42 +01:00
compress.c f2fs: compress: remove unneeded preallocation 2024-11-19 12:27:02 +01:00
data.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
debug.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dir.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
extent_cache.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
f2fs.h f2fs: use copy_page for full page copy 2024-11-17 17:41:42 +01:00
file.c f2fs: compress: don't allow unaligned truncation on released compress inode 2024-11-19 12:27:05 +01:00
gc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
gc.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hash.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
inline.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
inode.c f2fs: fix to do sanity check on i_xattr_nid in sanity_check_inode() 2024-11-19 12:27:13 +01:00
Kconfig f2fs: Add support for reporting a fake kernel version to fsck 2024-11-17 17:43:26 +01:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
namei.c f2fs: fix to avoid dirent corruption 2024-11-18 12:12:39 +01:00
node.c f2fs: fix to release node block count in error path of f2fs_new_node_page() 2024-11-19 12:27:05 +01:00
node.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
recovery.c f2fs: fix write pointers on zoned device after roll forward 2024-11-18 12:13:17 +01:00
segment.c f2fs: use copy_page for full page copy 2024-11-17 17:41:42 +01:00
segment.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
shrinker.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
super.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sysfs.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
verity.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
xattr.c f2fs: explicitly null-terminate the xattr list 2024-11-18 12:12:11 +01:00
xattr.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00