1607c0cb18
[ Upstream commit 4649cbd97fdae5069e9a71cd7669b62b90e03669 ]
Some fix and updates in the following items:
1. examples:
Update generic node name to 'audio-codec' to comply with the
coming change in 'mt6359.dtsi'. This change is necessary to fix the
dtbs_check error:
pmic: 'mt6359codec' does not match any of the regexes: 'pinctrl-[0-9]+'
2. mediatek,dmic-mode:
After inspecting the .dts and .dtsi files using 'mt6359-codec', it was
discovered that the definitions of 'two wires' and 'one wire' are
inverted compared to the DT schema.
For example, the following boards using MT6359 PMIC:
- mt8192-asurada.dtsi
- mt8195-cherry.dtsi
These boards use the same definitions of 'dmic-mode' as other boards
using MT6358 PMIC. The meaning of '0' or '1' has been noted as comments
in the device trees.
Upon examining the code in [1] and [2], it was confirmed that the
definitions of 'dmic-mode' are consistent between "MT6359 PMIC" and
"MT6358 PMIC". Therefore, the DT Schema should be correct as is.
References:
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/soc/codecs/mt6358.c#n1875
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/soc/codecs/mt6359.c#L1515
Fixes: 539237d1c609 ("dt-bindings: mediatek: mt6359: add codec document")
Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patch.msgid.link/20240930075451.14196-1-macpaul.lin@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
61 lines
1.8 KiB
YAML
Executable file
61 lines
1.8 KiB
YAML
Executable file
# SPDX-License-Identifier: GPL-2.0
|
|
%YAML 1.2
|
|
---
|
|
$id: http://devicetree.org/schemas/sound/mt6359.yaml#
|
|
$schema: http://devicetree.org/meta-schemas/core.yaml#
|
|
|
|
title: Mediatek MT6359 Codec Device Tree Bindings
|
|
|
|
maintainers:
|
|
- Eason Yen <eason.yen@mediatek.com>
|
|
- Jiaxin Yu <jiaxin.yu@mediatek.com>
|
|
- Shane Chien <shane.chien@mediatek.com>
|
|
|
|
description: |
|
|
The communication between MT6359 and SoC is through Mediatek PMIC wrapper.
|
|
For more detail, please visit Mediatek PMIC wrapper documentation.
|
|
Must be a child node of PMIC wrapper.
|
|
|
|
properties:
|
|
mediatek,dmic-mode:
|
|
$ref: /schemas/types.yaml#/definitions/uint32
|
|
description: |
|
|
Indicates how many data pins are used to transmit two channels of PDM
|
|
signal. 0 means two wires, 1 means one wire. Default value is 0.
|
|
enum:
|
|
- 0 # two wires
|
|
- 1 # one wire
|
|
|
|
mediatek,mic-type-0:
|
|
$ref: /schemas/types.yaml#/definitions/uint32
|
|
description: |
|
|
Specifies the type of mic type connected to adc0
|
|
|
|
enum:
|
|
- 0 # IDLE - mic in turn-off status
|
|
- 1 # ACC - analog mic with alternating coupling
|
|
- 2 # DMIC - digital mic
|
|
- 3 # DCC - analog mic with direct couping
|
|
- 4 # DCC_ECM_DIFF - analog electret condenser mic with differential mode
|
|
- 5 # DCC_ECM_SINGLE - analog electret condenser mic with single mode
|
|
|
|
mediatek,mic-type-1:
|
|
$ref: /schemas/types.yaml#/definitions/uint32
|
|
description: |
|
|
Specifies the type of mic type connected to adc1
|
|
|
|
mediatek,mic-type-2:
|
|
$ref: /schemas/types.yaml#/definitions/uint32
|
|
description: |
|
|
Specifies the type of mic type connected to adc2
|
|
|
|
additionalProperties: false
|
|
|
|
examples:
|
|
- |
|
|
mt6359codec: audio-codec {
|
|
mediatek,dmic-mode = <0>;
|
|
mediatek,mic-type-0 = <2>;
|
|
};
|
|
|
|
...
|