Qiu-ji Chen 241cc5ec8a xen: Fix the issue of resource not being properly released in xenbus_dev_probe() ... commit afc545da381ba0c651b2658966ac737032676f01 upstream. This patch fixes an issue in the function xenbus_dev_probe(). In the xenbus_dev_probe() function, within the if (err) branch at line 313, the program incorrectly returns err directly without releasing the resources allocated by err = drv->probe(dev, id). As the return value is non-zero, the upper layers assume the processing logic has failed. However, the probe operation was performed earlier without a corresponding remove operation. Since the probe actually allocates resources, failing to perform the remove operation could lead to problems. To fix this issue, we followed the resource release logic of the xenbus_dev_remove() function by adding a new block fail_remove before the fail_put block. After entering the branch if (err) at line 313, the function will use a goto statement to jump to the fail_remove block, ensuring that the previously acquired resources are correctly released, thus preventing the reference count leak. This bug was identified by an experimental static analysis tool developed by our team. The tool specializes in analyzing reference count operations and detecting potential issues where resources are not properly managed. In this case, the tool flagged the missing release operation as a potential problem, which led to the development of this patch. Fixes: 4bac07c993d0 ("xen: add the Xenbus sysfs and virtual device hotplug driver") Cc: stable@vger.kernel.org Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com> Reviewed-by: Juergen Gross <jgross@suse.com> Message-ID: <20241105130919.4621-1-chenqiuji666@gmail.com> Signed-off-by: Juergen Gross <jgross@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-12-17 13:24:17 +01:00
..
accessibility	speakup: Fix sizeof() vs ARRAY_SIZE() bug	2024-11-19 12:26:51 +01:00
acpi	acpi/arm64: Adjust error handling procedure in gtdt_parse_timer_block()	2024-12-17 13:23:59 +01:00
amba
android	Revert "binder: fix UAF caused by offsets overwrite"	2024-11-24 00:23:38 +01:00
ata	Revert "ata: libata-core: Fix null pointer dereference on error"	2024-11-24 00:23:50 +01:00
atm	atm: idt77252: prevent use after free in dequeue_rx()	2024-11-23 23:20:43 +01:00
auxdisplay
base	driver core: Introduce device_find_any_child() helper	2024-12-17 13:24:07 +01:00
battery
bcma
block	Revert "zram: Set default compressor to zstd"	2024-12-03 19:58:37 +01:00
bluetooth	Revert "Bluetooth: hci_ldisc: check HCI_UART_PROTO_READY flag in HCIUARTGETPROTO"	2024-11-24 00:23:50 +01:00
bts
bus	Revert "bus: integrator-lm: fix OF node leak in probe()"	2024-11-24 00:23:16 +01:00
cdrom
char	Revert "tpm: Clean up TPM space after command failure"	2024-11-24 00:23:24 +01:00
clk	clk: clk-axi-clkgen: make sure to enable the AXI bus clock	2024-12-17 13:24:10 +01:00
clocksource	clocksource/drivers:sp804: Make user selectable	2024-12-17 13:24:00 +01:00
connector
counter	counter: ti-eqep: enable clock at probe	2024-11-19 14:19:33 +01:00
cpufreq	cpufreq: loongson2: Unregister platform_driver on failure	2024-12-17 13:24:08 +01:00
cpuidle	cpuidle: menu: Take negative "sleep length" values into account	2024-11-19 18:01:28 +01:00
crypto	crypto: cavium - Fix an error handling path in cpt_ucode_load_fw()	2024-12-17 13:24:00 +01:00
dax
dca
devfreq	PM / devfreq: Fix buffer overflow in trans_stat_show	2024-11-19 11:32:38 +01:00
dio
dma	dmaengine: dw: Add memory bus width verification	2024-11-23 23:20:55 +01:00
dma-buf	dma-buf/sync_file: Speed up ioctl by omitting debug names	2024-11-19 17:53:23 +01:00
edac	EDAC/fsl_ddr: Fix bad bit shift operations	2024-12-17 13:23:59 +01:00
eisa
extcon	extcon: max8997: select IRQ_DOMAIN instead of depending on it	2024-11-19 12:27:04 +01:00
fingerprint
firewire	firewire: nosy: ensure user_length is taken into account when fetching packet contents	2024-11-19 11:32:46 +01:00
firmware	firmware: arm_scpi: Check the DVFS OPP count returned by the firmware	2024-12-17 13:24:03 +01:00
fpga	fpga: region: add owner module and take its refcount	2024-11-19 12:27:04 +01:00
fsi
gnss
gpio	Revert "gpio: prevent potential speculation leaks in gpio_device_get_desc()"	2024-11-24 00:23:32 +01:00
gpu	drm/amdkfd: Fix wrong usage of INIT_WORK()	2024-12-17 13:24:07 +01:00
greybus	greybus: Fix use-after-free bug in gb_interface_release due to race condition.	2024-11-19 14:19:05 +01:00
gud
hid	HID: multitouch: Add quirk for HONOR MagicBook Art 14 touchpad	2024-11-30 02:33:27 +01:00
hsi
hv	Revert "Drivers: hv: vmbus: Fix rescind handling in uio_hv_generic"	2024-11-24 00:23:37 +01:00
hwmon	Revert "hwmon: (adc128d818) Fix underflows seen when writing limit attributes"	2024-11-24 00:23:40 +01:00
hwspinlock	Revert "hwspinlock: Introduce hwspin_lock_bust()"	2024-11-24 00:23:48 +01:00
hwtracing	Revert "coresight: tmc: sg: Do not leak sg_table"	2024-11-24 00:23:19 +01:00
i2c	Revert "i2c: Add i2c_get_match_data()"	2024-11-24 00:23:27 +01:00
i3c
ide
idle
ifconn
iio	iio: light: al3010: Fix an error handling path in al3010_probe()	2024-12-17 13:24:16 +01:00
infiniband	RDMA/hns: Fix NULL pointer derefernce in hns_roce_map_mr_sg()	2024-12-17 13:24:09 +01:00
input	Revert "Input: uinput - reject requests with unreasonable number of slots"	2024-11-24 00:23:39 +01:00
interconnect	Revert "interconnect: qcom: sm8250: Enable sync_state"	2024-11-24 00:23:19 +01:00
iommu	Revert "iommu: sun50i: clear bypass register"	2024-11-24 00:23:43 +01:00
ipack
irqchip	irqchip/gic-v3: Force propagation of the active state with a read-back	2024-11-30 02:33:26 +01:00
isdn	mISDN: Fix a use after free in hfcmulti_tx()	2024-11-23 23:20:17 +01:00
kperfmon
kq/mesh
leds	leds: lp55xx: Remove redundant test for invalid channel number	2024-12-17 13:20:50 +01:00
lightnvm
macintosh	macintosh/therm_windtunnel: fix module unload.	2024-11-23 23:20:11 +01:00
mailbox	Revert "mailbox: rockchip: fix a typo in module autoloading"	2024-11-24 00:23:13 +01:00
mcb
md	md/raid10: improve code of mrdev in raid10_sync_request	2024-11-30 02:33:28 +01:00
media	media: dvbdev: fix the logic when DVB_DYNAMIC_MINORS is not set	2024-12-17 13:20:51 +01:00
memory	memory: stm32-fmc2-ebi: check regmap_read return value	2024-11-23 23:20:46 +01:00
memstick
message	scsi: fusion: Remove unused variable 'rc'	2024-12-17 13:24:09 +01:00
mfd	mfd: rt5033: Fix missing regmap_del_irq_chip()	2024-12-17 13:24:08 +01:00
misc	misc: apds990x: Fix missing pm_runtime_disable()	2024-12-17 13:24:16 +01:00
mmc	mmc: mmc_spi: drop buggy snprintf()	2024-12-17 13:24:00 +01:00
most
mtd	mtd: rawnand: atmel: Fix possible memory leak	2024-12-17 13:24:08 +01:00
muic
mux
net	bnxt_en: Reserve rings after PCIe AER recovery if NIC interface is down	2024-12-17 13:24:16 +01:00
nfc	nfc: pn533: Add poll mod list filling check	2024-11-23 23:20:55 +01:00
ntb	Revert "ntb: intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir()"	2024-11-24 00:23:20 +01:00
nubus
nvdimm	Revert "virtio_pmem: Check device status before requesting flush"	2024-11-24 00:22:58 +01:00
nvme	nvme-pci: fix freeing of the HMB descriptor table	2024-12-17 13:23:59 +01:00
nvmem	Revert "nvmem: Fix return type of devm_nvmem_device_get() in kerneldoc"	2024-11-24 00:23:38 +01:00
of	Revert "of/irq: Prevent device address out-of-bounds read in interrupt map walk"	2024-11-24 00:23:38 +01:00
opp	OPP: debugfs: Fix warning around icc_get_name()	2024-11-19 08:44:49 +01:00
oprofile
parisc
parport	Revert "parport: Proper fix for array out-of-bounds access"	2024-11-24 00:22:51 +01:00
pci	PCI: cpqphp: Fix PCIBIOS_* return value confusion	2024-12-17 13:24:11 +01:00
pcmcia	Revert "pcmcia: Use resource_size function on resource object"	2024-11-24 00:23:42 +01:00
perf
phy	phy: tegra: xusb: Add API to retrieve the port number of phy	2024-11-19 09:22:34 +01:00
pinctrl	Revert "pinctrl: rockchip: correct RK3328 iomux width flag for GPIO2-B pins"	2024-11-24 00:23:50 +01:00
platform	mfd: intel_soc_pmic_bxtwc: Use IRQ domain for TMU device	2024-12-17 13:24:08 +01:00
pnp
power	power: supply: bq27xxx: Fix registers of bq27426	2024-12-17 13:24:13 +01:00
powercap	Revert "powercap: RAPL: fix invalid initialization for pl4_supported field"	2024-11-24 00:23:18 +01:00
pps	Revert "pps: remove usage of the deprecated ida_simple_xx() API"	2024-11-24 00:23:14 +01:00
ps3
ptp	ptp: Fix error message on failed pin verification	2024-11-19 14:19:01 +01:00
pwm	pwm: imx27: Workaround of the pwm output bug when decrease the duty cycle	2024-12-17 13:24:02 +01:00
rapidio
ras
regulator	regulator: rk808: Add apply_bit for BUCK3 on RK809	2024-12-17 13:23:58 +01:00
remoteproc	remoteproc: qcom_q6v5_mss: Re-order writes to the IMEM region	2024-12-17 13:24:13 +01:00
reset	Revert "reset: berlin: fix OF node leak in probe() error path"	2024-11-24 00:23:27 +01:00
rpmsg	rpmsg: glink: use only lower 16-bits of param2 for CMD_OPEN name length	2024-12-17 13:24:13 +01:00
rtc	Revert "rtc: at91sam9: fix OF node leak in probe() error path"	2024-11-24 00:23:01 +01:00
s390	Revert "s390/zcore: no need to check return value of debugfs_create functions"	2024-11-24 00:22:59 +01:00
samsung
sbus
scsi	scsi: qedi: Fix a possible memory leak in qedi_alloc_and_init_sb()	2024-12-17 13:24:09 +01:00
sensorhub
sensors
sfi
sh
siox
slimbus	slimbus: core: Remove usage of the deprecated ida_simple_xx() API	2024-11-19 09:22:34 +01:00
soc	pmdomain: ti-sci: Add missing of_node_put() for args.np	2024-12-17 13:24:03 +01:00
soundwire	Revert "soundwire: stream: fix programming slave ports for non-continous port maps"	2024-11-24 00:23:49 +01:00
spi	spi: atmel-quadspi: Fix register name in verbose logging function	2024-12-17 13:24:15 +01:00
spmi
spu_verify
ssb	ssb: Fix division by zero issue in ssb_calc_clock_rate	2024-11-23 23:20:44 +01:00
staging	staging: greybus: uart: clean up TIOCGSERIAL	2024-12-17 13:24:16 +01:00
sti
target	scsi: target: core: Fix null-ptr-deref in target_alloc_device()	2024-11-23 23:21:59 +01:00
tc
tee	tee: optee: Fix kernel panic caused by incorrect error handling	2024-11-19 09:22:39 +01:00
thermal
thunderbolt	thunderbolt: Mark XDomain as unplugged when router is removed	2024-11-23 23:20:42 +01:00
tty	Revert "tty: rp2: Fix reset with non forgiving PCIe host bridges"	2024-11-24 00:23:16 +01:00
uh
uio	Revert "uio_hv_generic: Fix kernel NULL pointer dereference in hv_uio_rescind"	2024-11-24 00:23:37 +01:00
usb	USB: chaoskey: Fix possible deadlock chaoskey_list_lock	2024-12-17 13:24:16 +01:00
vdpa	vdpa/mlx5: Fix suboptimal range on iotlb iteration	2024-12-17 13:24:13 +01:00
vfio	vfio/pci: Properly hide first-in-list PCIe extended capability	2024-12-17 13:24:13 +01:00
vhost	Revert "vdpa: Add eventfd for the vdpa callback"	2024-11-24 00:23:19 +01:00
vibrator
video	fbdev: sh7760fb: Fix a possible memory leak in sh7760fb_alloc_mem()	2024-12-17 13:24:09 +01:00
virt
virtio	Revert "vdpa: Add eventfd for the vdpa callback"	2024-11-24 00:23:19 +01:00
vision
vision3
visorbus
vlynq
vme
w1
watchdog	Revert "watchdog: s3c2410_wdt: Assign s3c_wdt[] until probe complete"	2024-12-03 19:58:09 +01:00
xen	xen: Fix the issue of resource not being properly released in xenbus_dev_probe()	2024-12-17 13:24:17 +01:00
zorro
Kconfig	Added KernelSU	2024-11-19 22:44:48 +01:00
Kconfig.variant1
kernelsu	Added KernelSU	2024-11-19 22:44:48 +01:00
Makefile	Added KernelSU	2024-11-19 22:44:48 +01:00
Makefile.variant1