Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kernel_samsung_a53x/drivers/md/bcache
History
Markus Weippert c0fa0b9ee7 bcache: revert replacing IS_ERR_OR_NULL with IS_ERR 
commit bb6cc253861bd5a7cf8439e2118659696df9619f upstream.

Commit 028ddcac477b ("bcache: Remove unnecessary NULL point check in
node allocations") replaced IS_ERR_OR_NULL by IS_ERR. This leads to a
NULL pointer dereference.

BUG: kernel NULL pointer dereference, address: 0000000000000080
Call Trace:
 ? __die_body.cold+0x1a/0x1f
 ? page_fault_oops+0xd2/0x2b0
 ? exc_page_fault+0x70/0x170
 ? asm_exc_page_fault+0x22/0x30
 ? btree_node_free+0xf/0x160 [bcache]
 ? up_write+0x32/0x60
 btree_gc_coalesce+0x2aa/0x890 [bcache]
 ? bch_extent_bad+0x70/0x170 [bcache]
 btree_gc_recurse+0x130/0x390 [bcache]
 ? btree_gc_mark_node+0x72/0x230 [bcache]
 bch_btree_gc+0x5da/0x600 [bcache]
 ? cpuusage_read+0x10/0x10
 ? bch_btree_gc+0x600/0x600 [bcache]
 bch_gc_thread+0x135/0x180 [bcache]

The relevant code starts with:

    new_nodes[0] = NULL;

    for (i = 0; i < nodes; i++) {
        if (__bch_keylist_realloc(&keylist, bkey_u64s(&r[i].b->key)))
            goto out_nocoalesce;
    // ...
out_nocoalesce:
    // ...
    for (i = 0; i < nodes; i++)
        if (!IS_ERR(new_nodes[i])) {  // IS_ERR_OR_NULL before
028ddcac477b
            btree_node_free(new_nodes[i]);  // new_nodes[0] is NULL
            rw_unlock(true, new_nodes[i]);
        }

This patch replaces IS_ERR() by IS_ERR_OR_NULL() to fix this.

Fixes: 028ddcac477b ("bcache: Remove unnecessary NULL point check in node allocations")
Link: https://lore.kernel.org/all/3DF4A87A-2AC1-4893-AE5F-E921478419A9@suse.de/
Cc: stable@vger.kernel.org
Cc: Zheng Wang <zyytlz.wz@163.com>
Cc: Coly Li <colyli@suse.de>
Signed-off-by: Markus Weippert <markus@gekmihesg.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-18 12:11:09 +01:00
..
alloc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
bcache.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
bset.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
bset.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
btree.c bcache: revert replacing IS_ERR_OR_NULL with IS_ERR 2024-11-18 12:11:09 +01:00
btree.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
closure.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
closure.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
debug.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
debug.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
extents.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
extents.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
features.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
features.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
io.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
journal.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
journal.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Kconfig Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
movinggc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
request.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
request.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
stats.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
stats.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
super.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sysfs.c bcache: prevent potential division by zero error 2024-11-18 12:10:57 +01:00
sysfs.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
trace.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
util.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
util.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
writeback.c bcache: fixup lock c->root error 2024-11-18 12:10:57 +01:00
writeback.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00