Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kernel_samsung_a53x/mm
History
Minchan Kim 33372300d9 FROMLIST: BACKPORT: mm: fix is_pinnable_page against on cma page 
Pages on CMA area could have MIGRATE_ISOLATE as well as MIGRATE_CMA
so current is_pinnable_page could miss CMA pages which has MIGRATE_
ISOLATE. It ends up pinning CMA pages as longterm at pin_user_pages
APIs so CMA allocation keep failed until the pin is released.

     CPU 0                                   CPU 1 - Task B

cma_alloc
alloc_contig_range
                                        pin_user_pages_fast(FOLL_LONGTERM)
change pageblock as MIGRATE_ISOLATE
                                        internal_get_user_pages_fast
                                        lockless_pages_from_mm
                                        gup_pte_range
                                        try_grab_folio
                                        is_pinnable_page
                                          return true;
                                        So, pinned the page successfully.
page migration failure with pinned page
                                        ..
                                        .. After 30 sec
                                        unpin_user_page(page)

CMA allocation succeeded after 30 sec.

The CMA allocation path protects the migration type change race
using zone->lock but what GUP path need to know is just whether the
page is on CMA area or not rather than exact migration type.
Thus, we don't need zone->lock but just checks migration type in
either of (MIGRATE_ISOLATE and MIGRATE_CMA).

Adding the MIGRATE_ISOLATE check in is_pinnable_page could cause
rejecting of pinning pages on MIGRATE_ISOLATE pageblocks even
though it's neither CMA nor movable zone if the page is temporarily
unmovable. However, such a migration failure by unexpected temporal
refcount holding is general issue, not only come from MIGRATE_ISOLATE
and the MIGRATE_ISOLATE is also transient state like other temporal
elevated refcount problem.

Cc: "Paul E . McKenney" <paulmck@kernel.org>
Cc: David Hildenbrand <david@redhat.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Minchan Kim <minchan@kernel.org>

Conflicts:
        include/linux/mm.h

1. There is no is_pinnable_page in 5.10

Link: https://lore.kernel.org/all/20220524171525.976723-1-minchan@kernel.org/
Bug: 231227007
Signed-off-by: Minchan Kim <minchan@google.com>
Change-Id: I5cdd2b8eefdd7e89658abd21c32aa84876ad7782
Signed-off-by: Tashfin Shakeer Rhythm <tashfinshakeerrhythm@gmail.com>
2025-01-19 17:14:08 +01:00
..
damon Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
kasan Revert "kasan: print the original fault addr when access invalid shadow" 2024-11-18 11:06:01 +01:00
kfence Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sec_mm Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
backing-dev.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
balloon_compaction.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cleancache.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cma.c mm/cma: use nth_page() in place of direct struct page manipulation 2024-11-18 11:43:25 +01:00
cma.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cma_debug.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
cma_sysfs.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
compaction.c mm: Disable proactive compaction by default 2024-11-19 17:53:38 +01:00
debug.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
debug_page_ref.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
debug_vm_pgtable.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
dmapool.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
early_ioremap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
fadvise.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
failslab.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
filemap.c mm/lru: revise the comments of lru_lock 2024-11-19 17:58:24 +01:00
frame_vector.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
frontswap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
gup.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
gup_benchmark.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
highmem.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hmm.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hpa.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
huge_memory.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hugetlb.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hugetlb_cgroup.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
hwpoison-inject.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
init-mm.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
internal.h mm: avoid unsafe VMA hook invocation when error arises on mmap hook 2024-12-17 13:20:51 +01:00
interval_tree.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
io_record.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ioremap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Kconfig zsmalloc: backport from 5994eabf3bbb 2024-11-19 17:44:14 +01:00
Kconfig.debug Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
khugepaged.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
kmemleak.c mm: kmemleak: Don't die when memory allocation fails 2024-11-19 17:44:35 +01:00
ksm.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
kzerod.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
list_lru.c mm: Omit RCU read lock in list_lru_count_one() when RCU isn't needed 2024-12-18 15:05:51 +01:00
maccess.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
madvise.c Revert "fs: add file and path permissions helpers" 2024-11-19 13:30:21 +01:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mapping_dirty_helpers.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
memblock.c Revert "FROMLIST: memblock: handle overlapped reserved memory region" 2024-12-18 11:05:10 +01:00
memcontrol.c memcg_write_event_control(): fix a user-triggerable oops 2024-11-23 23:20:43 +01:00
memfd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
memory-failure.c mm/memory-failure: fix an incorrect use of tail pages 2024-11-19 09:22:41 +01:00
memory.c mm: avoid leaving partial pfn mappings around in error case 2024-11-23 23:22:05 +01:00
memory_hotplug.c mm/memory_hotplug: use pfn math in place of direct struct page manipulation 2024-11-18 11:43:25 +01:00
mempolicy.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mempool.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
memremap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
memtest.c memtest: use {READ,WRITE}_ONCE in memory scanning 2024-11-19 09:22:36 +01:00
migrate.c mm/migrate: set swap entry values of THP tail pages properly. 2024-11-19 09:22:41 +01:00
mincore.c Revert "fs: add file and path permissions helpers" 2024-11-19 13:30:21 +01:00
mlock.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mm_init.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mmap.c mm: refactor arch_calc_vm_flag_bits() and arm64 MTE handling 2024-12-17 13:23:57 +01:00
mmu_gather.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mmu_notifier.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mmzone.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mprotect.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
mremap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
msync.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
nommu.c mm: refactor arch_calc_vm_flag_bits() and arm64 MTE handling 2024-12-17 13:23:57 +01:00
oom_kill.c mm: oom_kill: Reduce some verbose logging 2024-11-19 17:44:31 +01:00
page-writeback.c Revert "kernel: sysctl: add init protection to common mm-related nodes" 2024-11-19 18:13:49 +01:00
page_alloc.c FROMLIST: BACKPORT: mm: fix is_pinnable_page against on cma page 2025-01-19 17:14:08 +01:00
page_counter.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
page_ext.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
page_idle.c mm: page_idle_get_page() does not need lru_lock 2024-11-19 17:58:44 +01:00
page_io.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
page_isolation.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
page_owner.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
page_pinner.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
page_poison.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
page_reporting.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
page_reporting.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
page_vma_mapped.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pagewalk.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
percpu-internal.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
percpu-km.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
percpu-stats.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
percpu-vm.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
percpu.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pgalloc-track.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pgtable-generic.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
process_vm_access.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ptdump.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
readahead.c vfs: fix readahead(2) on block devices 2024-11-18 11:42:46 +01:00
rmap.c mm/rmap: stop store reordering issue on page->mapping 2024-11-19 17:59:04 +01:00
rodata_test.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
shmem.c mm: refactor arch_calc_vm_flag_bits() and arm64 MTE handling 2024-12-17 13:23:57 +01:00
shuffle.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
shuffle.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
slab.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
slab.h bug on cache_from_obj !PageSlab check 2024-11-30 02:17:27 +01:00
slab_common.c Revert "add __ro_after_init to slab_nomerge and slab_state" 2024-12-03 19:57:00 +01:00
slob.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
slub.c bug on !PageSlab && !PageCompound in ksize 2024-11-30 02:17:21 +01:00
sparse-vmemmap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sparse.c mm/sparsemem: fix race in accessing memory_section->usage 2024-11-18 12:13:06 +01:00
swap.c mm/lru: move lock into lru_note_cost 2024-11-19 17:58:50 +01:00
swap_cgroup.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
swap_slots.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
swap_state.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
swapfile.c Revert "mm/swapfile: skip HugeTLB pages for unuse_vma" 2024-11-24 00:22:53 +01:00
truncate.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
usercopy.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
userfaultfd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
util.c mm: default overcommit_ratio to 100 2025-01-16 21:58:05 +01:00
vmacache.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
vmalloc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
vmpressure.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
vmscan.c mm: vmscan: account for free pages to prevent infinite Loop in throttle_direct_reclaim() 2025-01-15 16:29:56 +01:00
vmstat.c Reapply "mm: vmstat: use power efficient workingqueues" 2024-12-18 11:25:22 +01:00
workingset.c mm/lru: move lock into lru_note_cost 2024-11-19 17:58:50 +01:00
z3fold.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
zbud.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
zpool.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
zsmalloc.c zsmalloc: backport from 5994eabf3bbb 2024-11-19 17:44:14 +01:00
zswap.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00