Ilya Dryomov 0c96499c6c rbd: don't assume RBD_LOCK_STATE_LOCKED for exclusive mappings ... commit 2237ceb71f89837ac47c5dce2aaa2c2b3a337a3c upstream. Every time a watch is reestablished after getting lost, we need to update the cookie which involves quiescing exclusive lock. For this, we transition from RBD_LOCK_STATE_LOCKED to RBD_LOCK_STATE_QUIESCING roughly for the duration of rbd_reacquire_lock() call. If the mapping is exclusive and I/O happens to arrive in this time window, it's failed with EROFS (later translated to EIO) based on the wrong assumption in rbd_img_exclusive_lock() -- "lock got released?" check there stopped making sense with commit a2b1da09793d ("rbd: lock should be quiesced on reacquire"). To make it worse, any such I/O is added to the acquiring list before EROFS is returned and this sets up for violating rbd_lock_del_request() precondition that the request is either on the running list or not on any list at all -- see commit ded080c86b3f ("rbd: don't move requests to the running list on errors"). rbd_lock_del_request() ends up processing these requests as if they were on the running list which screws up quiescing_wait completion counter and ultimately leads to rbd_assert(!completion_done(&rbd_dev->quiescing_wait)); being triggered on the next watch error. Cc: stable@vger.kernel.org # 06ef84c4e9c4: rbd: rename RBD_LOCK_STATE_RELEASING and releasing_wait Cc: stable@vger.kernel.org Fixes: 637cd060537d ("rbd: new exclusive lock wait/wake code") Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-11-23 23:20:16 +01:00
..
accessibility	speakup: Fix sizeof() vs ARRAY_SIZE() bug	2024-11-19 12:26:51 +01:00
acpi	ACPI: processor_idle: Fix invalid comparison with insertion sort for latency	2024-11-19 14:19:50 +01:00
amba
android	binder: fix hang of unregistered readers	2024-11-23 23:20:14 +01:00
ata	ata: libata-core: Fix double free on error	2024-11-19 14:19:34 +01:00
atm	atm: idt77252: fix a memleak in open_card_ubr0	2024-11-18 12:13:24 +01:00
auxdisplay
base	devres: Fix devm_krealloc() wasting memory	2024-11-23 23:20:14 +01:00
battery
bcma
block	rbd: don't assume RBD_LOCK_STATE_LOCKED for exclusive mappings	2024-11-23 23:20:16 +01:00
bluetooth	Bluetooth: qca: Fix BT enable failure again for QCA6390 after warm reboot	2024-11-19 14:19:42 +01:00
bts
bus	bus: tegra-aconnect: Update dependency to ARCH_TEGRA	2024-11-19 08:44:45 +01:00
cdrom
char	hwrng: amd - Convert PCIBIOS_* return codes to errnos	2024-11-23 23:20:14 +01:00
clk	clk: davinci: da8xx-cfgchip: Initialize clk_init_data before use	2024-11-23 23:20:14 +01:00
clocksource	clocksource/drivers/timer-atmel-tcb: Fix initialization on SAM9 hardware	2024-11-18 11:43:12 +01:00
connector
counter	counter: ti-eqep: enable clock at probe	2024-11-19 14:19:33 +01:00
cpufreq	cpufreq: exit() callback is optional	2024-11-19 12:26:54 +01:00
cpuidle	cpuidle: menu: Take negative "sleep length" values into account	2024-11-19 18:01:28 +01:00
crypto	crypto: qat - Fix ADF_DEV_RESET_SYNC memory leak	2024-11-19 12:27:18 +01:00
dax
dca
devfreq	PM / devfreq: Fix buffer overflow in trans_stat_show	2024-11-19 11:32:38 +01:00
dio
dma	dmaengine: ioatdma: Fix missing kmem_cache_destroy()	2024-11-19 14:19:09 +01:00
dma-buf	dma-buf/sync_file: Speed up ioctl by omitting debug names	2024-11-19 17:53:23 +01:00
edac	EDAC, i10nm: make skx_common.o a separate module	2024-11-23 23:19:56 +01:00
eisa
extcon	extcon: max8997: select IRQ_DOMAIN instead of depending on it	2024-11-19 12:27:04 +01:00
fingerprint
firewire	firewire: nosy: ensure user_length is taken into account when fetching packet contents	2024-11-19 11:32:46 +01:00
firmware	firmware: turris-mox-rwtm: Initialize completion before mailbox	2024-11-23 23:20:06 +01:00
fpga	fpga: region: add owner module and take its refcount	2024-11-19 12:27:04 +01:00
fsi
gnss
gpio	gpiolib: cdev: Disallow reconfiguration without direction (uAPI v1)	2024-11-19 14:19:33 +01:00
gpu	drm/panfrost: Mark simple_ondemand governor as softdep	2024-11-23 23:20:16 +01:00
greybus	greybus: Fix use-after-free bug in gb_interface_release due to race condition.	2024-11-19 14:19:05 +01:00
gud
hid	HID: Add quirk for Logitech Casa touchpad	2024-11-19 14:19:06 +01:00
hsi
hv	Drivers: hv: vmbus: Drop error message when 'No request id available'	2024-11-18 23:19:53 +01:00
hwmon	hwmon: (max6697) Fix swapped temp{1,8} critical alarms	2024-11-23 23:19:57 +01:00
hwspinlock
hwtracing	coresight: Fix ref leak when of_coresight_parse_endpoint() fails	2024-11-23 23:20:10 +01:00
i2c	i2c: rcar: fix error code in probe()	2024-11-19 14:19:46 +01:00
i3c	i3c: master: cdns: Update maximum prescaler value for i2c clock	2024-11-18 12:13:19 +01:00
ide
idle
ifconn
iio	iio: chemical: bme680: Fix sensor data read operation	2024-11-19 14:19:33 +01:00
infiniband	RDMA/iwcm: Fix a use-after-free related to destroying CM IDs	2024-11-23 23:20:15 +01:00
input	Input: elan_i2c - do not leave interrupt disabled on suspend failure	2024-11-23 23:20:10 +01:00
interconnect	interconnect: Treat xlate() returning NULL node as an error	2024-11-18 12:12:00 +01:00
iommu	iommu: pcie: Fix incorrect kmemleak_ignore() usage	2024-11-19 17:53:28 +01:00
ipack
irqchip	arm64: Disable GENERIC_IRQ_EFFECTIVE_AFF_MASK	2024-11-19 17:54:22 +01:00
isdn
kperfmon
kq/mesh
leds	leds: ss4200: Convert PCIBIOS_* return codes to errnos	2024-11-23 23:20:13 +01:00
lightnvm
macintosh	macintosh/therm_windtunnel: fix module unload.	2024-11-23 23:20:11 +01:00
mailbox	mailbox: imx: fix suspend failue	2024-11-19 11:32:20 +01:00
mcb	mcb: fix error handling for different scenarios when parsing	2024-11-18 11:43:25 +01:00
md	bcache: fix variable length array abuse in btree_iter	2024-11-19 14:19:29 +01:00
media	media: venus: fix use after free in vdec_close	2024-11-23 23:20:12 +01:00
memory
memstick
message
mfd	mfd: omap-usb-tll: Use struct_size to allocate tll	2024-11-23 23:20:09 +01:00
misc	uid_sys_stats: Remove dependency on the profiling subsystem	2024-11-19 17:53:52 +01:00
mmc	mmc: Disable crc check	2024-11-19 17:47:04 +01:00
most
mtd	ubi: eba: properly rollback inside self_check_eba	2024-11-23 23:20:14 +01:00
muic
mux
net	wifi: mwifiex: Fix interface type change	2024-11-23 23:20:13 +01:00
nfc	NFC: trf7970a: disable all regulators on removal	2024-11-19 11:32:37 +01:00
ntb
nubus
nvdimm	nd_btt: Make BTT lanes preemptible	2024-11-18 11:43:03 +01:00
nvme	nvmet: fix a possible leak when destroy a ctrl during qp establishment	2024-11-19 14:19:43 +01:00
nvmem	nvmem: meson-efuse: Fix return value of nvmem callbacks	2024-11-19 14:19:45 +01:00
of	of: dynamic: Synchronize of_changeset_destroy() with the devlink removals	2024-11-19 09:23:10 +01:00
opp	OPP: debugfs: Fix warning around icc_get_name()	2024-11-19 08:44:49 +01:00
oprofile
parisc
parport	dev/parport: fix the array out-of-bounds risk	2024-11-23 23:20:14 +01:00
pci	PCI: rockchip: Use GPIOD_OUT_LOW flag while requesting ep_gpio	2024-11-23 23:20:14 +01:00
pcmcia	pcmcia: ds: fix possible name leak in error path in pcmcia_device_add()	2024-11-18 11:43:06 +01:00
perf
phy	phy: tegra: xusb: Add API to retrieve the port number of phy	2024-11-19 09:22:34 +01:00
pinctrl	pinctrl: freescale: mxs: Fix refcount of child	2024-11-23 23:20:11 +01:00
platform	platform: mips: cpu_hwmon: Disable driver on unsupported hardware	2024-11-23 23:20:15 +01:00
pnp	PNP: ACPI: fix fortify warning	2024-11-18 12:13:09 +01:00
power	power: supply: cros_usbpd: provide ID table for avoiding fallback match	2024-11-19 14:19:07 +01:00
powercap
pps
ps3
ptp	ptp: Fix error message on failed pin verification	2024-11-19 14:19:01 +01:00
pwm	pwm: stm32: Always do lazy disabling	2024-11-23 23:19:56 +01:00
rapidio
ras
regulator	regulator: core: Fix modpost error "regulator_get_regmap" undefined	2024-11-19 14:19:09 +01:00
remoteproc	remoteproc: k3-r5: Jump to error handling labels in start/stop errors	2024-11-19 14:19:05 +01:00
reset	reset: hisilicon: hi6220: fix Wvoid-pointer-to-enum-cast warning	2024-11-18 12:12:16 +01:00
rpmsg	rpmsg: virtio: Free driver_override when rpmsg_remove()	2024-11-18 12:12:56 +01:00
rtc	rtc: isl1208: Fix return value of nvmem callbacks	2024-11-23 23:20:15 +01:00
s390	s390/sclp: Fix sclp_init() cleanup on failure	2024-11-19 14:19:48 +01:00
samsung
sbus
scsi	scsi: qla2xxx: validate nvme_local_port correctly	2024-11-23 23:20:15 +01:00
sensorhub
sensors
sfi
sh
siox
slimbus	slimbus: core: Remove usage of the deprecated ida_simple_xx() API	2024-11-19 09:22:34 +01:00
soc	soc: qcom: pdr: fix parsing of domains lists	2024-11-23 23:20:01 +01:00
soundwire	soundwire: cadence: fix invalid PDI offset	2024-11-19 12:27:00 +01:00
spi	spi: mux: set ctlr->bits_per_word_mask	2024-11-19 14:19:50 +01:00
spmi
spu_verify
ssb
staging	drivers: staging: Import Xiaomi's binder prio driver	2024-11-19 17:46:55 +01:00
sti
target	target/file: allocate the bvec array as part of struct target_core_file_cmd	2024-11-19 17:42:15 +01:00
tc
tee	tee: optee: Fix kernel panic caused by incorrect error handling	2024-11-19 09:22:39 +01:00
thermal	thermal: core: prevent potential string overflow	2024-11-18 11:42:50 +01:00
thunderbolt	thunderbolt: Fix wake configurations after device unplug	2024-11-19 11:32:22 +01:00
tty	serial: 8250_omap: Fix Errata i2310 with RX FIFO level check	2024-11-19 14:19:39 +01:00
uh
uio	uio: Fix use-after-free in uio_open	2024-11-18 12:12:19 +01:00
usb	USB: core: Fix duplicate endpoint bug by clearing reserved bits in the descriptor	2024-11-19 14:19:45 +01:00
vdpa
vfio	vfio/fsl-mc: Block calling interrupt handler without trigger	2024-11-19 09:22:45 +01:00
vhost	vhost: Add smp_rmb() in vhost_vq_avail_empty()	2024-11-19 11:32:20 +01:00
vibrator
video	Optimized Console FrameBuffer for upto 70% increase in Performance	2024-11-19 17:30:21 +01:00
virt
virtio	virtio: delete vq in vp_find_vqs_msix() when request_irq() fails	2024-11-19 12:27:09 +01:00
vision
vision3
visorbus
vlynq
vme
w1
watchdog	watchdog: rti_wdt: Set min_hw_heartbeat_ms to accommodate a safety margin	2024-11-19 12:27:18 +01:00
xen	xen/events: close evtchn after mapping cleanup	2024-11-19 09:22:39 +01:00
zorro
Kconfig	Added KernelSU	2024-11-19 22:44:48 +01:00
Kconfig.variant1
kernelsu	Added KernelSU	2024-11-19 22:44:48 +01:00
Makefile	Added KernelSU	2024-11-19 22:44:48 +01:00
Makefile.variant1