Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kernel_samsung_a53x/drivers/ata
History
Niklas Cassel da5bd0e7e8 ata: libata-core: Fix double free on error 
commit ab9e0c529eb7cafebdd31fe1644524e80a48b05d upstream.

If e.g. the ata_port_alloc() call in ata_host_alloc() fails, we will jump
to the err_out label, which will call devres_release_group().
devres_release_group() will trigger a call to ata_host_release().
ata_host_release() calls kfree(host), so executing the kfree(host) in
ata_host_alloc() will lead to a double free:

kernel BUG at mm/slub.c:553!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
CPU: 11 PID: 599 Comm: (udev-worker) Not tainted 6.10.0-rc5 #47
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-2.fc40 04/01/2014
RIP: 0010:kfree+0x2cf/0x2f0
Code: 5d 41 5e 41 5f 5d e9 80 d6 ff ff 4d 89 f1 41 b8 01 00 00 00 48 89 d9 48 89 da
RSP: 0018:ffffc90000f377f0 EFLAGS: 00010246
RAX: ffff888112b1f2c0 RBX: ffff888112b1f2c0 RCX: ffff888112b1f320
RDX: 000000000000400b RSI: ffffffffc02c9de5 RDI: ffff888112b1f2c0
RBP: ffffc90000f37830 R08: 0000000000000000 R09: 0000000000000000
R10: ffffc90000f37610 R11: 617461203a736b6e R12: ffffea00044ac780
R13: ffff888100046400 R14: ffffffffc02c9de5 R15: 0000000000000006
FS:  00007f2f1cabe980(0000) GS:ffff88813b380000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2f1c3acf75 CR3: 0000000111724000 CR4: 0000000000750ef0
PKRU: 55555554
Call Trace:
 <TASK>
 ? __die_body.cold+0x19/0x27
 ? die+0x2e/0x50
 ? do_trap+0xca/0x110
 ? do_error_trap+0x6a/0x90
 ? kfree+0x2cf/0x2f0
 ? exc_invalid_op+0x50/0x70
 ? kfree+0x2cf/0x2f0
 ? asm_exc_invalid_op+0x1a/0x20
 ? ata_host_alloc+0xf5/0x120 [libata]
 ? ata_host_alloc+0xf5/0x120 [libata]
 ? kfree+0x2cf/0x2f0
 ata_host_alloc+0xf5/0x120 [libata]
 ata_host_alloc_pinfo+0x14/0xa0 [libata]
 ahci_init_one+0x6c9/0xd20 [ahci]

Ensure that we will not call kfree(host) twice, by performing the kfree()
only if the devres_open_group() call failed.

Fixes: dafd6c496381 ("libata: ensure host is free'd on error exit paths")
Cc: stable@vger.kernel.org
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20240629124210.181537-9-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-19 14:19:34 +01:00
..
acard-ahci.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci.c ata: ahci: Clean up sysfs file on error 2024-11-19 14:19:34 +01:00
ahci.h ahci: add 43-bit DMA address quirk for ASMedia ASM1061 controllers 2024-11-18 22:25:33 +01:00
ahci_brcm.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_ceva.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_da850.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_dm816.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_imx.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_mtk.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_mvebu.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_octeon.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_platform.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_qoriq.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_seattle.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_st.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_sunxi.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_tegra.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_xgene.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ata_generic.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ata_piix.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Kconfig Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libahci.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libahci_platform.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-acpi.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-core.c ata: libata-core: Fix double free on error 2024-11-19 14:19:34 +01:00
libata-eh.c scsi: core: Introduce enum scsi_disposition 2024-11-18 12:13:21 +01:00
libata-pata-timings.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-pmp.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-sata.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-scsi.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-sff.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-trace.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-transport.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-transport.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-zpodd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_acpi.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ali.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_amd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_arasan_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_artop.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_atiixp.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_atp867x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_bk3710.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_buddha.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cmd64x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cmd640.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cs5520.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cs5530.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cs5535.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cs5536.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cypress.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_efar.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ep93xx.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_falcon.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ftide010.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_gayle.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_hpt3x2n.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_hpt3x3.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_hpt37x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_hpt366.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_icside.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_imx.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_isapnp.c ata: pata_isapnp: Add missing error check for devm_ioport_map() 2024-11-18 12:10:54 +01:00
pata_it821x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_it8213.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ixp4xx_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_jmicron.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_legacy.c ata: pata_legacy: make legacy_exit() work again 2024-11-19 12:27:13 +01:00
pata_macio.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_marvell.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_mpc52xx.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_mpiix.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_netcell.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ninja32.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ns87410.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ns87415.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_octeon_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_of_platform.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_oldpiix.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_opti.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_optidma.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_palmld.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_pcmcia.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_pdc202xx_old.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_pdc2027x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_piccolo.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_platform.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_pxa.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_radisys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_rb532_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_rdc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_rz1000.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_samsung_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sc1200.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sch.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_serverworks.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sil680.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sis.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sl82c105.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_triflex.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_via.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pdc_adma.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_dwc_460ex.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_fsl.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_gemini.c ata: sata_gemini: Check clk_enable() result 2024-11-19 11:32:44 +01:00
sata_gemini.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_highbank.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_inic162x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_mv.c ata: sata_mv: Fix PCI device ID table declaration compilation warning 2024-11-19 09:23:10 +01:00
sata_nv.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_promise.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_promise.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_qstor.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_rcar.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_sil.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_sil24.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_sis.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_svw.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_sx4.c ata: sata_sx4: fix pdc20621_get_from_dimm() on 64-bit 2024-11-19 09:23:10 +01:00
sata_uli.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_via.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_vsc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sis.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00