Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kernel_samsung_a53x/drivers/ata
History
Niklas Cassel 676766399f ata: libata-core: Fix null pointer dereference on error 
commit 5d92c7c566dc76d96e0e19e481d926bbe6631c1e upstream.

If the ata_port_alloc() call in ata_host_alloc() fails,
ata_host_release() will get called.

However, the code in ata_host_release() tries to free ata_port struct
members unconditionally, which can lead to the following:

BUG: unable to handle page fault for address: 0000000000003990
PGD 0 P4D 0
Oops: Oops: 0000 [#1] PREEMPT SMP NOPTI
CPU: 10 PID: 594 Comm: (udev-worker) Not tainted 6.10.0-rc5 #44
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-2.fc40 04/01/2014
RIP: 0010:ata_host_release.cold+0x2f/0x6e [libata]
Code: e4 4d 63 f4 44 89 e2 48 c7 c6 90 ad 32 c0 48 c7 c7 d0 70 33 c0 49 83 c6 0e 41
RSP: 0018:ffffc90000ebb968 EFLAGS: 00010246
RAX: 0000000000000041 RBX: ffff88810fb52e78 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffff88813b3218c0 RDI: ffff88813b3218c0
RBP: ffff88810fb52e40 R08: 0000000000000000 R09: 6c65725f74736f68
R10: ffffc90000ebb738 R11: 73692033203a746e R12: 0000000000000004
R13: 0000000000000000 R14: 0000000000000011 R15: 0000000000000006
FS:  00007f6cc55b9980(0000) GS:ffff88813b300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000003990 CR3: 00000001122a2000 CR4: 0000000000750ef0
PKRU: 55555554
Call Trace:
 <TASK>
 ? __die_body.cold+0x19/0x27
 ? page_fault_oops+0x15a/0x2f0
 ? exc_page_fault+0x7e/0x180
 ? asm_exc_page_fault+0x26/0x30
 ? ata_host_release.cold+0x2f/0x6e [libata]
 ? ata_host_release.cold+0x2f/0x6e [libata]
 release_nodes+0x35/0xb0
 devres_release_group+0x113/0x140
 ata_host_alloc+0xed/0x120 [libata]
 ata_host_alloc_pinfo+0x14/0xa0 [libata]
 ahci_init_one+0x6c9/0xd20 [ahci]

Do not access ata_port struct members unconditionally.

Fixes: 633273a3ed1c ("libata-pmp: hook PMP support and enable it")
Cc: stable@vger.kernel.org
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20240629124210.181537-7-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Oleksandr Tymoshenko <ovt@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-01-19 14:59:06 +01:00
..
acard-ahci.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci.c ata: ahci: Clean up sysfs file on error 2024-11-19 14:19:34 +01:00
ahci.h ahci: add 43-bit DMA address quirk for ASMedia ASM1061 controllers 2024-11-18 22:25:33 +01:00
ahci_brcm.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_ceva.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_da850.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_dm816.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_imx.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_mtk.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_mvebu.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_octeon.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_platform.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_qoriq.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_seattle.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_st.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_sunxi.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_tegra.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ahci_xgene.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ata_generic.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
ata_piix.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Kconfig Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libahci.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libahci_platform.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-acpi.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-core.c ata: libata-core: Fix null pointer dereference on error 2025-01-19 14:59:06 +01:00
libata-eh.c scsi: core: Introduce enum scsi_disposition 2024-11-18 12:13:21 +01:00
libata-pata-timings.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-pmp.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-sata.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-scsi.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-sff.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-trace.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-transport.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-transport.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata-zpodd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
libata.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
Makefile Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_acpi.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ali.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_amd.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_arasan_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_artop.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_atiixp.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_atp867x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_bk3710.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_buddha.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cmd64x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cmd640.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cs5520.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cs5530.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cs5535.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cs5536.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_cypress.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_efar.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ep93xx.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_falcon.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ftide010.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_gayle.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_hpt3x2n.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_hpt3x3.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_hpt37x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_hpt366.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_icside.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_imx.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_isapnp.c ata: pata_isapnp: Add missing error check for devm_ioport_map() 2024-11-18 12:10:54 +01:00
pata_it821x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_it8213.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ixp4xx_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_jmicron.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_legacy.c ata: pata_legacy: make legacy_exit() work again 2024-11-19 12:27:13 +01:00
pata_macio.c ata: pata_macio: Use WARN instead of BUG 2025-01-19 00:09:59 +01:00
pata_marvell.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_mpc52xx.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_mpiix.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_netcell.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ninja32.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ns87410.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_ns87415.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_octeon_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_of_platform.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_oldpiix.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_opti.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_optidma.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_palmld.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_pcmcia.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_pdc202xx_old.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_pdc2027x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_piccolo.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_platform.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_pxa.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_radisys.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_rb532_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_rdc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_rz1000.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_samsung_cf.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sc1200.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sch.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_serverworks.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sil680.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sis.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_sl82c105.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_triflex.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pata_via.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
pdc_adma.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_dwc_460ex.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_fsl.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_gemini.c ata: sata_gemini: Check clk_enable() result 2024-11-19 11:32:44 +01:00
sata_gemini.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_highbank.c ata: sata_highbank: fix OF node reference leak in highbank_initialize_phys() 2025-01-02 17:00:49 +01:00
sata_inic162x.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_mv.c ata: sata_mv: Fix PCI device ID table declaration compilation warning 2024-11-19 09:23:10 +01:00
sata_nv.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_promise.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_promise.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_qstor.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_rcar.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_sil.c Revert "ata: sata_sil: Rename sil_blacklist to sil_quirks" 2024-11-24 00:23:06 +01:00
sata_sil24.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_sis.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_svw.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_sx4.c ata: sata_sx4: fix pdc20621_get_from_dimm() on 64-bit 2024-11-19 09:23:10 +01:00
sata_uli.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_via.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sata_vsc.c Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00
sis.h Import A536BXXU9EXDC 2024-06-15 16:02:09 -03:00