Ksawlii
1107016b02
Revert "net: enetc: Use IRQF_NO_AUTOEN flag in request_irq()"
...
This reverts commit e356dcea7c
2024-11-24 00:23:29 +01:00
Ksawlii
cb6b405833
Revert "r8169: disable ALDPS per default for RTL8125"
...
This reverts commit b64d3334b9
2024-11-24 00:23:29 +01:00
Ksawlii
cca2e810e8
Revert "net: seeq: Fix use after free vulnerability in ether3 Driver Due to Race Condition"
...
This reverts commit 2168093ef8
2024-11-24 00:23:18 +01:00
Ksawlii
7948f1fe22
Revert "wifi: rtw88: 8822c: Fix reported RX band width"
...
This reverts commit 3240476a5b
2024-11-24 00:23:16 +01:00
Ksawlii
b3f227d379
Revert "ieee802154: Fix build error"
...
This reverts commit a902682431
2024-11-24 00:23:12 +01:00
Ksawlii
ade1083a2d
Revert "net/mlx5: Fix error path in multi-packet WQE transmit"
...
This reverts commit 270ecc4364
2024-11-24 00:23:12 +01:00
Ksawlii
318078984c
Revert "net/mlx5: Added cond_resched() to crdump collection"
...
This reverts commit 4d839c06f8
2024-11-24 00:23:12 +01:00
Ksawlii
3ffa22465c
Revert "net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request_irq()"
...
This reverts commit dfd74b3f20
2024-11-24 00:23:12 +01:00
Ksawlii
d422a0435b
Revert "net: ethernet: lantiq_etop: fix memory disclosure"
...
This reverts commit 9274ce290d
2024-11-24 00:23:12 +01:00
Ksawlii
1b23c4f488
Revert "wifi: ath9k: fix possible integer overflow in ath9k_get_et_stats()"
...
This reverts commit 011f778de0
2024-11-24 00:23:10 +01:00
Ksawlii
0b1f278e92
Revert "wifi: ath9k_htc: Use __skb_set_length() for resetting urb before resubmit"
...
This reverts commit d6155048f0
2024-11-24 00:23:10 +01:00
Ksawlii
5a67c02dd6
Revert "ice: Adjust over allocation of memory in ice_sched_add_root_node() and ice_sched_add_node()"
...
This reverts commit 30705ece9d
2024-11-24 00:23:10 +01:00
Ksawlii
6c30036842
Revert "net/xen-netback: prevent UAF in xenvif_flush_hash()"
...
This reverts commit fcc9e6b2eb
2024-11-24 00:23:10 +01:00
Ksawlii
312c6c6837
Revert "net: hisilicon: hip04: fix OF node leak in probe()"
...
This reverts commit 894592fa8b
2024-11-24 00:23:10 +01:00
Ksawlii
fae39e1046
Revert "net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info()"
...
This reverts commit 93ae0df7e7
2024-11-24 00:23:10 +01:00
Ksawlii
c8ed470e75
Revert "net: hisilicon: hns_mdio: fix OF node leak in probe()"
...
This reverts commit 63949269ce
2024-11-24 00:23:10 +01:00
Ksawlii
892d56770b
Revert "wifi: ath11k: fix array out-of-bound access in SoC stats"
...
This reverts commit dab9dcbe29
2024-11-24 00:23:10 +01:00
Ksawlii
5fc17c55e9
Revert "wifi: rtw88: select WANT_DEV_COREDUMP"
...
This reverts commit 1cb1422c2d
2024-11-24 00:23:10 +01:00
Ksawlii
1dfd99890d
Revert "net: mvpp2: Increase size of queue_name buffer"
...
This reverts commit 421ea3a3fa
2024-11-24 00:23:08 +01:00
Ksawlii
bb3f1c8add
Revert "net: atlantic: Avoid warning about potential string truncation"
...
This reverts commit f7cf43b465
2024-11-24 00:23:08 +01:00
Ksawlii
5d007952c1
Revert "wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_cmd_802_11_scan_ext()"
...
This reverts commit 6edaf87a29
2024-11-24 00:23:07 +01:00
Ksawlii
2f697a70d6
Revert "nfp: Use IRQF_NO_AUTOEN flag in request_irq()"
...
This reverts commit 62e93957d0
2024-11-24 00:23:07 +01:00
Ksawlii
26d9380b53
Revert "net: stmmac: Fix zero-division error when disabling tc cbs"
...
This reverts commit 9f91978b91
2024-11-24 00:23:01 +01:00
Ksawlii
2415f05839
Revert "r8169: Fix spelling mistake: "tx_underun" -> "tx_underrun""
...
This reverts commit 9a5c8049a7
2024-11-24 00:23:00 +01:00
Ksawlii
d43e90556a
Revert "r8169: add tally counter fields added with RTL8125"
...
This reverts commit b57e5dc84b
2024-11-24 00:23:00 +01:00
Ksawlii
d95116a19d
Revert "net: ethernet: cortina: Drop TSO support"
...
This reverts commit 5a37f561e7
2024-11-24 00:23:00 +01:00
Ksawlii
f19c17b06d
Revert "ice: fix VLAN replay after reset"
...
This reverts commit 6bb154f4ac
2024-11-24 00:22:57 +01:00
Ksawlii
ef7d05955f
Revert "net: phy: dp83869: fix memory corruption when enabling fiber"
...
This reverts commit fba28f12ee
2024-11-24 00:22:57 +01:00
Ksawlii
72f812e3fa
Revert "net: phy: bcm84881: Fix some error handling paths"
...
This reverts commit 5f86c38ebf
2024-11-24 00:22:57 +01:00
Ksawlii
10d6f6c019
Revert "net: dsa: b53: fix jumbo frame mtu check"
...
This reverts commit cc2e77dddf
2024-11-24 00:22:57 +01:00
Ksawlii
dcae248825
Revert "net: dsa: b53: fix max MTU for 1g switches"
...
This reverts commit dd0861a3a4
2024-11-24 00:22:57 +01:00
Ksawlii
54784a20b4
Revert "net: dsa: b53: fix max MTU for BCM5325/BCM5365"
...
This reverts commit b85cee905d
2024-11-24 00:22:57 +01:00
Ksawlii
8c2776c5c0
Revert "net: dsa: b53: allow lower MTUs on BCM5325/5365"
...
This reverts commit 732af45018
2024-11-24 00:22:56 +01:00
Ksawlii
b7d1350f06
Revert "net: dsa: b53: fix jumbo frames on 10/100 ports"
...
This reverts commit 156fe33e3b
2024-11-24 00:22:56 +01:00
Ksawlii
81da5daf84
Revert "igb: Do not bring the device up after non-fatal error"
...
This reverts commit e28819c79a
2024-11-24 00:22:56 +01:00
Ksawlii
e0175afaa9
Revert "net: ibm: emac: mal: fix wrong goto"
...
This reverts commit c04c8e56b9
2024-11-24 00:22:56 +01:00
Ksawlii
8fb27853c1
Revert "ppp: fix ppp_async_encode() illegal access"
...
This reverts commit da367d7cf1
2024-11-24 00:22:56 +01:00
Ksawlii
31712644b6
Revert "slip: make slhc_remember() more robust against malicious packets"
...
This reverts commit 9fe9feaa4c
2024-11-24 00:22:55 +01:00
Ksawlii
dbe2cd7205
Revert "net: dsa: lan9303: ensure chip reset and wait for READY status"
...
This reverts commit 320b2db211
2024-11-24 00:22:55 +01:00
Ksawlii
718af7c653
Revert "net: geneve: add missing netlink policy and size for IFLA_GENEVE_INNER_PROTO_INHERIT"
...
This reverts commit dfbf11f2a3
2024-11-24 00:22:55 +01:00
Ksawlii
5aac9be1db
Revert "net: vrf: determine the dst using the original ifindex for multicast"
...
This reverts commit f3d653f03e
2024-11-24 00:22:54 +01:00
Ksawlii
fab74f7ebd
Revert "net: dsa: microchip: fix build warning"
...
This reverts commit babe59de35
2024-11-24 00:22:54 +01:00
Ksawlii
11b289f4f9
Revert "net: macb: Avoid 20s boot delay by skipping MDIO bus registration for fixed-link PHY"
...
This reverts commit f93e3153c5
2024-11-24 00:22:53 +01:00
Ville Syrjälä
1dd997e076
wifi: iwlegacy: Clear stale interrupts before resuming device
...
commit 07c90acb071b9954e1fecb1e4f4f13d12c544b34 upstream.
iwl4965 fails upon resume from hibernation on my laptop. The reason
seems to be a stale interrupt which isn't being cleared out before
interrupts are enabled. We end up with a race beween the resume
trying to bring things back up, and the restart work (queued form
the interrupt handler) trying to bring things down. Eventually
the whole thing blows up.
Fix the problem by clearing out any stale interrupts before
interrupts get enabled during resume.
Here's a debug log of the indicent:
[ 12.042589] ieee80211 phy0: il_isr ISR inta 0x00000080, enabled 0xaa00008b, fh 0x00000000
[ 12.042625] ieee80211 phy0: il4965_irq_tasklet inta 0x00000080, enabled 0x00000000, fh 0x00000000
[ 12.042651] iwl4965 0000:10:00.0: RF_KILL bit toggled to enable radio.
[ 12.042653] iwl4965 0000:10:00.0: On demand firmware reload
[ 12.042690] ieee80211 phy0: il4965_irq_tasklet End inta 0x00000000, enabled 0xaa00008b, fh 0x00000000, flags 0x00000282
[ 12.052207] ieee80211 phy0: il4965_mac_start enter
[ 12.052212] ieee80211 phy0: il_prep_station Add STA to driver ID 31: ff:ff:ff:ff:ff:ff
[ 12.052244] ieee80211 phy0: il4965_set_hw_ready hardware ready
[ 12.052324] ieee80211 phy0: il_apm_init Init card's basic functions
[ 12.052348] ieee80211 phy0: il_apm_init L1 Enabled; Disabling L0S
[ 12.055727] ieee80211 phy0: il4965_load_bsm Begin load bsm
[ 12.056140] ieee80211 phy0: il4965_verify_bsm Begin verify bsm
[ 12.058642] ieee80211 phy0: il4965_verify_bsm BSM bootstrap uCode image OK
[ 12.058721] ieee80211 phy0: il4965_load_bsm BSM write complete, poll 1 iterations
[ 12.058734] ieee80211 phy0: __il4965_up iwl4965 is coming up
[ 12.058737] ieee80211 phy0: il4965_mac_start Start UP work done.
[ 12.058757] ieee80211 phy0: __il4965_down iwl4965 is going down
[ 12.058761] ieee80211 phy0: il_scan_cancel_timeout Scan cancel timeout
[ 12.058762] ieee80211 phy0: il_do_scan_abort Not performing scan to abort
[ 12.058765] ieee80211 phy0: il_clear_ucode_stations Clearing ucode stations in driver
[ 12.058767] ieee80211 phy0: il_clear_ucode_stations No active stations found to be cleared
[ 12.058819] ieee80211 phy0: _il_apm_stop Stop card, put in low power state
[ 12.058827] ieee80211 phy0: _il_apm_stop_master stop master
[ 12.058864] ieee80211 phy0: il4965_clear_free_frames 0 frames on pre-allocated heap on clear.
[ 12.058869] ieee80211 phy0: Hardware restart was requested
[ 16.132299] iwl4965 0000:10:00.0: START_ALIVE timeout after 4000ms.
[ 16.132303] ------------[ cut here ]------------
[ 16.132304] Hardware became unavailable upon resume. This could be a software issue prior to suspend or a hardware issue.
[ 16.132338] WARNING: CPU: 0 PID: 181 at net/mac80211/util.c:1826 ieee80211_reconfig+0x8f/0x14b0 [mac80211]
[ 16.132390] Modules linked in: ctr ccm sch_fq_codel xt_tcpudp xt_multiport xt_state iptable_filter iptable_nat nf_nat nf_conntrack nf_defrag_ipv4 ip_tables x_tables binfmt_misc joydev mousedev btusb btrtl btintel btbcm bluetooth ecdh_generic ecc iTCO_wdt i2c_dev iwl4965 iwlegacy coretemp snd_hda_codec_analog pcspkr psmouse mac80211 snd_hda_codec_generic libarc4 sdhci_pci cqhci sha256_generic sdhci libsha256 firewire_ohci snd_hda_intel snd_intel_dspcfg mmc_core snd_hda_codec snd_hwdep firewire_core led_class iosf_mbi snd_hda_core uhci_hcd lpc_ich crc_itu_t cfg80211 ehci_pci ehci_hcd snd_pcm usbcore mfd_core rfkill snd_timer snd usb_common soundcore video parport_pc parport intel_agp wmi intel_gtt backlight e1000e agpgart evdev
[ 16.132456] CPU: 0 UID: 0 PID: 181 Comm: kworker/u8:6 Not tainted 6.11.0-cl+ #143
[ 16.132460] Hardware name: Hewlett-Packard HP Compaq 6910p/30BE, BIOS 68MCU Ver. F.19 07/06/2010
[ 16.132463] Workqueue: async async_run_entry_fn
[ 16.132469] RIP: 0010:ieee80211_reconfig+0x8f/0x14b0 [mac80211]
[ 16.132501] Code: da 02 00 00 c6 83 ad 05 00 00 00 48 89 df e8 98 1b fc ff 85 c0 41 89 c7 0f 84 e9 02 00 00 48 c7 c7 a0 e6 48 a0 e8 d1 77 c4 e0 <0f> 0b eb 2d 84 c0 0f 85 8b 01 00 00 c6 87 ad 05 00 00 00 e8 69 1b
[ 16.132504] RSP: 0018:ffffc9000029fcf0 EFLAGS: 00010282
[ 16.132507] RAX: 0000000000000000 RBX: ffff8880072008e0 RCX: 0000000000000001
[ 16.132509] RDX: ffffffff81f21a18 RSI: 0000000000000086 RDI: 0000000000000001
[ 16.132510] RBP: ffff8880072003c0 R08: 0000000000000000 R09: 0000000000000003
[ 16.132512] R10: 0000000000000000 R11: ffff88807e5b0000 R12: 0000000000000001
[ 16.132514] R13: 0000000000000000 R14: 0000000000000000 R15: 00000000ffffff92
[ 16.132515] FS: 0000000000000000(0000) GS:ffff88807c200000(0000) knlGS:0000000000000000
[ 16.132517] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 16.132519] CR2: 000055dd43786c08 CR3: 000000000978f000 CR4: 00000000000006f0
[ 16.132521] Call Trace:
[ 16.132525] <TASK>
[ 16.132526] ? __warn+0x77/0x120
[ 16.132532] ? ieee80211_reconfig+0x8f/0x14b0 [mac80211]
[ 16.132564] ? report_bug+0x15c/0x190
[ 16.132568] ? handle_bug+0x36/0x70
[ 16.132571] ? exc_invalid_op+0x13/0x60
[ 16.132573] ? asm_exc_invalid_op+0x16/0x20
[ 16.132579] ? ieee80211_reconfig+0x8f/0x14b0 [mac80211]
[ 16.132611] ? snd_hdac_bus_init_cmd_io+0x24/0x200 [snd_hda_core]
[ 16.132617] ? pick_eevdf+0x133/0x1c0
[ 16.132622] ? check_preempt_wakeup_fair+0x70/0x90
[ 16.132626] ? wakeup_preempt+0x4a/0x60
[ 16.132628] ? ttwu_do_activate.isra.0+0x5a/0x190
[ 16.132632] wiphy_resume+0x79/0x1a0 [cfg80211]
[ 16.132675] ? wiphy_suspend+0x2a0/0x2a0 [cfg80211]
[ 16.132697] dpm_run_callback+0x75/0x1b0
[ 16.132703] device_resume+0x97/0x200
[ 16.132707] async_resume+0x14/0x20
[ 16.132711] async_run_entry_fn+0x1b/0xa0
[ 16.132714] process_one_work+0x13d/0x350
[ 16.132718] worker_thread+0x2be/0x3d0
[ 16.132722] ? cancel_delayed_work_sync+0x70/0x70
[ 16.132725] kthread+0xc0/0xf0
[ 16.132729] ? kthread_park+0x80/0x80
[ 16.132732] ret_from_fork+0x28/0x40
[ 16.132735] ? kthread_park+0x80/0x80
[ 16.132738] ret_from_fork_asm+0x11/0x20
[ 16.132741] </TASK>
[ 16.132742] ---[ end trace 0000000000000000 ]---
[ 16.132930] ------------[ cut here ]------------
[ 16.132932] WARNING: CPU: 0 PID: 181 at net/mac80211/driver-ops.c:41 drv_stop+0xe7/0xf0 [mac80211]
[ 16.132957] Modules linked in: ctr ccm sch_fq_codel xt_tcpudp xt_multiport xt_state iptable_filter iptable_nat nf_nat nf_conntrack nf_defrag_ipv4 ip_tables x_tables binfmt_misc joydev mousedev btusb btrtl btintel btbcm bluetooth ecdh_generic ecc iTCO_wdt i2c_dev iwl4965 iwlegacy coretemp snd_hda_codec_analog pcspkr psmouse mac80211 snd_hda_codec_generic libarc4 sdhci_pci cqhci sha256_generic sdhci libsha256 firewire_ohci snd_hda_intel snd_intel_dspcfg mmc_core snd_hda_codec snd_hwdep firewire_core led_class iosf_mbi snd_hda_core uhci_hcd lpc_ich crc_itu_t cfg80211 ehci_pci ehci_hcd snd_pcm usbcore mfd_core rfkill snd_timer snd usb_common soundcore video parport_pc parport intel_agp wmi intel_gtt backlight e1000e agpgart evdev
[ 16.133014] CPU: 0 UID: 0 PID: 181 Comm: kworker/u8:6 Tainted: G W 6.11.0-cl+ #143
[ 16.133018] Tainted: [W]=WARN
[ 16.133019] Hardware name: Hewlett-Packard HP Compaq 6910p/30BE, BIOS 68MCU Ver. F.19 07/06/2010
[ 16.133021] Workqueue: async async_run_entry_fn
[ 16.133025] RIP: 0010:drv_stop+0xe7/0xf0 [mac80211]
[ 16.133048] Code: 48 85 c0 74 0e 48 8b 78 08 89 ea 48 89 de e8 e0 87 04 00 65 ff 0d d1 de c4 5f 0f 85 42 ff ff ff e8 be 52 c2 e0 e9 38 ff ff ff <0f> 0b 5b 5d c3 0f 1f 40 00 41 54 49 89 fc 55 53 48 89 f3 2e 2e 2e
[ 16.133050] RSP: 0018:ffffc9000029fc50 EFLAGS: 00010246
[ 16.133053] RAX: 0000000000000000 RBX: ffff8880072008e0 RCX: ffff88800377f6c0
[ 16.133054] RDX: 0000000000000001 RSI: 0000000000000000 RDI: ffff8880072008e0
[ 16.133056] RBP: 0000000000000000 R08: ffffffff81f238d8 R09: 0000000000000000
[ 16.133058] R10: ffff8880080520f0 R11: 0000000000000000 R12: ffff888008051c60
[ 16.133060] R13: ffff8880072008e0 R14: 0000000000000000 R15: ffff8880072011d8
[ 16.133061] FS: 0000000000000000(0000) GS:ffff88807c200000(0000) knlGS:0000000000000000
[ 16.133063] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 16.133065] CR2: 000055dd43786c08 CR3: 000000000978f000 CR4: 00000000000006f0
[ 16.133067] Call Trace:
[ 16.133069] <TASK>
[ 16.133070] ? __warn+0x77/0x120
[ 16.133075] ? drv_stop+0xe7/0xf0 [mac80211]
[ 16.133098] ? report_bug+0x15c/0x190
[ 16.133100] ? handle_bug+0x36/0x70
[ 16.133103] ? exc_invalid_op+0x13/0x60
[ 16.133105] ? asm_exc_invalid_op+0x16/0x20
[ 16.133109] ? drv_stop+0xe7/0xf0 [mac80211]
[ 16.133132] ieee80211_do_stop+0x55a/0x810 [mac80211]
[ 16.133161] ? fq_codel_reset+0xa5/0xc0 [sch_fq_codel]
[ 16.133164] ieee80211_stop+0x4f/0x180 [mac80211]
[ 16.133192] __dev_close_many+0xa2/0x120
[ 16.133195] dev_close_many+0x90/0x150
[ 16.133198] dev_close+0x5d/0x80
[ 16.133200] cfg80211_shutdown_all_interfaces+0x40/0xe0 [cfg80211]
[ 16.133223] wiphy_resume+0xb2/0x1a0 [cfg80211]
[ 16.133247] ? wiphy_suspend+0x2a0/0x2a0 [cfg80211]
[ 16.133269] dpm_run_callback+0x75/0x1b0
[ 16.133273] device_resume+0x97/0x200
[ 16.133277] async_resume+0x14/0x20
[ 16.133280] async_run_entry_fn+0x1b/0xa0
[ 16.133283] process_one_work+0x13d/0x350
[ 16.133287] worker_thread+0x2be/0x3d0
[ 16.133290] ? cancel_delayed_work_sync+0x70/0x70
[ 16.133294] kthread+0xc0/0xf0
[ 16.133296] ? kthread_park+0x80/0x80
[ 16.133299] ret_from_fork+0x28/0x40
[ 16.133302] ? kthread_park+0x80/0x80
[ 16.133304] ret_from_fork_asm+0x11/0x20
[ 16.133307] </TASK>
[ 16.133308] ---[ end trace 0000000000000000 ]---
[ 16.133335] ieee80211 phy0: PM: dpm_run_callback(): wiphy_resume [cfg80211] returns -110
[ 16.133360] ieee80211 phy0: PM: failed to restore async: error -110
Cc: stable@vger.kernel.org
Cc: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241001200745.8276-1-ville.syrjala@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-23 23:22:05 +01:00
Manikanta Pubbisetty
b0b681f307
wifi: ath10k: Fix memory leak in management tx
...
commit e15d84b3bba187aa372dff7c58ce1fd5cb48a076 upstream.
In the current logic, memory is allocated for storing the MSDU context
during management packet TX but this memory is not being freed during
management TX completion. Similar leaks are seen in the management TX
cleanup logic.
Kmemleak reports this problem as below,
unreferenced object 0xffffff80b64ed250 (size 16):
comm "kworker/u16:7", pid 148, jiffies 4294687130 (age 714.199s)
hex dump (first 16 bytes):
00 2b d8 d8 80 ff ff ff c4 74 e9 fd 07 00 00 00 .+.......t......
backtrace:
[<ffffffe6e7b245dc>] __kmem_cache_alloc_node+0x1e4/0x2d8
[<ffffffe6e7adde88>] kmalloc_trace+0x48/0x110
[<ffffffe6bbd765fc>] ath10k_wmi_tlv_op_gen_mgmt_tx_send+0xd4/0x1d8 [ath10k_core]
[<ffffffe6bbd3eed4>] ath10k_mgmt_over_wmi_tx_work+0x134/0x298 [ath10k_core]
[<ffffffe6e78d5974>] process_scheduled_works+0x1ac/0x400
[<ffffffe6e78d60b8>] worker_thread+0x208/0x328
[<ffffffe6e78dc890>] kthread+0x100/0x1c0
[<ffffffe6e78166c0>] ret_from_fork+0x10/0x20
Free the memory during completion and cleanup to fix the leak.
Protect the mgmt_pending_tx idr_remove() operation in
ath10k_wmi_tlv_op_cleanup_mgmt_tx_send() using ar->data_lock similar to
other instances.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1
Fixes: dc405152bb64 ("ath10k: handle mgmt tx completion event")
Fixes: c730c477176a ("ath10k: Remove msdu from idr when management pkt send fails")
Cc: stable@vger.kernel.org
Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Link: https://patch.msgid.link/20241015064103.6060-1-quic_mpubbise@quicinc.com
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-23 23:22:05 +01:00
Daniel Palmer
d69778df1a
net: amd: mvme147: Fix probe banner message
...
[ Upstream commit 82c5b53140faf89c31ea2b3a0985a2f291694169 ]
Currently this driver prints this line with what looks like
a rogue format specifier when the device is probed:
[ 2.840000] eth%d: MVME147 at 0xfffe1800, irq 12, Hardware Address xx:xx:xx:xx:xx:xx
Change the printk() for netdev_info() and move it after the
registration has completed so it prints out the name of the
interface properly.
Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-23 23:22:04 +01:00
Pablo Neira Ayuso
c4de1e3da7
gtp: allow -1 to be specified as file description from userspace
...
[ Upstream commit 7515e37bce5c428a56a9b04ea7e96b3f53f17150 ]
Existing user space applications maintained by the Osmocom project are
breaking since a recent fix that addresses incorrect error checking.
Restore operation for user space programs that specify -1 as file
descriptor to skip GTPv0 or GTPv1 only sockets.
Fixes: defd8b3c37b0 ("gtp: fix a potential NULL pointer dereference")
Reported-by: Pau Espin Pedrol <pespin@sysmocom.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Tested-by: Oliver Smith <osmith@sysmocom.de>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241022144825.66740-1-pablo@netfilter.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-23 23:22:03 +01:00
Daniel Gabay
00e8046b39
wifi: iwlwifi: mvm: Fix response handling in iwl_mvm_send_recovery_cmd()
...
[ Upstream commit 07a6e3b78a65f4b2796a8d0d4adb1a15a81edead ]
1. The size of the response packet is not validated.
2. The response buffer is not freed.
Resolve these issues by switching to iwl_mvm_send_cmd_status(),
which handles both size validation and frees the buffer.
Fixes: f130bb75d881 ("iwlwifi: add FW recovery flow")
Signed-off-by: Daniel Gabay <daniel.gabay@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20241010140328.76c73185951e.Id3b6ca82ced2081f5ee4f33c997491d0ebda83f7@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-23 23:22:03 +01:00
Emmanuel Grumbach
8c0b10408d
wifi: iwlwifi: mvm: disconnect station vifs if recovery failed
...
[ Upstream commit e50a88e5cb8792cc416866496288c5f4d1eb4b1f ]
This will allow to reconnect immediately instead of leaving the
connection in a limbo state.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Gregory Greenman <gregory.greenman@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240128084842.e90531cd3a36.Iebdc9483983c0d8497f9dcf9d79ec37332a5fdcc@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Stable-dep-of: 07a6e3b78a65 ("wifi: iwlwifi: mvm: Fix response handling in iwl_mvm_send_recovery_cmd()")
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-23 23:22:03 +01:00
Geert Uytterhoeven
feb4cb910c
wifi: brcm80211: BRCM_TRACING should depend on TRACING
...
[ Upstream commit b73b2069528f90ec49d5fa1010a759baa2c2be05 ]
When tracing is disabled, there is no point in asking the user about
enabling Broadcom wireless device tracing.
Fixes: f5c4f10852d42012 ("brcm80211: Allow trace support to be enabled separately from debug")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/81a29b15eaacc1ac1fb421bdace9ac0c3385f40f.1727179742.git.geert@linux-m68k.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-23 23:22:03 +01:00
