From fdcb87e105505e4be2c9e087efa171d1a6bf1b52 Mon Sep 17 00:00:00 2001 From: Joseph Qi Date: Tue, 23 Feb 2021 09:55:28 +0800 Subject: [PATCH] block/bfq: update comments and default value in docs for fifo_expire Correct the comments since bfq_fifo_expire[0] is for async request, while bfq_fifo_expire[1] is for sync request. Also update docs, according the source code, the default fifo_expire_async is 250ms, and fifo_expire_sync is 125ms. Signed-off-by: Joseph Qi Acked-by: Paolo Valente Signed-off-by: Jens Axboe (cherry picked from commit 4168a8d27ed3a00f160e7f885c956f060d2a0741) (cherry picked from commit a31ff2eb7d7cfa8331e513bb282f304117f18a77) (cherry picked from commit a78637befaa4106f9858b3ad8e3273960d3de82b) (cherry picked from commit bd8e7d3845c7a3b602aee361c7e3d0b5764ce060) (cherry picked from commit a8543954accfadbb9a1cf1f64c6b3749ee3a629b) (cherry picked from commit 960981f44b77dcd0d4e786aaef72d39057ccfc03) (cherry picked from commit 50cfb4b6c1c2e4a3778f66510fee7a2e86e053f2) --- Documentation/block/bfq-iosched.rst | 4 ++-- block/bfq-iosched.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/block/bfq-iosched.rst b/Documentation/block/bfq-iosched.rst index 19d4d1570..66c5a4e54 100755 --- a/Documentation/block/bfq-iosched.rst +++ b/Documentation/block/bfq-iosched.rst @@ -430,13 +430,13 @@ fifo_expire_async ----------------- This parameter is used to set the timeout of asynchronous requests. Default -value of this is 248ms. +value of this is 250ms. fifo_expire_sync ---------------- This parameter is used to set the timeout of synchronous requests. Default -value of this is 124ms. In case to favor synchronous requests over asynchronous +value of this is 125ms. In case to favor synchronous requests over asynchronous one, this value should be decreased relative to fifo_expire_async. low_latency diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 5180391a5..a6f796a1c 100755 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -161,7 +161,7 @@ BFQ_BFQQ_FNS(softrt_update); BFQ_BFQQ_FNS(has_waker); #undef BFQ_BFQQ_FNS \ -/* Expiration time of sync (0) and async (1) requests, in ns. */ +/* Expiration time of async (0) and sync (1) requests, in ns. */ static const u64 bfq_fifo_expire[2] = { NSEC_PER_SEC / 4, NSEC_PER_SEC / 8 }; /* Maximum backwards seek (magic number lifted from CFQ), in KiB. */