Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mISDN: Fix a use after free in hfcmulti_tx()

Browse source 
[ Upstream commit 61ab751451f5ebd0b98e02276a44e23a10110402 ]

Don't dereference *sp after calling dev_kfree_skb(*sp).

Fixes: af69fb3a8ffa ("Add mISDN HFC multiport driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/8be65f5a-c2dd-4ba0-8a10-bfe5980b8cfb@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dan Carpenter 2024-07-24 11:08:18 -05:00 • committed by Ksawlii
parent 4e1a409742
commit fd2a9f3fef
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/isdn/hardware/mISDN/hfcmulti.c
View file

@ -1931,7 +1931,7 @@ hfcmulti_dtmf(struct hfc_multi *hc)
static void static void
hfcmulti_tx(struct hfc_multi *hc, int ch) hfcmulti_tx(struct hfc_multi *hc, int ch)
{ {
int i, ii, temp, len = 0; int i, ii, temp, tmp_len, len = 0;
int Zspace, z1, z2; /* must be int for calculation */ int Zspace, z1, z2; /* must be int for calculation */
int Fspace, f1, f2; int Fspace, f1, f2;
u_char *d; u_char *d;
@ -2152,14 +2152,15 @@ next_frame:
HFC_wait_nodebug(hc); HFC_wait_nodebug(hc);
} }
tmp_len = (*sp)->len;
dev_kfree_skb(*sp); dev_kfree_skb(*sp);
/* check for next frame */ /* check for next frame */
if (bch && get_next_bframe(bch)) { if (bch && get_next_bframe(bch)) {
len = (*sp)->len; len = tmp_len;
goto next_frame; goto next_frame;
} }
if (dch && get_next_dframe(dch)) { if (dch && get_next_dframe(dch)) {
len = (*sp)->len; len = tmp_len;
goto next_frame; goto next_frame;
} }