From f11cfb0398407bbf03eca23d53f28f9c3f363c6b Mon Sep 17 00:00:00 2001 From: Karan Date: Wed, 15 Nov 2023 15:06:15 -0800 Subject: [PATCH] driver: pwm: Implement .apply() callback To eventually get rid of all legacy drivers convert this driver to the modern world implementing .apply(). The commit which brings these changes is `5ec803edcb703fe379836f13560b79dfac79b01d` on the uplink kernel. Bug: 332793240 Change-Id: I385f487c474ca2d52a9f3bb4e8afc3843eb4d9f8 Signed-off-by: Karan Bhagoji Signed-off-by: Hyunki Koo --- drivers/pwm/pwm-samsung.c | 47 +++++++++++++++++++++++++++++++++++---- 1 file changed, 43 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c index 737b6c694..a3d633120 100755 --- a/drivers/pwm/pwm-samsung.c +++ b/drivers/pwm/pwm-samsung.c @@ -603,13 +603,52 @@ static int pwm_samsung_capture(struct pwm_chip *chip, struct pwm_device *pwm, return 0; } +static int pwm_samsung_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + int err, enabled = pwm->state.enabled; + + if (state->polarity != pwm->state.polarity) { + if (enabled) { + pwm_samsung_disable(chip, pwm); + enabled = false; + } + + err = pwm_samsung_set_polarity(chip, pwm, state->polarity); + if (err) + return err; + } + + if (!state->enabled) { + if (enabled) + pwm_samsung_disable(chip, pwm); + + return 0; + } + + /* + * We currently avoid using 64bit arithmetic by using the + * fact that anything faster than 1Hz is easily representable + * by 32bits. + */ + if (state->period > NSEC_PER_SEC) + return -ERANGE; + + err = pwm_samsung_config(chip, pwm, state->duty_cycle, state->period); + if (err) + return err; + + if (!pwm->state.enabled) + err = pwm_samsung_enable(chip, pwm); + + return err; +} + + static const struct pwm_ops pwm_samsung_ops = { .request = pwm_samsung_request, .free = pwm_samsung_free, - .enable = pwm_samsung_enable, - .disable = pwm_samsung_disable, - .config = pwm_samsung_config, - .set_polarity = pwm_samsung_set_polarity, + .apply = pwm_samsung_apply, .capture = pwm_samsung_capture, .owner = THIS_MODULE, };