Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ALSA: line6: Zero-initialize message buffers

Browse source 
[ Upstream commit c4e51e424e2c772ce1836912a8b0b87cd61bc9d5 ]

For shutting up spurious KMSAN uninit-value warnings, just replace
kmalloc() calls with kzalloc() for the buffers used for
communications.  There should be no real issue with the original code,
but it's still better to cover.

Reported-by: syzbot+7fb05ccf7b3d2f9617b3@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/r/00000000000084b18706150bcca5@google.com
Message-ID: <20240402063628.26609-1-tiwai@suse.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Takashi Iwai 2024-04-02 08:36:25 +02:00 committed by Ksawlii
parent 99495b5451
commit e7ca41fbfc
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sound/usb/line6/driver.c
View file

@ -202,7 +202,7 @@ int line6_send_raw_message_async(struct usb_line6 *line6, const char *buffer,
struct urb *urb; struct urb *urb;
/* create message: */ /* create message: */
msg = kmalloc(sizeof(struct message), GFP_ATOMIC); msg = kzalloc(sizeof(struct message), GFP_ATOMIC);
if (msg == NULL) if (msg == NULL)
return -ENOMEM; return -ENOMEM;
@ -688,7 +688,7 @@ static int line6_init_cap_control(struct usb_line6 *line6)
int ret; int ret;
/* initialize USB buffers: */ /* initialize USB buffers: */
line6->buffer_listen = kmalloc(LINE6_BUFSIZE_LISTEN, GFP_KERNEL); line6->buffer_listen = kzalloc(LINE6_BUFSIZE_LISTEN, GFP_KERNEL);
if (!line6->buffer_listen) if (!line6->buffer_listen)
return -ENOMEM; return -ENOMEM;
@ -697,7 +697,7 @@ static int line6_init_cap_control(struct usb_line6 *line6)
return -ENOMEM; return -ENOMEM;
if (line6->properties->capabilities & LINE6_CAP_CONTROL_MIDI) { if (line6->properties->capabilities & LINE6_CAP_CONTROL_MIDI) {
line6->buffer_message = kmalloc(LINE6_MIDI_MESSAGE_MAXLEN, GFP_KERNEL); line6->buffer_message = kzalloc(LINE6_MIDI_MESSAGE_MAXLEN, GFP_KERNEL);
if (!line6->buffer_message) if (!line6->buffer_message)
return -ENOMEM; return -ENOMEM;