Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tcp: fix incorrect parameter validation in the do_tcp_getsockopt() function

Browse source 
[ Upstream commit 716edc9706deb3bb2ff56e2eeb83559cea8f22db ]

The 'len' variable can't be negative when assigned the result of
'min_t' because all 'min_t' parameters are cast to unsigned int,
and then the minimum one is chosen.

To fix the logic, check 'len' as read from 'optlen',
where the types of relevant variables are (signed) int.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Gavrilov Ilia 2024-03-07 14:23:49 +00:00 • committed by Ksawlii
parent 89da6f6327
commit e73308a010
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
net/ipv4/tcp.c
View file

@ -3718,11 +3718,11 @@ static int do_tcp_getsockopt(struct sock *sk, int level,
if (get_user(len, optlen)) if (get_user(len, optlen))
return -EFAULT; return -EFAULT;
len = min_t(unsigned int, len, sizeof(int));
if (len < 0) if (len < 0)
return -EINVAL; return -EINVAL;
len = min_t(unsigned int, len, sizeof(int));
switch (optname) { switch (optname) {
case TCP_MAXSEG: case TCP_MAXSEG:
val = tp->mss_cache; val = tp->mss_cache;