Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tty: use 'if' in send_break() instead of 'goto'

Browse source 
[ Upstream commit 24f2cd019946fc2e88e632d2e24a34c2cc3f2be4 ]

Now, the "jumped-over" code is simple enough to be put inside an 'if'.
Do so to make it 'goto'-less.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230919085156.1578-16-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Stable-dep-of: 66aad7d8d3ec ("usb: cdc-acm: return correct error code on unsupported break")
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jiri Slaby (SUSE) 2023-09-19 10:51:56 +02:00 committed by Ksawlii
parent 4b60b46d44
commit ceca465a16
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/tty/tty_io.c
View file

@ -2477,11 +2477,10 @@ static int send_break(struct tty_struct *tty, unsigned int duration)
return -EINTR;
retval = tty->ops->break_ctl(tty, -1);
if (retval)
goto out;
msleep_interruptible(duration);
retval = tty->ops->break_ctl(tty, 0);
out:
if (!retval) {
msleep_interruptible(duration);
retval = tty->ops->break_ctl(tty, 0);
}
tty_write_unlock(tty);
if (signal_pending(current))