Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

kdb: Merge identical case statements in kdb_read()

Browse source 
commit 6244917f377bf64719551b58592a02a0336a7439 upstream.

The code that handles case 14 (down) and case 16 (up) has been copy and
pasted despite being byte-for-byte identical. Combine them.

Cc: stable@vger.kernel.org # Not a bug fix but it is needed for later bug fixes
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20240424-kgdb_read_refactor-v3-4-f236dbe9828d@linaro.org
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Daniel Thompson 2024-04-24 15:03:37 +01:00 committed by Ksawlii
parent 8004752fc8
commit c19c865f2f
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
kernel/debug/kdb/kdb_io.c
View file

@ -304,6 +304,7 @@ poll_again:
} }
break; break;
case 14: /* Down */ case 14: /* Down */
case 16: /* Up */
memset(tmpbuffer, ' ', memset(tmpbuffer, ' ',
strlen(kdb_prompt_str) + (lastchar-buffer)); strlen(kdb_prompt_str) + (lastchar-buffer));
*(tmpbuffer+strlen(kdb_prompt_str) + *(tmpbuffer+strlen(kdb_prompt_str) +
@ -318,15 +319,6 @@ poll_again:
++cp; ++cp;
} }
break; break;
case 16: /* Up */
memset(tmpbuffer, ' ',
strlen(kdb_prompt_str) + (lastchar-buffer));
*(tmpbuffer+strlen(kdb_prompt_str) +
(lastchar-buffer)) = '\0';
kdb_printf("\r%s\r", tmpbuffer);
*lastchar = (char)key;
*(lastchar+1) = '\0';
return lastchar;
case 9: /* Tab */ case 9: /* Tab */
if (tab < 2) if (tab < 2)
++tab; ++tab;