Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

phy: core: Fix that API devm_phy_destroy() fails to destroy the phy

Browse source 
commit 4dc48c88fcf82b89fdebd83a906aaa64f40fb8a9 upstream.

For devm_phy_destroy(), its comment says it needs to invoke phy_destroy()
to destroy the phy, but it will not actually invoke the function since
devres_destroy() does not call devm_phy_consume(), and the missing
phy_destroy() call will cause that the phy fails to be destroyed.

Fortunately, the faulty API has not been used by current kernel tree.
Fix by using devres_release() instead of devres_destroy() within the API.

Fixes: ff764963479a ("drivers: phy: add generic PHY framework")
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241213-phy_core_fix-v6-3-40ae28f5015a@quicinc.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Zijun Hu 2024-12-13 20:36:43 +08:00 committed by Ksawlii
parent cd3a9e14e6
commit b8a47997f3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/phy/phy-core.c
View file

@ -991,7 +991,7 @@ void devm_phy_destroy(struct device *dev, struct phy *phy)
{ {
int r; int r;
r = devres_destroy(dev, devm_phy_consume, devm_phy_match, phy); r = devres_release(dev, devm_phy_consume, devm_phy_match, phy);
dev_WARN_ONCE(dev, r, "couldn't find PHY resource\n"); dev_WARN_ONCE(dev, r, "couldn't find PHY resource\n");
} }
EXPORT_SYMBOL_GPL(devm_phy_destroy); EXPORT_SYMBOL_GPL(devm_phy_destroy);