perf report: Fix condition in sort__sym_cmp()
[ Upstream commit cb39d05e67dc24985ff9f5150e71040fa4d60ab8 ] It's expected that both hist entries are in the same hists when comparing two. But the current code in the function checks one without dso sort key and other with the key. This would make the condition true in any case. I guess the intention of the original commit was to add '!' for the right side too. But as it should be the same, let's just remove it. Fixes: 69849fc5d2119 ("perf hists: Move sort__has_dso into struct perf_hpp_list") Reviewed-by: Kan Liang <kan.liang@linux.intel.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> Link: https://lore.kernel.org/r/20240621170528.608772-2-namhyung@kernel.org Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
46f6568c7f
commit
b6621ebcd5
1 changed files with 1 additions and 1 deletions
|
@ -272,7 +272,7 @@ sort__sym_cmp(struct hist_entry *left, struct hist_entry *right)
|
|||
* comparing symbol address alone is not enough since it's a
|
||||
* relative address within a dso.
|
||||
*/
|
||||
if (!hists__has(left->hists, dso) || hists__has(right->hists, dso)) {
|
||||
if (!hists__has(left->hists, dso)) {
|
||||
ret = sort__dso_cmp(left, right);
|
||||
if (ret != 0)
|
||||
return ret;
|
||||
|
|
Loading…
Reference in a new issue