From a588fda053130495c5f116dbe186bf2805a81c56 Mon Sep 17 00:00:00 2001 From: Ksawlii Date: Sun, 24 Nov 2024 00:23:46 +0100 Subject: [PATCH] Revert "sch/netem: fix use after free in netem_dequeue" This reverts commit 4959125286c6abd33381a652fc978dec03c291db. --- net/sched/sch_netem.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 93ed7bac9..e0e16b0fd 100755 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -733,10 +733,11 @@ deliver: err = qdisc_enqueue(skb, q->qdisc, &to_free); kfree_skb_list(to_free); - if (err != NET_XMIT_SUCCESS) { - if (net_xmit_drop_count(err)) - qdisc_qstats_drop(sch); - qdisc_tree_reduce_backlog(sch, 1, pkt_len); + if (err != NET_XMIT_SUCCESS && + net_xmit_drop_count(err)) { + qdisc_qstats_drop(sch); + qdisc_tree_reduce_backlog(sch, 1, + pkt_len); } goto tfifo_dequeue; }