Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iio: pressure: dps310: support negative temperature values

Browse source 
[ Upstream commit 9dd6b32e76ff714308964cd9ec91466a343dcb8b ]

The current implementation interprets negative values returned from
`dps310_calculate_temp` as error codes.
This has a side effect that when negative temperature values are
calculated, they are interpreted as error.

Fix this by using the return value only for error handling and passing a
pointer for the value.

Fixes: ba6ec48e76bc ("iio: Add driver for Infineon DPS310")
Signed-off-by: Thomas Haemmerle <thomas.haemmerle@leica-geosystems.com>
Link: https://lore.kernel.org/r/20240415105030.1161770-2-thomas.haemmerle@leica-geosystems.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Thomas Haemmerle 2024-04-15 12:50:27 +02:00 • committed by Ksawlii
parent dbebaf0eb7
commit 9b0dffbf5e
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/iio/pressure/dps310.c
View file

@ -730,7 +730,7 @@ static int dps310_read_pressure(struct dps310_data *data, int *val, int *val2,
} }
} }
static int dps310_calculate_temp(struct dps310_data *data) static int dps310_calculate_temp(struct dps310_data *data, int *val)
{ {
s64 c0; s64 c0;
s64 t; s64 t;
@ -746,7 +746,9 @@ static int dps310_calculate_temp(struct dps310_data *data)
t = c0 + ((s64)data->temp_raw * (s64)data->c1); t = c0 + ((s64)data->temp_raw * (s64)data->c1);
/* Convert to milliCelsius and scale the temperature */ /* Convert to milliCelsius and scale the temperature */
return (int)div_s64(t * 1000LL, kt); *val = (int)div_s64(t * 1000LL, kt);
return 0;
} }
static int dps310_read_temp(struct dps310_data *data, int *val, int *val2, static int dps310_read_temp(struct dps310_data *data, int *val, int *val2,
@ -768,11 +770,10 @@ static int dps310_read_temp(struct dps310_data *data, int *val, int *val2,
if (rc) if (rc)
return rc; return rc;
rc = dps310_calculate_temp(data); rc = dps310_calculate_temp(data, val);
if (rc < 0) if (rc)
return rc; return rc;
*val = rc;
return IIO_VAL_INT; return IIO_VAL_INT;
case IIO_CHAN_INFO_OVERSAMPLING_RATIO: case IIO_CHAN_INFO_OVERSAMPLING_RATIO: