Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bpf: Fix potential integer overflow in resolve_btfids

Browse source 
[ Upstream commit 44382b3ed6b2787710c8ade06c0e97f5970a47c8 ]

err is a 32-bit integer, but elf_update returns an off_t, which is 64-bit
at least on 64-bit platforms. If symbols_patch is called on a binary between
2-4GB in size, the result will be negative when cast to a 32-bit integer,
which the code assumes means an error occurred. This can wrongly trigger
build failures when building very large kernel images.

Fixes: fbbb68de80a4 ("bpf: Add resolve_btfids tool to resolve BTF IDs in ELF object")
Signed-off-by: Friedrich Vock <friedrich.vock@gmx.de>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20240514070931.199694-1-friedrich.vock@gmx.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Friedrich Vock 2024-05-14 09:09:31 +02:00 committed by Ksawlii
parent b89189f48e
commit 5f32c37821
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/bpf/resolve_btfids/main.c
View file

@ -637,7 +637,7 @@ static int sets_patch(struct object *obj)
static int symbols_patch(struct object *obj) static int symbols_patch(struct object *obj)
{ {
int err; off_t err;
if (__symbols_patch(obj, &obj->structs) || if (__symbols_patch(obj, &obj->structs) ||
__symbols_patch(obj, &obj->unions) || __symbols_patch(obj, &obj->unions) ||