Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

media: i2c: max9286: Fix some redundant of_node_put() calls

Browse source 
[ Upstream commit 0822315e46b400f611cba1193456ee6a5dc3e41d ]

This is odd to have a of_node_put() just after a for_each_child_of_node()
or a for_each_endpoint_of_node() loop. It should already be called
during the last iteration.

Remove these calls.

Fixes: 66d8c9d2422d ("media: i2c: Add MAX9286 driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Christophe JAILLET 2023-08-26 00:13:40 +02:00 • committed by Ksawlii
parent ba5cb6b896
commit 4785dfc51a
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/media/i2c/max9286.c
View file

@ -1143,7 +1143,6 @@ static int max9286_parse_dt(struct max9286_priv *priv)
i2c_mux_mask |= BIT(id); i2c_mux_mask |= BIT(id);
} }
of_node_put(node);
of_node_put(i2c_mux); of_node_put(i2c_mux);
/* Parse the endpoints */ /* Parse the endpoints */
@ -1207,7 +1206,6 @@ static int max9286_parse_dt(struct max9286_priv *priv)
priv->source_mask |= BIT(ep.port); priv->source_mask |= BIT(ep.port);
priv->nsources++; priv->nsources++;
} }
of_node_put(node);
priv->route_mask = priv->source_mask; priv->route_mask = priv->source_mask;