Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dmaengine: axi-dmac: fix possible race in remove()

Browse source 
commit 1bc31444209c8efae98cb78818131950d9a6f4d6 upstream.

We need to first free the IRQ before calling of_dma_controller_free().
Otherwise we could get an interrupt and schedule a tasklet while
removing the DMA controller.

Fixes: 0e3b67b348b8 ("dmaengine: Add support for the Analog Devices AXI-DMAC DMA controller")
Cc: stable@kernel.org
Signed-off-by: Nuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20240328-axi-dmac-devm-probe-v3-1-523c0176df70@analog.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Nuno Sa 2024-03-28 14:58:50 +01:00 committed by Ksawlii
parent 163c8dd6f6
commit 4774f8a2da
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/dma/dma-axi-dmac.c
View file

@ -1020,8 +1020,8 @@ static int axi_dmac_remove(struct platform_device *pdev)
{ {
struct axi_dmac *dmac = platform_get_drvdata(pdev); struct axi_dmac *dmac = platform_get_drvdata(pdev);
of_dma_controller_free(pdev->dev.of_node);
free_irq(dmac->irq, dmac); free_irq(dmac->irq, dmac);
of_dma_controller_free(pdev->dev.of_node);
tasklet_kill(&dmac->chan.vchan.task); tasklet_kill(&dmac->chan.vchan.task);
dma_async_device_unregister(&dmac->dma_dev); dma_async_device_unregister(&dmac->dma_dev);
clk_disable_unprepare(dmac->clk); clk_disable_unprepare(dmac->clk);