Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

rpmsg: Fix kfree() of static memory on setting driver_override

Browse source 
commit 42cd402b8fd4672b692400fe5f9eecd55d2794ac upstream.

The driver_override field from platform driver should not be initialized
from static memory (string literal) because the core later kfree() it,
for example when driver_override is set via sysfs.

Use dedicated helper to set driver_override properly.

Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver")
Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220419113435.246203-13-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Krzysztof Kozlowski 2023-10-31 11:33:51 +00:00 committed by Ksawlii
parent 2545714842
commit 44130fdb6a
2 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/rpmsg/rpmsg_internal.h
View file

@ -89,10 +89,19 @@ struct device *rpmsg_find_device(struct device *parent,
*/ */
static inline int rpmsg_chrdev_register_device(struct rpmsg_device *rpdev) static inline int rpmsg_chrdev_register_device(struct rpmsg_device *rpdev)
{ {
strcpy(rpdev->id.name, "rpmsg_chrdev"); int ret;
rpdev->driver_override = "rpmsg_chrdev";
return rpmsg_register_device(rpdev); strcpy(rpdev->id.name, "rpmsg_chrdev");
ret = driver_set_override(&rpdev->dev, &rpdev->driver_override,
rpdev->id.name, strlen(rpdev->id.name));
if (ret)
return ret;
ret = rpmsg_register_device(rpdev);
if (ret)
kfree(rpdev->driver_override);
return ret;
} }
#endif #endif

6
include/linux/rpmsg.h
View file

@ -42,7 +42,9 @@ struct rpmsg_channel_info {
* rpmsg_device - device that belong to the rpmsg bus * rpmsg_device - device that belong to the rpmsg bus
* @dev: the device struct * @dev: the device struct
* @id: device id (used to match between rpmsg drivers and devices) * @id: device id (used to match between rpmsg drivers and devices)
* @driver_override: driver name to force a match * @driver_override: driver name to force a match; do not set directly,
* because core frees it; use driver_set_override() to
* set or clear it.
* @src: local address * @src: local address
* @dst: destination address * @dst: destination address
* @ept: the rpmsg endpoint of this channel * @ept: the rpmsg endpoint of this channel
@ -51,7 +53,7 @@ struct rpmsg_channel_info {
struct rpmsg_device { struct rpmsg_device {
struct device dev; struct device dev;
struct rpmsg_device_id id; struct rpmsg_device_id id;
char *driver_override; const char *driver_override;
u32 src; u32 src;
u32 dst; u32 dst;
struct rpmsg_endpoint *ept; struct rpmsg_endpoint *ept;