Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

i3c: Fix potential refcount leak in i3c_master_register_new_i3c_devs

Browse source 
[ Upstream commit cab63f64887616e3c4e31cfd8103320be6ebc8d3 ]

put_device() needs to be called on failure of device_register()
to give up the reference initialized in it to avoid refcount leak.

Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20230921082410.25548-1-dinghao.liu@zju.edu.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dinghao Liu 2023-09-21 16:24:10 +08:00 • committed by Ksawlii
parent d40738011e
commit 2e21c0cbc5
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/i3c/master.c
View file

@ -1509,9 +1509,11 @@ i3c_master_register_new_i3c_devs(struct i3c_master_controller *master)
desc->dev->dev.of_node = desc->boardinfo->of_node; desc->dev->dev.of_node = desc->boardinfo->of_node;
ret = device_register(&desc->dev->dev); ret = device_register(&desc->dev->dev);
if (ret) if (ret) {
dev_err(&master->dev, dev_err(&master->dev,
"Failed to add I3C device (err = %d)\n", ret); "Failed to add I3C device (err = %d)\n", ret);
put_device(&desc->dev->dev);
}
} }
} }