Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare()

Browse source 
[ Upstream commit 6320b9199dd99622668649c234d4e8a99e44a9c8 ]

The mipi_dsi_dcs_nop() function returns an error but we weren't
checking it in boe_panel_prepare(). Add a check. This is highly
unlikely to matter in practice. If the NOP failed then likely later
MIPI commands would fail too.

Found by code inspection.

Fixes: 812562b8d881 ("drm/panel: boe-tv101wum-nl6: Fine tune the panel power sequence")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240517143643.3.Ibffbaa5b4999ac0e55f43bf353144433b099d727@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240517143643.3.Ibffbaa5b4999ac0e55f43bf353144433b099d727@changeid
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Douglas Anderson 2024-05-17 14:36:38 -07:00 • committed by Ksawlii
parent b0a9c55a2d
commit 2528ed0c5d
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
View file

@ -553,7 +553,11 @@ static int boe_panel_prepare(struct drm_panel *panel)
usleep_range(5000, 10000); usleep_range(5000, 10000);
if (boe->desc->lp11_before_reset) { if (boe->desc->lp11_before_reset) {
mipi_dsi_dcs_nop(boe->dsi); ret = mipi_dsi_dcs_nop(boe->dsi);
if (ret < 0) {
dev_err(&boe->dsi->dev, "Failed to send NOP: %d\n", ret);
goto poweroff;
}
usleep_range(1000, 2000); usleep_range(1000, 2000);
} }
gpiod_set_value(boe->enable_gpio, 1); gpiod_set_value(boe->enable_gpio, 1);