From 212effe101c20bf9ca857fb1ab04c44711d72f2a Mon Sep 17 00:00:00 2001 From: Saravana Kannan Date: Fri, 22 Jul 2022 01:46:35 -0700 Subject: [PATCH] pinctrl: gs-samsung: Finish initializing the gpios before registering them As soon as a gpio is registered, it should be usable by a consumer. So, do all the initialization before registering the gpios. Without this change, a consumer can request a GPIO IRQ and have the gpio to IRQ mapping fail. Change-Id: If3e264ab764c633f00fcc280db0e1f9a10af5efb Signed-off-by: Saravana Kannan (cherry picked from commit 32188bddc9d8ba8d5907882ed5bd1dc3a83662a9) --- drivers/pinctrl/samsung/pinctrl-samsung.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index ed1ff35ee..547734128 100755 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -1305,15 +1305,15 @@ static int samsung_pinctrl_probe(struct platform_device *pdev) if (ret) goto err_put_banks; - ret = samsung_gpiolib_register(pdev, drvdata); - if (ret) - goto err_unregister; - if (ctrl->eint_gpio_init) ctrl->eint_gpio_init(drvdata); if (ctrl->eint_wkup_init) ctrl->eint_wkup_init(drvdata); + ret = samsung_gpiolib_register(pdev, drvdata); + if (ret) + goto err_unregister; + platform_set_drvdata(pdev, drvdata); /* Add to the global list */