Ksawlii/kernel_samsung_a53x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

NFSD: fix leaked reference count of nfsd4_ssc_umount_item

Browse source 
[ Upstream commit 34e8f9ec4c9ac235f917747b23a200a5e0ec857b ]

The reference count of nfsd4_ssc_umount_item is not decremented
on error conditions. This prevents the laundromat from unmounting
the vfsmount of the source file.

This patch decrements the reference count of nfsd4_ssc_umount_item
on error.

Fixes: f4e44b393389 ("NFSD: delay unmount source's export after inter-server copy completed.")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dai Ngo 2023-01-23 21:34:13 -08:00 • committed by Ksawlii
parent b9cd1e8628
commit 08def480f9
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
fs/nfsd/nfs4proc.c
View file

@ -1809,13 +1809,17 @@ out:
release_copy_files(copy); release_copy_files(copy);
return status; return status;
out_err: out_err:
if (nfsd4_ssc_is_inter(copy)) {
/*
* Source's vfsmount of inter-copy will be unmounted
* by the laundromat. Use copy instead of async_copy
* since async_copy->ss_nsui might not be set yet.
*/
refcount_dec(&copy->ss_nsui->nsui_refcnt);
}
if (async_copy) if (async_copy)
cleanup_async_copy(async_copy); cleanup_async_copy(async_copy);
status = nfserrno(-ENOMEM); status = nfserrno(-ENOMEM);
/*
* source's vfsmount of inter-copy will be unmounted
* by the laundromat
*/
goto out; goto out;
} }